From: Tudor Ambarus <tudor.ambarus@microchip.com>
To: Yogesh Gaur <yogeshnarayan.gaur@nxp.com>,
<linux-mtd@lists.infradead.org>, <linux-spi@vger.kernel.org>
Cc: <boris.brezillon@bootlin.com>, <linux-kernel@vger.kernel.org>,
<marek.vasut@gmail.com>, <frieder.schrempf@exceet.de>,
<cyrille.pitchen@wedev4u.fr>, <computersforpeace@gmail.com>
Subject: Re: [RESEND PATCH 2/2] mtd: spi-nor: add entry for mt35xu512aba flash
Date: Wed, 19 Sep 2018 19:23:05 +0300 [thread overview]
Message-ID: <b5858a4e-617a-4b06-8743-521e20489268@microchip.com> (raw)
In-Reply-To: <1537332608-19561-3-git-send-email-yogeshnarayan.gaur@nxp.com>
Hi,
On 09/19/2018 07:50 AM, Yogesh Gaur wrote:
> Add entry for mt35xu512aba Micron NOR flash.
> This flash is having uniform sector erase size of 128KB, have
> support of FSR(flag status register), flash size is 64MB and
> supports 4-byte commands.
>
Seems that the datasheet for mt35xu512aba is not public, I couldn't verify your
statement.
> Signed-off-by: Yogesh Gaur <yogeshnarayan.gaur@nxp.com>
> ---
> drivers/mtd/spi-nor/spi-nor.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
> index 33a55bc..6042df8 100644
> --- a/drivers/mtd/spi-nor/spi-nor.c
> +++ b/drivers/mtd/spi-nor/spi-nor.c
> @@ -1113,6 +1113,9 @@ static int spi_nor_is_locked(struct mtd_info *mtd, loff_t ofs, uint64_t len)
> { "n25q00a", INFO(0x20bb21, 0, 64 * 1024, 2048, SECT_4K | USE_FSR | SPI_NOR_QUAD_READ | NO_CHIP_ERASE) },
> { "mt25qu02g", INFO(0x20bb22, 0, 64 * 1024, 4096, SECT_4K | USE_FSR | SPI_NOR_QUAD_READ | NO_CHIP_ERASE) },
>
> + /* Micron */
> + { "mt35xu512aba", INFO(0x2c5b1a, 0, 128 * 1024, 512, SECT_4K | USE_FSR | SPI_NOR_4B_OPCODES) },
nitpick on style: Brian picked a style that seems reasonable for splitting up
the flags, see 9648388fc7737365be7a8092e77df78ccc2cd1a4.
Best,
ta
prev parent reply other threads:[~2018-09-19 16:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-19 4:50 [RESEND PATCH 0/2] mtd: spi-nor: add entry for mt35xu512aba flash Yogesh Gaur
2018-09-19 4:50 ` [RESEND PATCH 1/2] mtd: spi-nor: add macros related to MICRON flash Yogesh Gaur
2018-09-19 16:30 ` Tudor Ambarus
2018-09-20 4:31 ` Yogesh Narayan Gaur
2018-09-20 9:20 ` Tudor Ambarus
2018-10-09 4:01 ` Tudor Ambarus
2018-09-19 4:50 ` [RESEND PATCH 2/2] mtd: spi-nor: add entry for mt35xu512aba flash Yogesh Gaur
2018-09-19 16:23 ` Tudor Ambarus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b5858a4e-617a-4b06-8743-521e20489268@microchip.com \
--to=tudor.ambarus@microchip.com \
--cc=boris.brezillon@bootlin.com \
--cc=computersforpeace@gmail.com \
--cc=cyrille.pitchen@wedev4u.fr \
--cc=frieder.schrempf@exceet.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=marek.vasut@gmail.com \
--cc=yogeshnarayan.gaur@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).