From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760287AbcKDIaY (ORCPT ); Fri, 4 Nov 2016 04:30:24 -0400 Received: from szxga03-in.huawei.com ([119.145.14.66]:59666 "EHLO szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756454AbcKDIaV (ORCPT ); Fri, 4 Nov 2016 04:30:21 -0400 Subject: Re: [PATCH 2/2] f2fs: don't skip recovering inode depend on i_times To: Jaegeuk Kim , Chao Yu References: <20161103162656.2982-1-chao@kernel.org> <20161103162656.2982-2-chao@kernel.org> <20161103180233.GC76264@jaegeuk> CC: , , From: Chao Yu Message-ID: Date: Fri, 4 Nov 2016 16:30:09 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: <20161103180233.GC76264@jaegeuk> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.134.22.195] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016/11/4 2:02, Jaegeuk Kim wrote: > On Fri, Nov 04, 2016 at 12:26:56AM +0800, Chao Yu wrote: >> From: Chao Yu >> >> i_times of inode will be set with current system time which can be >> configured through 'date', so it's not safe to judge dnode block as >> garbage data depend on i_times. > > This is not to detect garbage data, but to skip redundant unchanged inode. Oops, seems 807b1e1c8e08 ("f2fs: do not recover from previous remained wrong dnodes") did't describe like that. But after reading the codes, it looks like the purpose of this change is to skip unchanged inode. So, commit log in original is incorrect, right? Thanks,