From: YueHaibing <yuehaibing@huawei.com>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: <davem@davemloft.net>, <ubraun@linux.ibm.com>,
<linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>,
<linux-s390@vger.kernel.org>
Subject: Re: [PATCH net-next] net/smc: cast sizeof to int for comparison
Date: Mon, 17 Sep 2018 11:57:40 +0800 [thread overview]
Message-ID: <b598de63-f026-c3ff-3380-8b1814f90b82@huawei.com> (raw)
In-Reply-To: <87zhwj6liz.fsf@igel.home>
On 2018/9/15 19:35, Andreas Schwab wrote:
> On Sep 15 2018, YueHaibing <yuehaibing@huawei.com> wrote:
>
>> Comparing an int to a size, which is unsigned, causes the int to become
>> unsigned, giving the wrong result. kernel_sendmsg can return a negative
>> error code.
>>
>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>> ---
>> net/smc/smc_clc.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/net/smc/smc_clc.c b/net/smc/smc_clc.c
>> index 83aba9a..fd0f5ce 100644
>> --- a/net/smc/smc_clc.c
>> +++ b/net/smc/smc_clc.c
>> @@ -446,7 +446,7 @@ int smc_clc_send_proposal(struct smc_sock *smc, int smc_type,
>> vec[i++].iov_len = sizeof(trl);
>> /* due to the few bytes needed for clc-handshake this cannot block */
>> len = kernel_sendmsg(smc->clcsock, &msg, vec, i, plen);
>> - if (len < sizeof(pclc)) {
>> + if (len < (int)sizeof(pclc)) {
>> if (len >= 0) {
>> reason_code = -ENETUNREACH;
>> smc->sk.sk_err = -reason_code;
>
> It would perhaps be better to handle len < 0 first.
That need refactor the err hangding, is worth doing it?
>
> Andreas.
>
next prev parent reply other threads:[~2018-09-17 3:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-15 10:00 [PATCH net-next] net/smc: cast sizeof to int for comparison YueHaibing
2018-09-15 11:35 ` Andreas Schwab
2018-09-17 3:57 ` YueHaibing [this message]
2018-09-17 8:42 ` Andreas Schwab
2018-09-17 8:49 ` Ursula Braun
2018-09-17 9:38 ` YueHaibing
2018-09-17 11:49 ` Ursula Braun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b598de63-f026-c3ff-3380-8b1814f90b82@huawei.com \
--to=yuehaibing@huawei.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=schwab@linux-m68k.org \
--cc=ubraun@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).