From: Paolo Bonzini <pbonzini@redhat.com>
To: "Xiao Guangrong" <guangrong.xiao@gmail.com>,
"Sironi, Filippo" <sironi@amazon.de>,
"Radim Krčmář" <rkrcmar@redhat.com>
Cc: "Liguori, Anthony" <aliguori@amazon.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86, kvm: Handle PFNs outside of kernel reach when touching GPTEs
Date: Tue, 18 Apr 2017 10:12:34 +0200 [thread overview]
Message-ID: <b5b85c87-dfa4-1757-705d-191f4791837c@redhat.com> (raw)
In-Reply-To: <1b77a9a3-6fc0-1258-026e-5977a6e9dba6@gmail.com>
On 17/04/2017 13:26, Xiao Guangrong wrote:
>>
>
> Sounds reasonable, however it is incomplete so far as there are some
> code paths still do not support non-page backend memory, e.g,
> emulator_cmpxchg_emulated().
>
> I would suggest to unify the code introduced in this patch with existing
> hva_to_pfn(), also we can introduce a common API, maybe named
> kvm_map_hva(), to improve the caller sides.
I agree with Guangrong's suggestion.
Paolo
> BTW, i do not know why we used kmap_atomic() rather than kmap(), the
> path of cmpxchg_gpte() is sleep-able anyway.
next prev parent reply other threads:[~2017-04-18 8:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-05 13:07 [PATCH] x86, kvm: Handle PFNs outside of kernel reach when touching GPTEs Filippo Sironi
2017-04-06 14:22 ` Radim Krčmář
2017-04-12 13:16 ` Sironi, Filippo
2017-04-17 11:26 ` Xiao Guangrong
2017-04-18 8:12 ` Paolo Bonzini [this message]
2017-04-13 15:20 ` Filippo Sironi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b5b85c87-dfa4-1757-705d-191f4791837c@redhat.com \
--to=pbonzini@redhat.com \
--cc=aliguori@amazon.com \
--cc=guangrong.xiao@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rkrcmar@redhat.com \
--cc=sironi@amazon.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).