From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7269AC433F5 for ; Tue, 14 Sep 2021 13:44:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5636661108 for ; Tue, 14 Sep 2021 13:44:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233268AbhINNqK (ORCPT ); Tue, 14 Sep 2021 09:46:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55782 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232079AbhINNqI (ORCPT ); Tue, 14 Sep 2021 09:46:08 -0400 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8B63AC061574; Tue, 14 Sep 2021 06:44:50 -0700 (PDT) Received: by mail-lf1-x12b.google.com with SMTP id a4so28939687lfg.8; Tue, 14 Sep 2021 06:44:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=LiLFG3jsLAnjnyRijL4uVe0GMRh42AXtUakCNsayxDQ=; b=ox3Ob1BWKW9EHiBA6DLTWNQHG6Ri8fNwCj46D8Mn9LQtvLlDjcOQdnELXnRL/Aovpm +nT/Eau3mAtAQolDEXBOV1xTdwRNtEoo7g0a1kYcxyxf9lhT1qZE5JgbsR1/OqJiG8o9 6f3CPWvYdYDwF1Zq9qqkaOMZHzGSFpCDJlZCCi/1T+vn3NJsNsy7OtNp+GRSIQnU2Guy +hju6kS3WvmVLnVrrNBK2ssDY+e+/xM7wbmBbtjQJfRlqIESSkPjjlIRa1zqi0fgtV7e MxhPJ2MWxpoVvtedazb436UsS1IyVncEA2aJ1nQJFD8T1NomN7QBDlPAURUVgAXJXkYx b6rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=LiLFG3jsLAnjnyRijL4uVe0GMRh42AXtUakCNsayxDQ=; b=rLdQ75Ju1E88ncz/Qles0ofr/yasYzYc5okIOGI1Fg8eSrQzSxidyi3iFmdppmmVMy FemZjuHfN3RcNyagOxoHjIaAnpWusEFSMotIqrWNzRbmIsV7+eO8FDxE7arVxD4YcwoS wLT150x/pPd1maspxRZTq+ZImNW+i8mWmZg/lwswXsM/D5sYoqCODFHdPvQw0DIoFNeB AzA9qjbILk7I802fmWFOifFQojWNBVYvhLmbqi9kDngsj8bSewnsbop4BcuiWCBTr1gv 6boHSPZDlHSYkkvk6CiFxPJYKZY9/khvvMXJvmjr8V5XKWjfkpfNvfAlLLZMkUSMGV4W M/Tg== X-Gm-Message-State: AOAM530CA4XYmbK1QyhFjL3FCoaNeZvcnDZ9QE9+KGUpgxGXq6fuxBu2 9wtzn7S7kQmBFHJ4LZLYYHaeNi8ShlA= X-Google-Smtp-Source: ABdhPJxiYS4pffxw5IF8csizK0wbDOGl1IRJGoO7qlkdQqSwq85+R+U51gQaI7oEpxY96waJhJZYzQ== X-Received: by 2002:ac2:4116:: with SMTP id b22mr13278085lfi.587.1631627088517; Tue, 14 Sep 2021 06:44:48 -0700 (PDT) Received: from [192.168.2.145] (46-138-83-36.dynamic.spd-mgts.ru. [46.138.83.36]) by smtp.googlemail.com with ESMTPSA id g24sm1350578ljm.6.2021.09.14.06.44.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Sep 2021 06:44:48 -0700 (PDT) Subject: Re: [PATCH AUTOSEL 5.14 133/252] spi: tegra20-slink: Improve runtime PM usage To: Sasha Levin , Mark Brown Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, linux-spi@vger.kernel.org, linux-tegra@vger.kernel.org References: <20210909114106.141462-1-sashal@kernel.org> <20210909114106.141462-133-sashal@kernel.org> <20210909123751.GA5176@sirena.org.uk> <20210909130450.GB5176@sirena.org.uk> From: Dmitry Osipenko Message-ID: Date: Tue, 14 Sep 2021 16:44:47 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 13.09.2021 20:14, Sasha Levin пишет: > On Thu, Sep 09, 2021 at 02:04:50PM +0100, Mark Brown wrote: >> On Thu, Sep 09, 2021 at 03:45:45PM +0300, Dmitry Osipenko wrote: >>> 09.09.2021 15:37, Mark Brown пишет: >> >>> > This feels new featureish to me - it'll give you runtime PM where >>> > previously there was none. >> >>> Apparently all patches which have a word 'fix' in commit message are >>> auto-selected. I agree that it's better not to port this patch. >> >> Yeah, it's a fairly common source of false positives :/ > > And some of that falls on me: if it's obvious that the "fix" isn't a > real fix, I won't take it. In cases like this it's not clear to me > whether it's purely a better behaviour, or whether the devices staying > on/off/etc causes an actual problem. > You made the right choice. It's indeed not obvious from commit message what is achieved with this change. This patch shouldn't have any visible effect on older kernels which don't support power management in a case of Tegra SoCs. It will have effect using the upcoming kernels, once the full set of in-progress power management patches will be merged.