From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73C4CC64E8A for ; Wed, 2 Dec 2020 06:40:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 17E1622203 for ; Wed, 2 Dec 2020 06:40:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728670AbgLBGkt (ORCPT ); Wed, 2 Dec 2020 01:40:49 -0500 Received: from szxga06-in.huawei.com ([45.249.212.32]:8489 "EHLO szxga06-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726202AbgLBGks (ORCPT ); Wed, 2 Dec 2020 01:40:48 -0500 Received: from DGGEMS405-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4Cm8TY6L6jzhglk; Wed, 2 Dec 2020 14:39:45 +0800 (CST) Received: from [10.136.114.67] (10.136.114.67) by smtp.huawei.com (10.3.19.205) with Microsoft SMTP Server (TLS) id 14.3.487.0; Wed, 2 Dec 2020 14:40:04 +0800 Subject: Re: [f2fs-dev] [PATCH v2 2/2] f2fs: add F2FS_IOC_DECOMPRESS_FILE and F2FS_IOC_COMPRESS_FILE To: Daeho Jeong , , , CC: Daeho Jeong References: <20201201040803.3590442-1-daeho43@gmail.com> <20201201040803.3590442-2-daeho43@gmail.com> From: Chao Yu Message-ID: Date: Wed, 2 Dec 2020 14:40:04 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20201201040803.3590442-2-daeho43@gmail.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.136.114.67] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020/12/1 12:08, Daeho Jeong wrote: > From: Daeho Jeong > > Added two ioctl to decompress/compress explicitly the compression > enabled file in "compress_mode=user" mount option. > > Using these two ioctls, the users can make a control of compression > and decompression of their files. > > Signed-off-by: Daeho Jeong > --- > v2: reformed codes based on comments and put gradual flush routine > --- > fs/f2fs/file.c | 185 ++++++++++++++++++++++++++++++++++++++ > include/uapi/linux/f2fs.h | 2 + > 2 files changed, 187 insertions(+) > > diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c > index be8db06aca27..300355fe25f0 100644 > --- a/fs/f2fs/file.c > +++ b/fs/f2fs/file.c > @@ -4026,6 +4026,185 @@ static int f2fs_ioc_set_compress_option(struct file *filp, unsigned long arg) > return ret; > } > > +static int redirty_blocks(struct inode *inode, pgoff_t page_idx, int len) > +{ > + DEFINE_READAHEAD(ractl, NULL, inode->i_mapping, page_idx); > + struct address_space *mapping = inode->i_mapping; > + struct page *page; > + pgoff_t redirty_idx = page_idx; > + int i, page_len = 0, ret = 0; > + > + page_cache_ra_unbounded(&ractl, len, 0); > + > + for (i = 0; i < len; i++, page_idx++) { > + page = read_cache_page(mapping, page_idx, NULL, NULL); > + if (IS_ERR(page)) { > + ret = PTR_ERR(page); > + break; > + } > + page_len++; > + } > + > + for (i = 0; i < page_len; i++, redirty_idx++) { > + page = find_lock_page(mapping, redirty_idx); > + if (!page) > + ret = -ENOENT; > + set_page_dirty(page); > + f2fs_put_page(page, 1); > + f2fs_put_page(page, 0); > + } > + > + return ret; > +} > + > +static int f2fs_ioc_decompress_file(struct file *filp, unsigned long arg) > +{ > + struct inode *inode = file_inode(filp); > + struct f2fs_sb_info *sbi = F2FS_I_SB(inode); > + struct f2fs_inode_info *fi = F2FS_I(inode); > + pgoff_t page_idx = 0, last_idx; > + unsigned int blk_per_seg = sbi->blocks_per_seg, dirtied = 0; > + int cluster_size = F2FS_I(inode)->i_cluster_size; > + int count, ret; > + > + if (!f2fs_sb_has_compression(sbi) || > + F2FS_OPTION(sbi).compress_mode != COMPR_MODE_USER) > + return -EOPNOTSUPP; > + > + if (!(filp->f_mode & FMODE_WRITE)) > + return -EBADF; > + > + if (!f2fs_compressed_file(inode)) > + return -EINVAL; > + > + if (!f2fs_is_compress_backend_ready(inode)) > + return -ENOPKG; Oh, it looks there will be a race case with f2fs_ioc_set_compress_option(), it needs to relocate this condition under inode lock. In all other places, it will return -EOPNOTSUPP, how about keeping in line with them? > + > + f2fs_balance_fs(F2FS_I_SB(inode), true); > + > + file_start_write(filp); > + inode_lock(inode); > + > + if (f2fs_is_mmap_file(inode)) { > + ret = -EBUSY; > + goto out; > + } > + > + ret = filemap_write_and_wait_range(inode->i_mapping, 0, LLONG_MAX); > + if (ret) > + goto out; > + > + if (!atomic_read(&fi->i_compr_blocks)) > + goto out; > + > + last_idx = DIV_ROUND_UP(i_size_read(inode), PAGE_SIZE); > + > + count = last_idx - page_idx; > + while (count) { > + int len = min(cluster_size, count); > + > + ret = redirty_blocks(inode, page_idx, len); > + if (ret < 0) > + break; > + > + count -= len; > + page_idx += len; > + dirtied += len; use get_dirty_pages(inode) will be a little bit more accurate? as kworker is running to writeback dirty pages in background. > + if (dirtied >= blk_per_seg) { > + filemap_fdatawrite(inode->i_mapping); > + dirtied = 0; > + } > + } > + > + if (!ret) > + ret = filemap_write_and_wait_range(inode->i_mapping, 0, > + LLONG_MAX); > + > + if (ret) > + f2fs_warn(sbi, "%s: The file might be partially decompressed " > + "(errno=%d). Please delete the file.\n", > + __func__, ret); > +out: > + inode_unlock(inode); > + file_end_write(filp); > + > + return ret; > +} > + > +static int f2fs_ioc_compress_file(struct file *filp, unsigned long arg) > +{ > + struct inode *inode = file_inode(filp); > + struct f2fs_sb_info *sbi = F2FS_I_SB(inode); > + pgoff_t page_idx = 0, last_idx; > + unsigned int blk_per_seg = sbi->blocks_per_seg, dirtied = 0; > + int cluster_size = F2FS_I(inode)->i_cluster_size; > + int count, ret; > + > + if (!f2fs_sb_has_compression(sbi) || > + F2FS_OPTION(sbi).compress_mode != COMPR_MODE_USER) > + return -EOPNOTSUPP; > + > + if (!(filp->f_mode & FMODE_WRITE)) > + return -EBADF; > + > + if (!f2fs_compressed_file(inode)) > + return -EINVAL; > + > + if (!f2fs_is_compress_backend_ready(inode)) > + return -ENOPKG; Ditto, > + > + f2fs_balance_fs(F2FS_I_SB(inode), true); > + > + file_start_write(filp); > + inode_lock(inode); > + > + if (f2fs_is_mmap_file(inode)) { > + ret = -EBUSY; > + goto out; > + } > + > + ret = filemap_write_and_wait_range(inode->i_mapping, 0, LLONG_MAX); > + if (ret) > + goto out; > + > + set_inode_flag(inode, FI_ENABLE_COMPRESS); > + > + last_idx = DIV_ROUND_UP(i_size_read(inode), PAGE_SIZE); > + > + count = last_idx - page_idx; > + while (count) { > + int len = min(cluster_size, count); > + > + ret = redirty_blocks(inode, page_idx, len); > + if (ret < 0) > + break; > + > + count -= len; > + page_idx += len; > + dirtied += len; Ditto, > + if (dirtied >= blk_per_seg) { > + filemap_fdatawrite(inode->i_mapping); > + dirtied = 0; > + } > + } > + > + if (!ret) > + ret = filemap_write_and_wait_range(inode->i_mapping, 0, > + LLONG_MAX); > + > + clear_inode_flag(inode, FI_ENABLE_COMPRESS); > + > + if (ret) > + f2fs_warn(sbi, "%s: The file might be partially compressed " > + "(errno=%d). Please delete the file.\n", > + __func__, ret); > +out: > + inode_unlock(inode); > + file_end_write(filp); > + > + return ret; > +} > + > static long __f2fs_ioctl(struct file *filp, unsigned int cmd, unsigned long arg) > { > switch (cmd) { > @@ -4113,6 +4292,10 @@ static long __f2fs_ioctl(struct file *filp, unsigned int cmd, unsigned long arg) > return f2fs_ioc_get_compress_option(filp, arg); > case F2FS_IOC_SET_COMPRESS_OPTION: > return f2fs_ioc_set_compress_option(filp, arg); > + case F2FS_IOC_DECOMPRESS_FILE: > + return f2fs_ioc_decompress_file(filp, arg); > + case F2FS_IOC_COMPRESS_FILE: > + return f2fs_ioc_compress_file(filp, arg); > default: > return -ENOTTY; > } > @@ -4352,6 +4535,8 @@ long f2fs_compat_ioctl(struct file *file, unsigned int cmd, unsigned long arg) > case F2FS_IOC_SEC_TRIM_FILE: > case F2FS_IOC_GET_COMPRESS_OPTION: > case F2FS_IOC_SET_COMPRESS_OPTION: > + case F2FS_IOC_DECOMPRESS_FILE: > + case F2FS_IOC_COMPRESS_FILE: > break; > default: > return -ENOIOCTLCMD; > diff --git a/include/uapi/linux/f2fs.h b/include/uapi/linux/f2fs.h > index f00199a2e38b..352a822d4370 100644 > --- a/include/uapi/linux/f2fs.h > +++ b/include/uapi/linux/f2fs.h > @@ -40,6 +40,8 @@ > struct f2fs_comp_option) > #define F2FS_IOC_SET_COMPRESS_OPTION _IOW(F2FS_IOCTL_MAGIC, 22, \ > struct f2fs_comp_option) > +#define F2FS_IOC_DECOMPRESS_FILE _IO(F2FS_IOCTL_MAGIC, 23) > +#define F2FS_IOC_COMPRESS_FILE _IO(F2FS_IOCTL_MAGIC, 24) > > /* > * should be same as XFS_IOC_GOINGDOWN. >