From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756598AbcKWNle (ORCPT ); Wed, 23 Nov 2016 08:41:34 -0500 Received: from pb-sasl2.pobox.com ([64.147.108.67]:54863 "EHLO sasl.smtp.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S936567AbcKWNlc (ORCPT ); Wed, 23 Nov 2016 08:41:32 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=subject:to :references:cc:from:message-id:date:mime-version:in-reply-to :content-type:content-transfer-encoding; q=dns; s=sasl; b=XClvJG 8LPWg5KSduUjbqAYZQbuZNTTKoYk4FNjUcctrhGL22ys3fT6xQK+VBOIdqV8M8CB hQi7eeDRT0L/Cg+iZLvYXMpgWm/fcW/IrnXphgvHu7jtGWP2XKfa+Ny0w8801y0C x9uQbcFCYFBFO+X4UnrvJACg7IuCpYxPzB2TI= Subject: Re: [PATCH net 1/2] r8152: fix the sw rx checksum is unavailable To: Hayes Wang , "netdev@vger.kernel.org" References: <1394712342-15778-226-Taiwan-albertk@realtek.com> <1394712342-15778-227-Taiwan-albertk@realtek.com> <0835B3720019904CB8F7AA43166CEEB20105013E@RTITMBSV03.realtek.com.tw> <0835B3720019904CB8F7AA43166CEEB201050B7E@RTITMBSV03.realtek.com.tw> <0835B3720019904CB8F7AA43166CEEB2010517CE@RTITMBSV03.realtek.com.tw> Cc: nic_swsd , "linux-kernel@vger.kernel.org" , "linux-usb@vger.kernel.org" From: Mark Lord Message-ID: Date: Wed, 23 Nov 2016 08:41:29 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <0835B3720019904CB8F7AA43166CEEB2010517CE@RTITMBSV03.realtek.com.tw> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Pobox-Relay-ID: 8A1DEFF6-B182-11E6-B3EA-7471F2301B6D-82205200!pb-sasl2.pobox.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org What does this code do: >static void r8153_set_rx_early_size(struct r8152 *tp) >{ > u32 mtu = tp->netdev->mtu; > u32 ocp_data = (agg_buf_sz - mtu - VLAN_ETH_HLEN - VLAN_HLEN) / 4; > > ocp_write_word(tp, MCU_TYPE_USB, USB_RX_EARLY_SIZE, ocp_data); >} How is ocp_data used by the hardware? Shouldn't the calculation also include sizeof(rx_desc) in there somewhere? Thanks -- Mark Lord Real-Time Remedies Inc. mlord@pobox.com