From: Cyrille Pitchen <cyrille.pitchen@atmel.com>
To: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>,
Marek Vasut <marek.vasut@gmail.com>,
Boris Brezillon <boris.brezillon@free-electrons.com>,
Brian Norris <computersforpeace@gmail.com>,
David Woodhouse <dwmw2@infradead.org>,
Richard Weinberger <richard@nod.at>,
<linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] mtd: spi-nor: Fix S3AN addressing calculation
Date: Fri, 20 Jan 2017 14:26:08 +0100 [thread overview]
Message-ID: <b62e4978-3a99-248e-533f-7fde6a378dd7@atmel.com> (raw)
In-Reply-To: <20170118164016.27976-1-ricardo.ribalda@gmail.com>
Le 18/01/2017 à 17:40, Ricardo Ribalda Delgado a écrit :
> The page calculation under spi_nor_s3an_addr_convert() was wrong. On
> Default Address Mode we need to perform a divide by page_size.
>
> Fixes: 61cba34bd6c1 ("mtd: spi-nor: Add support for S3AN spi-nor devices")
> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
Reviewed-by: Cyrille Pitchen <cyrille.pitchen@atmel.com>
Marek, any comment on your side?
> ---
>
> v2: Suggested by Marek Vasut <marek.vasut@gmail.com>
> -Use more descriptive name for page
>
> drivers/mtd/spi-nor/spi-nor.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
> index 2a643a1bb45e..f5c3ce8ac48b 100644
> --- a/drivers/mtd/spi-nor/spi-nor.c
> +++ b/drivers/mtd/spi-nor/spi-nor.c
> @@ -431,11 +431,14 @@ static void spi_nor_unlock_and_unprep(struct spi_nor *nor, enum spi_nor_ops ops)
> */
> static loff_t spi_nor_s3an_addr_convert(struct spi_nor *nor, unsigned int addr)
> {
> - unsigned int offset = addr;
> + unsigned int offset;
> + unsigned int page;
>
> - offset %= nor->page_size;
> + offset = addr % nor->page_size;
> + page = addr / nor->page_size;
> + page <<= (nor->page_size > 512) ? 10 : 9;
>
> - return ((addr - offset) << 1) | offset;
> + return page | offset;
> }
>
> /*
>
next prev parent reply other threads:[~2017-01-20 13:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-18 16:40 [PATCH v2] mtd: spi-nor: Fix S3AN addressing calculation Ricardo Ribalda Delgado
2017-01-20 13:26 ` Cyrille Pitchen [this message]
2017-01-20 13:48 ` Marek Vasut
2017-01-20 14:44 ` Cyrille Pitchen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b62e4978-3a99-248e-533f-7fde6a378dd7@atmel.com \
--to=cyrille.pitchen@atmel.com \
--cc=boris.brezillon@free-electrons.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=ricardo.ribalda@gmail.com \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).