linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mukesh Ojha <mojha@codeaurora.org>
To: Jann Horn <jannh@google.com>, Kees Cook <keescook@chromium.org>
Cc: linux-kernel@vger.kernel.org, James Morris <jmorris@namei.org>,
	"Serge E. Hallyn" <serge@hallyn.com>,
	linux-security-module@vger.kernel.org
Subject: Re: [PATCH] Yama: mark local symbols as static
Date: Wed, 27 Mar 2019 18:12:52 +0530	[thread overview]
Message-ID: <b63d2960-98f4-a2cd-41a5-3d9bd1ff0ec5@codeaurora.org> (raw)
In-Reply-To: <20190326230841.87834-1-jannh@google.com>


On 3/27/2019 4:38 AM, Jann Horn wrote:
> sparse complains that Yama defines functions and a variable as non-static
> even though they don't exist in any header. Fix it by making them static.
>
> Signed-off-by: Jann Horn <jannh@google.com>

Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>


> ---
>   security/yama/yama_lsm.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/security/yama/yama_lsm.c b/security/yama/yama_lsm.c
> index 57cc60722dd3..06b14a57b0a4 100644
> --- a/security/yama/yama_lsm.c
> +++ b/security/yama/yama_lsm.c
> @@ -206,7 +206,7 @@ static void yama_ptracer_del(struct task_struct *tracer,
>    * yama_task_free - check for task_pid to remove from exception list
>    * @task: task being removed
>    */
> -void yama_task_free(struct task_struct *task)
> +static void yama_task_free(struct task_struct *task)
>   {
>   	yama_ptracer_del(task, task);
>   }
> @@ -401,7 +401,7 @@ static int yama_ptrace_access_check(struct task_struct *child,
>    *
>    * Returns 0 if following the ptrace is allowed, -ve on error.
>    */
> -int yama_ptrace_traceme(struct task_struct *parent)
> +static int yama_ptrace_traceme(struct task_struct *parent)
>   {
>   	int rc = 0;
>   
> @@ -452,7 +452,7 @@ static int yama_dointvec_minmax(struct ctl_table *table, int write,
>   static int zero;
>   static int max_scope = YAMA_SCOPE_NO_ATTACH;
>   
> -struct ctl_path yama_sysctl_path[] = {
> +static struct ctl_path yama_sysctl_path[] = {
>   	{ .procname = "kernel", },
>   	{ .procname = "yama", },
>   	{ }

  reply	other threads:[~2019-03-27 12:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-26 23:08 Jann Horn
2019-03-27 12:42 ` Mukesh Ojha [this message]
2019-04-10 17:26 ` James Morris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b63d2960-98f4-a2cd-41a5-3d9bd1ff0ec5@codeaurora.org \
    --to=mojha@codeaurora.org \
    --cc=jannh@google.com \
    --cc=jmorris@namei.org \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=serge@hallyn.com \
    --subject='Re: [PATCH] Yama: mark local symbols as static' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).