From: Lu Baolu <baolu.lu@linux.intel.com>
To: Robin Murphy <robin.murphy@arm.com>,
John Garry <john.garry@huawei.com>,
joro@8bytes.org, will@kernel.org, dwmw2@infradead.org,
corbet@lwn.net
Cc: baolu.lu@linux.intel.com, linux-kernel@vger.kernel.org,
iommu@lists.linux-foundation.org, linuxarm@huawei.com,
thunder.leizhen@huawei.com, chenxiang66@hisilicon.com,
linux-doc@vger.kernel.org
Subject: Re: [PATCH v13 6/6] iommu: Remove mode argument from iommu_set_dma_strict()
Date: Fri, 18 Jun 2021 09:51:48 +0800 [thread overview]
Message-ID: <b6484679-0950-8c8e-98c5-da0e4c1d97e2@linux.intel.com> (raw)
In-Reply-To: <7d0fb0e2-4671-16db-6963-b0493d7a549b@arm.com>
Hi Robin,
On 6/18/21 2:56 AM, Robin Murphy wrote:
>>> diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c
>>> index 60b1ec42e73b..ff221d3ddcbc 100644
>>> --- a/drivers/iommu/iommu.c
>>> +++ b/drivers/iommu/iommu.c
>>> @@ -349,10 +349,9 @@ static int __init iommu_dma_setup(char *str)
>>> }
>>> early_param("iommu.strict", iommu_dma_setup);
>>> -void iommu_set_dma_strict(bool strict)
>>> +void iommu_set_dma_strict(void)
>>> {
>>> - if (strict || !(iommu_cmd_line & IOMMU_CMD_LINE_STRICT))
>>> - iommu_dma_strict = strict;
>>> + iommu_dma_strict = true;
>>
>> Sorry, I still can't get how iommu.strict kernel option works.
>>
>> static int __init iommu_dma_setup(char *str)
>> {
>> int ret = kstrtobool(str, &iommu_dma_strict);
>
> Note that this is the bit that does the real work - if the argument
> parses OK then iommu_dma_strict is reassigned with the appropriate
> value. The iommu_cmd_line stuff is a bit of additional bookkeeping,
> basically just so we can see whether default values have been overridden.
Ah, get it. Thanks a lot. I missed this part and naively thought it just
converts a string to integer.
Best regards,
baolu
prev parent reply other threads:[~2021-06-18 1:53 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-16 11:03 [PATCH v13 0/6] iommu: Enhance IOMMU default DMA mode build options John Garry
2021-06-16 11:03 ` [PATCH v13 1/6] iommu: Deprecate Intel and AMD cmdline methods to enable strict mode John Garry
2021-06-17 19:01 ` Robin Murphy
2021-06-18 7:43 ` John Garry
2021-06-16 11:03 ` [PATCH v13 2/6] iommu: Print strict or lazy mode at init time John Garry
2021-06-16 11:03 ` [PATCH v13 3/6] iommu: Enhance IOMMU default DMA mode build options John Garry
2021-06-16 11:03 ` [PATCH v13 4/6] iommu/vt-d: Add support for " John Garry
2021-06-17 7:32 ` Lu Baolu
2021-06-17 8:00 ` John Garry
2021-06-17 19:03 ` Robin Murphy
2021-06-18 1:46 ` Lu Baolu
2021-06-18 7:31 ` John Garry
2021-06-16 11:03 ` [PATCH v13 5/6] iommu/amd: " John Garry
2021-06-16 11:03 ` [PATCH v13 6/6] iommu: Remove mode argument from iommu_set_dma_strict() John Garry
2021-06-17 7:36 ` Lu Baolu
2021-06-17 7:41 ` John Garry
2021-06-18 1:52 ` Lu Baolu
2021-06-17 18:56 ` Robin Murphy
2021-06-18 1:51 ` Lu Baolu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b6484679-0950-8c8e-98c5-da0e4c1d97e2@linux.intel.com \
--to=baolu.lu@linux.intel.com \
--cc=chenxiang66@hisilicon.com \
--cc=corbet@lwn.net \
--cc=dwmw2@infradead.org \
--cc=iommu@lists.linux-foundation.org \
--cc=john.garry@huawei.com \
--cc=joro@8bytes.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=robin.murphy@arm.com \
--cc=thunder.leizhen@huawei.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).