From: Tom Fitzhenry <tom@tom-fitzhenry.me.uk>
To: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Heiko Stuebner <heiko@sntech.de>,
linux-rockchip@lists.infradead.org
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Samuel Holland <samuel@sholland.org>, Ondrej Jirman <x@xff.cz>,
Martijn Braam <martijn@brixit.nl>
Subject: Re: [PATCH 2/2] arm64: dts: rockchip: Add initial support for Pine64 PinePhone Pro
Date: Sun, 29 May 2022 13:45:52 +1000 [thread overview]
Message-ID: <b6500fe9-f7df-a7d1-09cb-9f772126128d@tom-fitzhenry.me.uk> (raw)
In-Reply-To: <20220529031705.278631-3-tom@tom-fitzhenry.me.uk>
I've sent this DT for early feedback. I've commented below on the parts
I'm unsure about, and would appreciate any feedback.
On 29/5/22 13:17, Tom Fitzhenry wrote:
> + cluster1_opp_ppp: opp-table1b {
I don't know which OPP should be used.
Per
https://gitlab.com/pine64-org/linux/-/merge_requests/36/diffs?commit_id=dcf78ea8ad6f0b1c6e3279d8d752ca68d6d05756,
using the regular RK3399 OPP table exceeds operating conditions.
Perhaps this should depend on an OPP for RK3399-T (which would need to
be added, as the linked merge request proposes).
> + // Per "TYPE-C", page 23.
> + fusb0: typec-portc@22 {
> + compatible = "fcs,fusb302";
> + reg = <0x22>;
> + interrupt-parent = <&gpio1>;
> + interrupts = <RK_PA2 IRQ_TYPE_LEVEL_LOW>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&fusb0_int>;
> + vbus-supply = <&vcc5v0_typec>;
This is the node many PinePhone Pro users have been using for >1 month,
but I don't understand the USB subsystem well enough yet to understand
the node.
next prev parent reply other threads:[~2022-05-29 3:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-29 3:17 [PATCH 0/2] Add support for Pine64 PinePhonePro Linux phone Tom Fitzhenry
2022-05-29 3:17 ` [PATCH 1/2] dt-bindings: arm: rockchip: Add PinePhone Pro bindings Tom Fitzhenry
2022-05-29 14:23 ` Krzysztof Kozlowski
2022-06-15 13:28 ` Pavel Machek
2022-05-29 3:17 ` [PATCH 2/2] arm64: dts: rockchip: Add initial support for Pine64 PinePhone Pro Tom Fitzhenry
2022-05-29 3:45 ` Tom Fitzhenry [this message]
2022-05-29 11:33 ` Ondřej Jirman
2022-05-29 11:53 ` Tom Fitzhenry
2022-05-29 14:26 ` Krzysztof Kozlowski
2022-06-15 13:28 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b6500fe9-f7df-a7d1-09cb-9f772126128d@tom-fitzhenry.me.uk \
--to=tom@tom-fitzhenry.me.uk \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=martijn@brixit.nl \
--cc=robh+dt@kernel.org \
--cc=samuel@sholland.org \
--cc=x@xff.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).