From: Abhishek <huntbag@linux.vnet.ibm.com>
To: shuah <shuah@kernel.org>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: trenn@suse.com, ego@linux.vnet.ibm.com
Subject: Re: [PATCH v2] cpupower : Handle set and info subcommands correctly
Date: Mon, 14 Oct 2019 15:08:48 +0530 [thread overview]
Message-ID: <b65b1063-941b-2838-4564-f6a6c40509c6@linux.vnet.ibm.com> (raw)
In-Reply-To: <9f493ef7-8222-3e12-5068-41ea76e660a2@kernel.org>
Hi Shuah,
On 10/04/2019 03:45 AM, shuah wrote:
> Hi Abhishek,
>
> On 10/3/19 8:38 AM, shuah wrote:
>> On 9/13/19 2:07 AM, Abhishek Goel wrote:
>>> Cpupower tool has set and info options which are being used only by
>>> x86 machines. This patch removes support for these two subcommands
>>> from generic cpupower utility. Thus, these two subcommands will now be
>>> available only for intel.
>>> This removes the ambiguous error message while using set option in case
>>> of using non-intel systems.
>>>
>>> Without this patch on a non-intel box:
>>>
>>> root@ubuntu:~# cpupower info
>>> System does not support Intel's performance bias setting
>>>
>>> root@ubuntu:~# cpupower set -b 10
>>> Error setting perf-bias value on CPU
>>>
>>> With this patch on a non-intel box:
>>>
>>> root@ubuntu:~# cpupower info
>>> Supported commands are:
>>> frequency-info
>>> frequency-set
>>> idle-info
>>> idle-set
>>> monitor
>>> help
>>>
>>> Same result for set subcommand.
>>>
>>> This patch does not affect results on a intel box.
>>>
>>> Signed-off-by: Abhishek Goel <huntbag@linux.vnet.ibm.com>
>>> Acked-by: Thomas Renninger <trenn@suse.de>
>>> ---
>>>
>>> changes from v1:
>>> Instead of bailing out early in set and info commands, in V2, we
>>> are cutting out support for these two commands for non-intel
>>> systems.
>>
>> thanks. I will get this in for 5.4-rc3 veru likely. Definitely in 5.4
>>
>
> Okay I almost applied this and decided it needs improvements.
>
> I don't like using #if defined(__x86_64__) || defined(__i386__)
>
> tools/power/cpupower/utils/cpupower.c main() already does this
> dynamically using uname(). Please use the same logic do this,
> instead of adding compile time code.
>
> thanks,
> -- Shuah
Do you want the decision to be taken in cpupower-set and cpupower-info
file as was done in v1 but using uname() by identifying the architecture
there itself?
Thanks,
--Abhishek
next prev parent reply other threads:[~2019-10-14 9:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-13 8:07 [PATCH v2] cpupower : Handle set and info subcommands correctly Abhishek Goel
2019-10-03 14:38 ` shuah
2019-10-03 22:15 ` shuah
2019-10-14 9:38 ` Abhishek [this message]
2019-10-14 15:02 ` shuah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b65b1063-941b-2838-4564-f6a6c40509c6@linux.vnet.ibm.com \
--to=huntbag@linux.vnet.ibm.com \
--cc=ego@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=trenn@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).