From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756105AbdAJGKf (ORCPT ); Tue, 10 Jan 2017 01:10:35 -0500 Received: from mailout4.samsung.com ([203.254.224.34]:58968 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753354AbdAJGKb (ORCPT ); Tue, 10 Jan 2017 01:10:31 -0500 X-AuditID: b6c32a2e-f79f46d000002a13-89-58747ad42e3d Subject: Re: [PATCH V2 2/5] phy: phy-exynos-pcie: Add support for Exynos PCIe phy To: Vivek Gautam , linux-pci@vger.kernel.org Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, bhelgaas@google.com, robh+dt@kernel.org, mark.rutland@arm.com, kgene@kernel.org, krzk@kernel.org, kishon@ti.com, jingoohan1@gmail.com, pankaj.dubey@samsung.com, alim.akhtar@samsung.com, cpgs@samsung.com From: Jaehoon Chung Message-id: Date: Tue, 10 Jan 2017 15:10:27 +0900 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-version: 1.0 In-reply-to: Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrDJsWRmVeSWpSXmKPExsWy7bCmlu6VqpIIgytrJS0ezNvGZrGkKcPi 5SFNi/lHzrFarPgyk92i//FrZosLT3vYLM6f38BucXnXHDaLs/OOs1nMOL+PyWLp9YtMFou2 fmG3aN17hN3ixM8dzA78HmvmrWH0uNzXy+Sxc9Zddo8Fm0o9Nq3qZPPo27KK0eP4je1MHp83 yQVwRKXaZKQmpqQWKaTmJeenZOal2yp5B8c7x5uaGRjqGlpamCsp5CXmptoqufgE6Lpl5gCd rqRQlphTChQKSCwuVtK3synKLy1JVcjILy6xVYo2NDTSMzQw1zMyMtIzMY61MjIFKklIzXj/ aydTwcfCio65Jg2Me6O6GDk5JARMJPr27maBsMUkLtxbz9bFyMUhJLCUUaL560tGCKedSWLb lEZWmI4N+2ezQySWM0p8+tvECuHcY5Q49+sOI0iVsECwxK9ZO8Dmigh4Svy8sYgZpIhZYDOT xPe3q8ASbAI6Etu/HWcCsXkF7CQ6/s9iBrFZBFQlHr1pZwOxRQXCJDbff8kOUSMo8WPyPbBe TgEniYZN78FqmAUMJGZMOcwEYctLbF7zFmyZhMBPdomZJ74BORxAjqzEpgPMEC+4SGzav4Ed whaWeHV8C5QtLfF36S1GiN5uRol/XzayQTg9jBK3tq5mgqgylrj/4B4zxDY+id7fT5ggFvBK dLQJQZgeEnO/50CYjhKbnvNBAugno8TffV9ZJjDKz0LyziwkL8xC8sICRuZVjGKpBcW56anF pgXGesWJucWleel6yfm5mxjBKVdLbwfjvwXehxgFOBiVeHh/pJdECLEmlhVX5h5ilOBgVhLh /VYGFOJNSaysSi3Kjy8qzUktPsRoCgziicxSosn5wHyQVxJvaGJmaGJkCYTmhuZK4rwLKqwj hATSE0tSs1NTC1KLYPqYODilGhi9vt/8KiCiJaVl/b/IOJpFxf+E03ZhjQdXG2/NE1mx+Myn vM7rmZzTphr86dos6dR6l5NV+bqV88kEZpWwacoM+xjeLl+/cbptsZ/p9XXnlFpeR29mcr/S u2TW54M1D5at/FlzRU2x3bS7cb/1SuUrEcvzz5d8f5+dpvvel9Wty9JaW+DPl4dKLMUZiYZa zEXFiQDNJR36zwMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrOIsWRmVeSWpSXmKPExsVy+t9jAd0rVSURBldncls8mLeNzWJJU4bF y0OaFvOPnGO1WPFlJrtF/+PXzBYXnvawWZw/v4Hd4vKuOWwWZ+cdZ7OYcX4fk8XS6xeZLBZt /cJu0br3CLvFiZ87mB34PdbMW8Pocbmvl8lj56y77B4LNpV6bFrVyebRt2UVo8fxG9uZPD5v kgvgiHKzyUhNTEktUkjNS85PycxLt1UKDXHTtVBSyEvMTbVVitD1DQlSUihLzCkF8owM0ICD c4B7sJK+XYJbxvtfO5kKPhZWdMw1aWDcG9XFyMkhIWAisWH/bHYIW0ziwr31bF2MXBxCAksZ Jb7/X8UE4TxglFj+7B0LSJWwQLBEz/clrCC2iICnxM8bi5ghin4ySqw6dBzMYRbYzCTRuLWR DaSKTUBHYvu340wgNq+AnUTH/1nMIDaLgKrEozftQDUcHKICYRLPG50gSgQlfky+B7aMU8BJ omHTe7ASZgE9ifsXtUDCzALyEpvXvGWewCgwC0nHLISqWUiqFjAyr2KUSC1ILihOSs81ykst 1ytOzC0uzUvXS87P3cQIjuRn0jsYD+9yP8QowMGoxMMbMaE4Qog1say4MvcQowQHs5II77ey kggh3pTEyqrUovz4otKc1OJDjKZAX0xklhJNzgcmmbySeEMTcxNzYwMLc0tLEyMlcd7G2c/C hQTSE0tSs1NTC1KLYPqYODilGhhbZNpmqL/7u/z+Ztb9titZ+cq/5uZuNxOvVnU4/n4bS47W zckiV/uroutu2Ocu+HFiT5f2VC6ZA0sLu6ct4ThUmlBRM1e/V6FpSuHeNUI6t2JWtiuLZ28R PNK2SyGqpmOZyucA40PCU2qdkhhfF92tkN7c4HjymNaJ0/PV//NPEeBIuVPaLqvEUpyRaKjF XFScCADdfJdU+gIAAA== X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170110061028epcas5p116106f8ec95daf0c784a08ca2f13b65b X-Msg-Generator: CA X-Sender-IP: 203.254.230.27 X-Local-Sender: =?UTF-8?B?7KCV7J6s7ZuIG1RpemVuIFBsYXRmb3JtIExhYihTL1fshLw=?= =?UTF-8?B?7YSwKRvsgrzshLHsoITsnpAbUzUo7LGF7J6EKS/ssYXsnoQ=?= X-Global-Sender: =?UTF-8?B?SmFlaG9vbiBDaHVuZxtUaXplbiBQbGF0Zm9ybSBMYWIuG1Nh?= =?UTF-8?B?bXN1bmcgRWxlY3Ryb25pY3MbUzUvU2VuaW9yIEVuZ2luZWVy?= X-Sender-Code: =?UTF-8?B?QzEwG1NUQUYbQzEwVjgxMTE=?= CMS-TYPE: 105P DLP-Filter: Pass X-CFilter-Loop: Reflected X-HopCount: 7 X-CMS-RootMailID: 20170104123436epcas1p1a729583c3c2307d8539a186f1050ea98 X-RootMTR: 20170104123436epcas1p1a729583c3c2307d8539a186f1050ea98 References: <20170104123435.30740-1-jh80.chung@samsung.com> <20170104123435.30740-3-jh80.chung@samsung.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Vivek, On 01/10/2017 03:07 PM, Vivek Gautam wrote: > Hi Jaehoon, > > > On 01/04/2017 06:04 PM, Jaehoon Chung wrote: >> This patch supports to use Generic Phy framework for Exynos PCIe phy. >> When Exynos that supported the pcie want to use the PCIe, >> it needs to control the phy resgister. >> But it should be more complex to control in their own PCIe device drivers. >> >> Currently, there is an exynos5440 case to support the pcie. >> So this driver is based on Exynos5440 PCIe. >> In future, will support the Other exynos SoCs likes exynos5433, exynos7. >> >> Signed-off-by: Jaehoon Chung >> --- >> Changelog on V2: >> - Not include the codes relevant to pci-exynos. >> - Remove the getting child node. >> >> drivers/phy/Kconfig | 9 ++ >> drivers/phy/Makefile | 1 + >> drivers/phy/phy-exynos-pcie.c | 280 ++++++++++++++++++++++++++++++++++++++++++ >> 3 files changed, 290 insertions(+) >> create mode 100644 drivers/phy/phy-exynos-pcie.c >> >> diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig >> index e8eb7f2..2dddef4 100644 >> --- a/drivers/phy/Kconfig >> +++ b/drivers/phy/Kconfig >> @@ -331,6 +331,15 @@ config PHY_EXYNOS5_USBDRD >> This driver provides PHY interface for USB 3.0 DRD controller >> present on Exynos5 SoC series. >> +config PHY_EXYNOS_PCIE >> + bool "Exynos PCIe PHY driver" >> + depends on ARCH_EXYNOS && OF >> + depends on PCI_EXYNOS >> + select GENERIC_PHY >> + help >> + Enable PCIe PHY support for Exynos SoC series. >> + This driver provides PHY interface for Exynos PCIe controller. >> + >> config PHY_PISTACHIO_USB >> tristate "IMG Pistachio USB2.0 PHY driver" >> depends on MACH_PISTACHIO >> diff --git a/drivers/phy/Makefile b/drivers/phy/Makefile >> index 65eb2f4..081aeb4 100644 >> --- a/drivers/phy/Makefile >> +++ b/drivers/phy/Makefile >> @@ -37,6 +37,7 @@ phy-exynos-usb2-$(CONFIG_PHY_EXYNOS4X12_USB2) += phy-exynos4x12-usb2.o >> phy-exynos-usb2-$(CONFIG_PHY_EXYNOS5250_USB2) += phy-exynos5250-usb2.o >> phy-exynos-usb2-$(CONFIG_PHY_S5PV210_USB2) += phy-s5pv210-usb2.o >> obj-$(CONFIG_PHY_EXYNOS5_USBDRD) += phy-exynos5-usbdrd.o >> +obj-$(CONFIG_PHY_EXYNOS_PCIE) += phy-exynos-pcie.o >> obj-$(CONFIG_PHY_QCOM_APQ8064_SATA) += phy-qcom-apq8064-sata.o >> obj-$(CONFIG_PHY_ROCKCHIP_USB) += phy-rockchip-usb.o >> obj-$(CONFIG_PHY_ROCKCHIP_INNO_USB2) += phy-rockchip-inno-usb2.o >> diff --git a/drivers/phy/phy-exynos-pcie.c b/drivers/phy/phy-exynos-pcie.c >> new file mode 100644 >> index 0000000..b57f49b >> --- /dev/null >> +++ b/drivers/phy/phy-exynos-pcie.c >> @@ -0,0 +1,280 @@ >> +/* >> + * Samsung EXYNOS SoC series PCIe PHY driver >> + * >> + * Phy provider for PCIe controller on Exynos SoC series >> + * >> + * Copyright (C) 2016 Samsung Electronics Co., Ltd. >> + * Jaehoon Chung >> + * >> + * This program is free software; you can redistribute it and/or modify >> + * it under the terms of the GNU General Public License version 2 as >> + * published by the Free Software Foundation. >> + */ >> + >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> + >> +/* PCIe Purple registers */ >> +#define PCIE_PHY_GLOBAL_RESET 0x000 >> +#define PCIE_PHY_COMMON_RESET 0x004 >> +#define PCIE_PHY_CMN_REG 0x008 >> +#define PCIE_PHY_MAC_RESET 0x00c >> +#define PCIE_PHY_PLL_LOCKED 0x010 >> +#define PCIE_PHY_TRSVREG_RESET 0x020 >> +#define PCIE_PHY_TRSV_RESET 0x024 >> + >> +/* PCIe PHY registers */ >> +#define PCIE_PHY_IMPEDANCE 0x004 >> +#define PCIE_PHY_PLL_DIV_0 0x008 >> +#define PCIE_PHY_PLL_BIAS 0x00c >> +#define PCIE_PHY_DCC_FEEDBACK 0x014 >> +#define PCIE_PHY_PLL_DIV_1 0x05c >> +#define PCIE_PHY_COMMON_POWER 0x064 >> +#define PCIE_PHY_COMMON_PD_CMN BIT(3) >> +#define PCIE_PHY_TRSV0_EMP_LVL 0x084 >> +#define PCIE_PHY_TRSV0_DRV_LVL 0x088 >> +#define PCIE_PHY_TRSV0_RXCDR 0x0ac >> +#define PCIE_PHY_TRSV0_POWER 0x0c4 >> +#define PCIE_PHY_TRSV0_PD_TSV BIT(7) >> +#define PCIE_PHY_TRSV0_LVCC 0x0dc >> +#define PCIE_PHY_TRSV1_EMP_LVL 0x144 >> +#define PCIE_PHY_TRSV1_RXCDR 0x16c >> +#define PCIE_PHY_TRSV1_POWER 0x184 >> +#define PCIE_PHY_TRSV1_PD_TSV BIT(7) >> +#define PCIE_PHY_TRSV1_LVCC 0x19c >> +#define PCIE_PHY_TRSV2_EMP_LVL 0x204 >> +#define PCIE_PHY_TRSV2_RXCDR 0x22c >> +#define PCIE_PHY_TRSV2_POWER 0x244 >> +#define PCIE_PHY_TRSV2_PD_TSV BIT(7) >> +#define PCIE_PHY_TRSV2_LVCC 0x25c >> +#define PCIE_PHY_TRSV3_EMP_LVL 0x2c4 >> +#define PCIE_PHY_TRSV3_RXCDR 0x2ec >> +#define PCIE_PHY_TRSV3_POWER 0x304 >> +#define PCIE_PHY_TRSV3_PD_TSV BIT(7) >> +#define PCIE_PHY_TRSV3_LVCC 0x31c >> + >> +struct exynos_pcie_phy_data { >> + struct phy_ops *ops; >> +}; >> + >> +/* For Exynos pcie phy */ >> +struct exynos_pcie_phy { >> + const struct exynos_pcie_phy_data *drv_data; >> + void __iomem *phy_base; >> + void __iomem *blk_base; /* For exynos5440 */ >> +}; >> + >> +static void exynos_pcie_phy_writel(void __iomem *base, u32 val, u32 offset) >> +{ >> + writel(val, base + offset); >> +} >> + >> +static u32 exynos_pcie_phy_readl(void __iomem *base, u32 offset) >> +{ >> + return readl(base + offset); >> +} >> + >> +/* For Exynos5440 specific functions */ >> +static int exynos5440_pcie_phy_init(struct phy *phy) >> +{ >> + struct exynos_pcie_phy *ep = phy_get_drvdata(phy); >> + >> + /* DCC feedback control off */ >> + exynos_pcie_phy_writel(ep->phy_base, 0x29, PCIE_PHY_DCC_FEEDBACK); >> + >> + /* set TX/RX impedance */ >> + exynos_pcie_phy_writel(ep->phy_base, 0xd5, PCIE_PHY_IMPEDANCE); >> + >> + /* set 50Mhz PHY clock */ >> + exynos_pcie_phy_writel(ep->phy_base, 0x14, PCIE_PHY_PLL_DIV_0); >> + exynos_pcie_phy_writel(ep->phy_base, 0x12, PCIE_PHY_PLL_DIV_1); >> + >> + /* set TX Differential output for lane 0 */ >> + exynos_pcie_phy_writel(ep->phy_base, 0x7f, PCIE_PHY_TRSV0_DRV_LVL); >> + >> + /* set TX Pre-emphasis Level Control for lane 0 to minimum */ >> + exynos_pcie_phy_writel(ep->phy_base, 0x0, PCIE_PHY_TRSV0_EMP_LVL); >> + >> + /* set RX clock and data recovery bandwidth */ >> + exynos_pcie_phy_writel(ep->phy_base, 0xe7, PCIE_PHY_PLL_BIAS); >> + exynos_pcie_phy_writel(ep->phy_base, 0x82, PCIE_PHY_TRSV0_RXCDR); >> + exynos_pcie_phy_writel(ep->phy_base, 0x82, PCIE_PHY_TRSV1_RXCDR); >> + exynos_pcie_phy_writel(ep->phy_base, 0x82, PCIE_PHY_TRSV2_RXCDR); >> + exynos_pcie_phy_writel(ep->phy_base, 0x82, PCIE_PHY_TRSV3_RXCDR); >> + >> + /* change TX Pre-emphasis Level Control for lanes */ >> + exynos_pcie_phy_writel(ep->phy_base, 0x39, PCIE_PHY_TRSV0_EMP_LVL); >> + exynos_pcie_phy_writel(ep->phy_base, 0x39, PCIE_PHY_TRSV1_EMP_LVL); >> + exynos_pcie_phy_writel(ep->phy_base, 0x39, PCIE_PHY_TRSV2_EMP_LVL); >> + exynos_pcie_phy_writel(ep->phy_base, 0x39, PCIE_PHY_TRSV3_EMP_LVL); >> + >> + /* set LVCC */ >> + exynos_pcie_phy_writel(ep->phy_base, 0x20, PCIE_PHY_TRSV0_LVCC); >> + exynos_pcie_phy_writel(ep->phy_base, 0xa0, PCIE_PHY_TRSV1_LVCC); >> + exynos_pcie_phy_writel(ep->phy_base, 0xa0, PCIE_PHY_TRSV2_LVCC); >> + exynos_pcie_phy_writel(ep->phy_base, 0xa0, PCIE_PHY_TRSV3_LVCC); >> + >> + /* pulse for common reset */ >> + exynos_pcie_phy_writel(ep->blk_base, 1, PCIE_PHY_COMMON_RESET); >> + udelay(500); >> + exynos_pcie_phy_writel(ep->blk_base, 0, PCIE_PHY_COMMON_RESET); >> + >> + return 0; >> +} >> + >> +static int exynos5440_pcie_phy_power_on(struct phy *phy) >> +{ >> + struct exynos_pcie_phy *ep = phy_get_drvdata(phy); >> + u32 val; >> + >> + exynos_pcie_phy_writel(ep->blk_base, 0, PCIE_PHY_COMMON_RESET); >> + exynos_pcie_phy_writel(ep->blk_base, 0, PCIE_PHY_CMN_REG); >> + exynos_pcie_phy_writel(ep->blk_base, 0, PCIE_PHY_TRSVREG_RESET); >> + exynos_pcie_phy_writel(ep->blk_base, 0, PCIE_PHY_TRSV_RESET); >> + >> + val = exynos_pcie_phy_readl(ep->phy_base, PCIE_PHY_COMMON_POWER); >> + val &= ~PCIE_PHY_COMMON_PD_CMN; >> + exynos_pcie_phy_writel(ep->phy_base, val, PCIE_PHY_COMMON_POWER); >> + >> + val = exynos_pcie_phy_readl(ep->phy_base, PCIE_PHY_TRSV0_POWER); >> + val &= ~PCIE_PHY_TRSV0_PD_TSV; >> + exynos_pcie_phy_writel(ep->phy_base, val, PCIE_PHY_TRSV0_POWER); >> + >> + val = exynos_pcie_phy_readl(ep->phy_base, PCIE_PHY_TRSV1_POWER); >> + val &= ~PCIE_PHY_TRSV1_PD_TSV; >> + exynos_pcie_phy_writel(ep->phy_base, val, PCIE_PHY_TRSV1_POWER); >> + >> + val = exynos_pcie_phy_readl(ep->phy_base, PCIE_PHY_TRSV2_POWER); >> + val &= ~PCIE_PHY_TRSV2_PD_TSV; >> + exynos_pcie_phy_writel(ep->phy_base, val, PCIE_PHY_TRSV2_POWER); >> + >> + val = exynos_pcie_phy_readl(ep->phy_base, PCIE_PHY_TRSV3_POWER); >> + val &= ~PCIE_PHY_TRSV3_PD_TSV; >> + exynos_pcie_phy_writel(ep->phy_base, val, PCIE_PHY_TRSV3_POWER); >> + >> + return 0; >> +} >> + >> +static int exynos5440_pcie_phy_power_off(struct phy *phy) >> +{ >> + struct exynos_pcie_phy *ep = phy_get_drvdata(phy); >> + u32 val; >> + >> + while (exynos_pcie_phy_readl(ep->phy_base, >> + PCIE_PHY_PLL_LOCKED) == 0) { > > No timeout for this ? Is it possible that the PLL was never locked > and this ends up in infinite loop. > > Please use a readl_poll_timeout() instead. Ok, will fix. > >> + val = exynos_pcie_phy_readl(ep->blk_base, >> + PCIE_PHY_PLL_LOCKED); > it is possible that the while condition check above is true (the register reads to 0), > but this assignment makes ' val = 1' ? > If that the case then debug message below can be misleading. > >> + dev_info(&phy->dev, "PLL Locked: 0x%x\n", val); > > Possibly, you don't want to fill up the console with these logs until the PLL is locked. dev_dbg() ? Ok, will fix. > >> + } >> + >> + val = exynos_pcie_phy_readl(ep->phy_base, PCIE_PHY_COMMON_POWER); >> + val |= PCIE_PHY_COMMON_PD_CMN; >> + exynos_pcie_phy_writel(ep->phy_base, val, PCIE_PHY_COMMON_POWER); >> + >> + val = exynos_pcie_phy_readl(ep->phy_base, PCIE_PHY_TRSV0_POWER); >> + val |= PCIE_PHY_TRSV0_PD_TSV; >> + exynos_pcie_phy_writel(ep->phy_base, val, PCIE_PHY_TRSV0_POWER); >> + >> + val = exynos_pcie_phy_readl(ep->phy_base, PCIE_PHY_TRSV1_POWER); >> + val |= PCIE_PHY_TRSV1_PD_TSV; >> + exynos_pcie_phy_writel(ep->phy_base, val, PCIE_PHY_TRSV1_POWER); >> + >> + val = exynos_pcie_phy_readl(ep->phy_base, PCIE_PHY_TRSV2_POWER); >> + val |= PCIE_PHY_TRSV2_PD_TSV; >> + exynos_pcie_phy_writel(ep->phy_base, val, PCIE_PHY_TRSV2_POWER); >> + >> + val = exynos_pcie_phy_readl(ep->phy_base, PCIE_PHY_TRSV3_POWER); >> + val |= PCIE_PHY_TRSV3_PD_TSV; >> + exynos_pcie_phy_writel(ep->phy_base, val, PCIE_PHY_TRSV3_POWER); >> + >> + return 0; >> +} >> + >> +static int exynos5440_pcie_phy_reset(struct phy *phy) >> +{ >> + struct exynos_pcie_phy *ep = phy_get_drvdata(phy); >> + >> + exynos_pcie_phy_writel(ep->blk_base, 0, PCIE_PHY_MAC_RESET); >> + exynos_pcie_phy_writel(ep->blk_base, 1, PCIE_PHY_GLOBAL_RESET); >> + exynos_pcie_phy_writel(ep->blk_base, 0, PCIE_PHY_GLOBAL_RESET); >> + >> + return 0; >> +} >> + >> +static struct phy_ops exynos5440_phy_ops = { > > const ? Right. > >> + .init = exynos5440_pcie_phy_init, >> + .power_on = exynos5440_pcie_phy_power_on, >> + .power_off = exynos5440_pcie_phy_power_off, >> + .reset = exynos5440_pcie_phy_reset, >> +}; >> + >> +static const struct exynos_pcie_phy_data exynos5440_pcie_phy_data = { >> + .ops = &exynos5440_phy_ops, >> +}; >> + >> +static const struct of_device_id exynos_pcie_phy_match[] = { >> + { >> + .compatible = "samsung,exynos5440-pcie-phy", >> + .data = &exynos5440_pcie_phy_data, >> + }, >> + {}, >> +}; >> +MODULE_DEVICE_TABLE(of, exynos_pcie_phy_match); >> + >> +static int exynos_pcie_phy_probe(struct platform_device *pdev) >> +{ >> + struct device *dev = &pdev->dev; >> + struct exynos_pcie_phy *exynos_phy; >> + struct phy *generic_phy; >> + struct phy_provider *phy_provider; >> + struct resource *res; >> + const struct exynos_pcie_phy_data *drv_data; >> + >> + drv_data = of_device_get_match_data(dev); >> + if (!drv_data) >> + return -ENODEV; >> + >> + exynos_phy = devm_kzalloc(dev, sizeof(*exynos_phy), GFP_KERNEL); >> + if (!exynos_phy) >> + return -ENOMEM; >> + >> + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); >> + exynos_phy->phy_base = devm_ioremap_resource(dev, res); >> + if (IS_ERR(exynos_phy->phy_base)) >> + return PTR_ERR(exynos_phy->phy_base); >> + >> + res = platform_get_resource(pdev, IORESOURCE_MEM, 1); >> + exynos_phy->blk_base = devm_ioremap_resource(dev, res); >> + if (IS_ERR(exynos_phy->phy_base)) >> + return PTR_ERR(exynos_phy->phy_base); >> + >> + exynos_phy->drv_data = drv_data; >> + >> + generic_phy = devm_phy_create(dev, dev->of_node, drv_data->ops); >> + if (IS_ERR(generic_phy)) { >> + dev_err(dev, "failed to create PHY\n"); >> + return PTR_ERR(generic_phy); >> + } >> + >> + phy_set_drvdata(generic_phy, exynos_phy); >> + phy_provider = devm_of_phy_provider_register(dev, of_phy_simple_xlate); >> + >> + return PTR_ERR_OR_ZERO(phy_provider); >> +} >> + >> +static struct platform_driver exynos_pcie_phy_driver = { >> + .probe = exynos_pcie_phy_probe, >> + .driver = { >> + .of_match_table = exynos_pcie_phy_match, >> + .name = "exynos_pcie_phy", >> + } >> +}; >> +module_platform_driver(exynos_pcie_phy_driver); > > MODULE_LICENSE("GPL") ?? > MODULE_DESCRIPTION() as well. Will do. I will send the Patch V3 within this week. Best Regards, Jaehoon Chung > > > Regards > Vivek >