From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9747C47258 for ; Tue, 5 May 2020 04:15:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CE78620752 for ; Tue, 5 May 2020 04:15:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726531AbgEEEPk (ORCPT ); Tue, 5 May 2020 00:15:40 -0400 Received: from out4436.biz.mail.alibaba.com ([47.88.44.36]:16300 "EHLO out4436.biz.mail.alibaba.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725272AbgEEEPj (ORCPT ); Tue, 5 May 2020 00:15:39 -0400 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R491e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01f04397;MF=tianjia.zhang@linux.alibaba.com;NM=1;PH=DS;RN=37;SR=0;TI=SMTPD_---0TxXItq5_1588652118; Received: from 30.27.236.135(mailfrom:tianjia.zhang@linux.alibaba.com fp:SMTPD_---0TxXItq5_1588652118) by smtp.aliyun-inc.com(127.0.0.1); Tue, 05 May 2020 12:15:22 +0800 Subject: Re: [PATCH v4 0/7] clean up redundant 'kvm_run' parameters To: pbonzini@redhat.com, tsbogend@alpha.franken.de, paulus@ozlabs.org, mpe@ellerman.id.au, benh@kernel.crashing.org, borntraeger@de.ibm.com, frankja@linux.ibm.com, david@redhat.com, cohuck@redhat.com, heiko.carstens@de.ibm.com, gor@linux.ibm.com, sean.j.christopherson@intel.com, vkuznets@redhat.com, wanpengli@tencent.com, jmattson@google.com, joro@8bytes.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, x86@kernel.org, hpa@zytor.com, maz@kernel.org, james.morse@arm.com, julien.thierry.kdev@gmail.com, suzuki.poulose@arm.com, christoffer.dall@arm.com, peterx@redhat.com, thuth@redhat.com, chenhuacai@gmail.com Cc: kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-mips@vger.kernel.org, kvm-ppc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org References: <20200427043514.16144-1-tianjia.zhang@linux.alibaba.com> From: Tianjia Zhang Message-ID: Date: Tue, 5 May 2020 12:15:17 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200427043514.16144-1-tianjia.zhang@linux.alibaba.com> Content-Type: text/plain; charset=gbk; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Paolo Bonzini, any opinion on this? Thanks and best, Tianjia On 2020/4/27 12:35, Tianjia Zhang wrote: > In the current kvm version, 'kvm_run' has been included in the 'kvm_vcpu' > structure. For historical reasons, many kvm-related function parameters > retain the 'kvm_run' and 'kvm_vcpu' parameters at the same time. This > patch does a unified cleanup of these remaining redundant parameters. > > This series of patches has completely cleaned the architecture of > arm64, mips, ppc, and s390 (no such redundant code on x86). Due to > the large number of modified codes, a separate patch is made for each > platform. On the ppc platform, there is also a redundant structure > pointer of 'kvm_run' in 'vcpu_arch', which has also been cleaned > separately. > > --- > v4 change: > mips: fixes two errors in entry.c. > > v3 change: > Keep the existing `vcpu->run` in the function body unchanged. > > v2 change: > s390 retains the original variable name and minimizes modification. > > Tianjia Zhang (7): > KVM: s390: clean up redundant 'kvm_run' parameters > KVM: arm64: clean up redundant 'kvm_run' parameters > KVM: PPC: Remove redundant kvm_run from vcpu_arch > KVM: PPC: clean up redundant 'kvm_run' parameters > KVM: PPC: clean up redundant kvm_run parameters in assembly > KVM: MIPS: clean up redundant 'kvm_run' parameters > KVM: MIPS: clean up redundant kvm_run parameters in assembly > > arch/arm64/include/asm/kvm_coproc.h | 12 +-- > arch/arm64/include/asm/kvm_host.h | 11 +-- > arch/arm64/include/asm/kvm_mmu.h | 2 +- > arch/arm64/kvm/handle_exit.c | 36 +++---- > arch/arm64/kvm/sys_regs.c | 13 ++- > arch/mips/include/asm/kvm_host.h | 32 +------ > arch/mips/kvm/emulate.c | 59 ++++-------- > arch/mips/kvm/entry.c | 21 ++--- > arch/mips/kvm/mips.c | 14 +-- > arch/mips/kvm/trap_emul.c | 114 ++++++++++------------- > arch/mips/kvm/vz.c | 26 ++---- > arch/powerpc/include/asm/kvm_book3s.h | 16 ++-- > arch/powerpc/include/asm/kvm_host.h | 1 - > arch/powerpc/include/asm/kvm_ppc.h | 27 +++--- > arch/powerpc/kvm/book3s.c | 4 +- > arch/powerpc/kvm/book3s.h | 2 +- > arch/powerpc/kvm/book3s_64_mmu_hv.c | 12 +-- > arch/powerpc/kvm/book3s_64_mmu_radix.c | 4 +- > arch/powerpc/kvm/book3s_emulate.c | 10 +- > arch/powerpc/kvm/book3s_hv.c | 64 ++++++------- > arch/powerpc/kvm/book3s_hv_nested.c | 12 +-- > arch/powerpc/kvm/book3s_interrupts.S | 17 ++-- > arch/powerpc/kvm/book3s_paired_singles.c | 72 +++++++------- > arch/powerpc/kvm/book3s_pr.c | 33 ++++--- > arch/powerpc/kvm/booke.c | 39 ++++---- > arch/powerpc/kvm/booke.h | 8 +- > arch/powerpc/kvm/booke_emulate.c | 2 +- > arch/powerpc/kvm/booke_interrupts.S | 9 +- > arch/powerpc/kvm/bookehv_interrupts.S | 10 +- > arch/powerpc/kvm/e500_emulate.c | 15 ++- > arch/powerpc/kvm/emulate.c | 10 +- > arch/powerpc/kvm/emulate_loadstore.c | 32 +++---- > arch/powerpc/kvm/powerpc.c | 72 +++++++------- > arch/powerpc/kvm/trace_hv.h | 6 +- > arch/s390/kvm/kvm-s390.c | 23 +++-- > virt/kvm/arm/arm.c | 6 +- > virt/kvm/arm/mmio.c | 11 ++- > virt/kvm/arm/mmu.c | 5 +- > 38 files changed, 392 insertions(+), 470 deletions(-) >