From: Suzuki K Poulose <suzuki.poulose@arm.com>
To: leo.yan@linaro.org, mathieu.poirier@linaro.org,
robh+dt@kernel.org, mark.rutland@arm.com,
alexander.shishkin@linux.intel.com, shiwanglai@hisilicon.com,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/4] dt-bindings: arm: coresight: Add new compatible for static replicator
Date: Mon, 8 Apr 2019 11:44:56 +0100 [thread overview]
Message-ID: <b661edd2-5b99-f8f7-b5a5-8e4497043087@arm.com> (raw)
In-Reply-To: <20190406112145.15184-2-leo.yan@linaro.org>
On 04/06/2019 12:21 PM, Leo Yan wrote:
> CoreSight uses below bindings for replicator:
>
> Static replicator, aka. non-configurable replicator:
> "arm,coresight-replicator";
>
> Dynamic replicator, aka. configurable replicator:
> "arm,coresight-dynamic-replicator", "arm,primecell";
>
> The compatible string "arm,coresight-replicator" is not an explicit
> naming to express the replicator is 'static'. To unify the naming
> convention, this patch introduces a new compatible string
> "arm,coresight-static-replicator" for the static replicator; the
> compatible string "arm,coresight-replicator" is still kept thus we
> can support the old DT binding, but tag it as obsolete and suggest
> to use the new compatible string.
>
> As result CoreSight replicator have below bindings:
>
> Static replicator:
> "arm,coresight-replicator"; (obsolete)
> "arm,coresight-static-replicator";
>
> Dynamic replicator:
> "arm,coresight-dynamic-replicator", "arm,primecell";
>
> Signed-off-by: Leo Yan <leo.yan@linaro.org>
> ---
> Documentation/devicetree/bindings/arm/coresight.txt | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/arm/coresight.txt b/Documentation/devicetree/bindings/arm/coresight.txt
> index f8aff65ab921..f8f794869af2 100644
> --- a/Documentation/devicetree/bindings/arm/coresight.txt
> +++ b/Documentation/devicetree/bindings/arm/coresight.txt
> @@ -69,7 +69,11 @@ its hardware characteristcs.
>
> * compatible: Currently supported value is (note the absence of the
> AMBA markee):
> - - "arm,coresight-replicator"
> + - Coresight Non-configurable Replicator, the compatible string
> + "arm,coresight-replicator" is obsolete, keep it to support
To make it more obvious : s/obsolete/OBSOLETE/
> + the old DT bindings:
> + "arm,coresight-replicator";
> + "arm,coresight-static-replicator";
nit: I would re-order the compatible strings to show the precedence of
choice.
e.g,
- CoreSight non-configurable Replicator
"arm,coresight-static-replicator";
"arm,coresight-replicator"; (OBSOLETE. For
backward compatibility. Will be removed )
Also, please could we put a warning in the driver when we encounter it
and request to update it ?
Cheers
Suzuki
next prev parent reply other threads:[~2019-04-08 10:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-06 11:21 [PATCH v4 0/4] CoreSight: Support static funnel with DT binding consolidation Leo Yan
2019-04-06 11:21 ` [PATCH v4 1/4] dt-bindings: arm: coresight: Add new compatible for static replicator Leo Yan
2019-04-08 10:44 ` Suzuki K Poulose [this message]
2019-04-08 14:01 ` Leo Yan
2019-04-06 11:21 ` [PATCH v4 2/4] coresight: replicator: Add new device id " Leo Yan
2019-04-08 10:46 ` Suzuki K Poulose
2019-04-06 11:21 ` [PATCH v4 3/4] dt-bindings: arm: coresight: Unify funnel DT binding Leo Yan
2019-04-06 11:29 ` Leo Yan
2019-04-08 10:51 ` Suzuki K Poulose
2019-04-08 14:07 ` Leo Yan
2019-04-06 11:21 ` [PATCH v4 4/4] coresight: funnel: Support static funnel Leo Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b661edd2-5b99-f8f7-b5a5-8e4497043087@arm.com \
--to=suzuki.poulose@arm.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=devicetree@vger.kernel.org \
--cc=leo.yan@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mathieu.poirier@linaro.org \
--cc=robh+dt@kernel.org \
--cc=shiwanglai@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).