From: Bart Van Assche <bvanassche@acm.org>
To: Leon Romanovsky <leon@kernel.org>, Yang Li <yang.lee@linux.alibaba.com>
Cc: dledford@redhat.com, jgg@ziepe.ca, nathan@kernel.org,
ndesaulniers@google.com, linux-rdma@vger.kernel.org,
target-devel@vger.kernel.org, linux-kernel@vger.kernel.org,
clang-built-linux@googlegroups.com
Subject: Re: [PATCH] ib_srpt: Remove redundant assignment to ret
Date: Thu, 6 May 2021 08:13:05 -0700 [thread overview]
Message-ID: <b67909dc-c5d6-a8ce-5bea-36b1c7a2b04b@acm.org> (raw)
In-Reply-To: <YJPUQkQCS86mS9gw@unreal>
On 5/6/21 4:34 AM, Leon Romanovsky wrote:
> On Thu, May 06, 2021 at 06:15:05PM +0800, Yang Li wrote:
>> Variable 'ret' is set to -ENOMEM but this value is never read as it is
>> overwritten with a new value later on, hence it is a redundant
>> assignment and can be removed
>>
>> In 'commit b79fafac70fc ("target: make queue_tm_rsp() return void")'
>> srpt_queue_response() has been changed to return void, so after "goto
>> out", there is no need to return ret.
>>
>> Clean up the following clang-analyzer warning:
>>
>> drivers/infiniband/ulp/srpt/ib_srpt.c:2860:3: warning: Value stored to
>> 'ret' is never read [clang-analyzer-deadcode.DeadStores]
>>
>> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
>> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
>> ---
>> drivers/infiniband/ulp/srpt/ib_srpt.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>
> Fixes: b99f8e4d7bcd ("IB/srpt: convert to the generic RDMA READ/WRITE API")
>
> Thanks,
> Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
Reverting commit b99f8e4d7bcd and handling queue_*_rsp() errors in the
LIO core probably would be a better approach. Anyway:
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
next prev parent reply other threads:[~2021-05-06 15:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-06 10:15 [PATCH] ib_srpt: Remove redundant assignment to ret Yang Li
2021-05-06 11:34 ` Leon Romanovsky
2021-05-06 15:13 ` Bart Van Assche [this message]
2021-05-11 19:37 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b67909dc-c5d6-a8ce-5bea-36b1c7a2b04b@acm.org \
--to=bvanassche@acm.org \
--cc=clang-built-linux@googlegroups.com \
--cc=dledford@redhat.com \
--cc=jgg@ziepe.ca \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=target-devel@vger.kernel.org \
--cc=yang.lee@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).