From: Andrzej Hajda <a.hajda@samsung.com>
To: Peter Rosin <peda@axentia.se>, linux-kernel@vger.kernel.org
Cc: Kukjin Kim <kgene@kernel.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
Wolfram Sang <wsa@the-dreams.de>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH 2/2] i2c: exynos5: remove pointless initializers
Date: Thu, 10 May 2018 10:44:05 +0200 [thread overview]
Message-ID: <b69f6656-3831-86ea-5f13-fc805d86b288@samsung.com> (raw)
In-Reply-To: <20180509194532.28929-2-peda@axentia.se>
On 09.05.2018 21:45, Peter Rosin wrote:
> The variables are always assigned before use anyway.
>
> Signed-off-by: Peter Rosin <peda@axentia.se>
> ---
> drivers/i2c/busses/i2c-exynos5.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-exynos5.c b/drivers/i2c/busses/i2c-exynos5.c
> index a2cbc779c33a..185fba37e830 100644
> --- a/drivers/i2c/busses/i2c-exynos5.c
> +++ b/drivers/i2c/busses/i2c-exynos5.c
> @@ -707,7 +707,7 @@ static int exynos5_i2c_xfer(struct i2c_adapter *adap,
> struct i2c_msg *msgs, int num)
> {
> struct exynos5_i2c *i2c = adap->algo_data;
> - int i = 0, ret = 0, stop = 0;
> + int i, ret, stop;
I hope gcc is smart enough to not complain in case of ret.
I think you can merge both patches into one.
Regards
Andrzej
>
> if (i2c->suspended) {
> dev_err(i2c->dev, "HS-I2C is not initialized.\n");
next prev parent reply other threads:[~2018-05-10 8:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20180509194548epcas2p25579e969e21707afe2435b1f568ff005@epcas2p2.samsung.com>
2018-05-09 19:45 ` [PATCH 1/2] i2c: exynos5: remove some dead code Peter Rosin
2018-05-09 19:45 ` [PATCH 2/2] i2c: exynos5: remove pointless initializers Peter Rosin
2018-05-10 8:44 ` Andrzej Hajda [this message]
2018-05-10 19:16 ` Peter Rosin
2018-05-10 8:36 ` [PATCH 1/2] i2c: exynos5: remove some dead code Andrzej Hajda
2018-05-10 19:16 ` Peter Rosin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b69f6656-3831-86ea-5f13-fc805d86b288@samsung.com \
--to=a.hajda@samsung.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=peda@axentia.se \
--cc=wsa@the-dreams.de \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).