From: Arnaud POULIQUEN <arnaud.pouliquen@st.com>
To: Randy Dunlap <rdunlap@infradead.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Ohad Ben-Cohen <ohad@wizery.com>,
Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: <linux-remoteproc@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<linux-stm32@st-md-mailman.stormreply.com>
Subject: Re: [PATCH] remoteproc: fix kernel-doc warnings
Date: Wed, 12 Feb 2020 17:01:28 +0100 [thread overview]
Message-ID: <b6a7e733-f63f-431c-3b0e-9aeb3de43bb3@st.com> (raw)
In-Reply-To: <c912fe7e-601d-6d07-c368-109fecd11a7a@infradead.org>
Hi Randy
On 2/12/20 4:54 PM, Randy Dunlap wrote:
> Hi,
>
> kernel-doc supports "..." as a function argument for varargs.
> See Documentation/doc-guide/kernel-doc.rst:
>
> "If a function has a variable number of arguments, its description should
> be written in kernel-doc notation as::
>
> * @...: description"
I missed it, thanks for pointing it out!
Regards
Arnaud
>
>
> So the below could be done as:
>
> On 2/12/20 1:32 AM, Arnaud Pouliquen wrote:
>> diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c
>> index 097f33e4f1f3..5f9a5812505c 100644
>> --- a/drivers/remoteproc/remoteproc_core.c
>> +++ b/drivers/remoteproc/remoteproc_core.c
>> @@ -224,7 +224,7 @@ EXPORT_SYMBOL(rproc_da_to_va);
>> /**
>> * rproc_find_carveout_by_name() - lookup the carveout region by a name
>> * @rproc: handle of a remote processor
>> - * @name,..: carveout name to find (standard printf format)
>> + * @name: carveout name to find (standard printf format)
>
> * @name: carveout name to find
> * @...: standard printf format of args to search for carveout name
>
> although I'm not so sure about the descriptions there.
>
>> *
>> * Platform driver has the capability to register some pre-allacoted carveout
>> * (physically contiguous memory regions) before rproc firmware loading and
>
>
> thanks for the kernel-doc update.
>
prev parent reply other threads:[~2020-02-12 16:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-12 9:32 [PATCH] remoteproc: fix kernel-doc warnings Arnaud Pouliquen
2020-02-12 15:54 ` Randy Dunlap
2020-02-12 16:01 ` Arnaud POULIQUEN [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b6a7e733-f63f-431c-3b0e-9aeb3de43bb3@st.com \
--to=arnaud.pouliquen@st.com \
--cc=bjorn.andersson@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mathieu.poirier@linaro.org \
--cc=ohad@wizery.com \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).