From: "yukuai (C)" <yukuai3@huawei.com>
To: Vinod Koul <vkoul@kernel.org>
Cc: <mcoquelin.stm32@gmail.com>, <alexandre.torgue@foss.st.com>,
<michal.simek@xilinx.com>, <dmaengine@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<linux-stm32@st-md-mailman.stormreply.com>,
<linux-arm-kernel@lists.infradead.org>, <yi.zhang@huawei.com>
Subject: Re: [PATCH 2/3] dmaengine: usb-dmac: Fix PM reference leak in usb_dmac_probe()
Date: Mon, 31 May 2021 14:11:22 +0800 [thread overview]
Message-ID: <b6c340de-b0b5-6aad-94c0-03f062575b63@huawei.com> (raw)
In-Reply-To: <YLRfZfnuxc0+n/LN@vkoul-mobl.Dlink>
On 2021/05/31 12:00, Vinod Koul wrote:
> On 17-05-21, 16:18, Yu Kuai wrote:
>> pm_runtime_get_sync will increment pm usage counter even it failed.
>> Forgetting to putting operation will result in reference leak here.
>> Fix it by replacing it with pm_runtime_resume_and_get to keep usage
>> counter balanced.
>>
>> Reported-by: Hulk Robot <hulkci@huawei.com>
>> Signed-off-by: Yu Kuai <yukuai3@huawei.com>
>> ---
>> drivers/dma/sh/usb-dmac.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/dma/sh/usb-dmac.c b/drivers/dma/sh/usb-dmac.c
>> index 8f7ceb698226..2a6c8fd8854e 100644
>> --- a/drivers/dma/sh/usb-dmac.c
>> +++ b/drivers/dma/sh/usb-dmac.c
>> @@ -796,7 +796,7 @@ static int usb_dmac_probe(struct platform_device *pdev)
>>
>> /* Enable runtime PM and initialize the device. */
>> pm_runtime_enable(&pdev->dev);
>> - ret = pm_runtime_get_sync(&pdev->dev);
>> + ret = pm_runtime_resume_and_get(&pdev->dev);
>
> This does not seem to fix anything.. the below goto goes and disables
> the runtime_pm for this device and thus there wont be any leak
Hi,
If pm_runtime_get_sync() fails and increments the pm.usage_count
variable, pm_runtime_disable() does not reset the counter, and
we still need to decrement the usage count when pm_runtime_get_sync()
fails. Do I miss anthing?
Thansk!
Yu Kuai
>
>> if (ret < 0) {
>> dev_err(&pdev->dev, "runtime PM get sync failed (%d)\n", ret);
>> goto error_pm;
>> --
>> 2.25.4
>
next prev parent reply other threads:[~2021-05-31 6:11 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-17 8:18 [PATCH 0/3] cleanup patches for PM reference leak Yu Kuai
2021-05-17 8:18 ` [PATCH 1/3] dmaengine: stm32-mdma: fix PM reference leak in stm32_mdma_alloc_chan_resourc() Yu Kuai
2021-05-31 4:03 ` Vinod Koul
2021-05-17 8:18 ` [PATCH 2/3] dmaengine: usb-dmac: Fix PM reference leak in usb_dmac_probe() Yu Kuai
2021-05-31 4:00 ` Vinod Koul
2021-05-31 6:11 ` yukuai (C) [this message]
2021-05-31 8:57 ` Vinod Koul
2021-05-31 9:19 ` Johan Hovold
2021-06-03 11:09 ` Vinod Koul
2021-06-07 8:06 ` Johan Hovold
2021-06-07 10:19 ` Vinod Koul
2021-07-05 8:41 ` yukuai (C)
2021-07-06 10:49 ` Vinod Koul
2021-05-17 8:18 ` [PATCH 3/3] dmaengine: zynqmp_dma: Fix PM reference leak in zynqmp_dma_alloc_chan_resourc() Yu Kuai
2021-05-31 4:03 ` Vinod Koul
2021-05-29 9:13 ` [PATCH 0/3] cleanup patches for PM reference leak yukuai (C)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b6c340de-b0b5-6aad-94c0-03f062575b63@huawei.com \
--to=yukuai3@huawei.com \
--cc=alexandre.torgue@foss.st.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=michal.simek@xilinx.com \
--cc=vkoul@kernel.org \
--cc=yi.zhang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).