From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030617AbdDSSIW (ORCPT ); Wed, 19 Apr 2017 14:08:22 -0400 Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:51426 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030599AbdDSSIT (ORCPT ); Wed, 19 Apr 2017 14:08:19 -0400 Authentication-Results: vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=none action=none header.from=fb.com; Subject: Re: [PATCH] lightnvm: assume 64-bit lba numbers To: =?UTF-8?Q?Matias_Bj=c3=b8rling?= , Arnd Bergmann , Matias Bjorling References: <20170419173931.3902058-1-arnd@arndb.de> <0c7f0894-4817-09c4-93b9-8158bbc6a562@cnexlabs.com> CC: =?UTF-8?Q?Javier_Gonz=c3=a1lez?= , , From: Jens Axboe Message-ID: Date: Wed, 19 Apr 2017 12:08:03 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <0c7f0894-4817-09c4-93b9-8158bbc6a562@cnexlabs.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit X-Originating-IP: [216.160.245.98] X-ClientProxiedBy: MWHPR22CA0017.namprd22.prod.outlook.com (10.172.163.155) To DM5PR15MB1194.namprd15.prod.outlook.com (10.173.209.12) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 985dffd8-5607-4a4a-94e4-08d4874f0833 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(201703131423075)(201703031133081);SRVR:DM5PR15MB1194; X-Microsoft-Exchange-Diagnostics: 1;DM5PR15MB1194;3:67nt8WYKsq3pOfASa6m2FQ1yn87D1k9wLw/vbl6I2AsF87EGanxuqVYk79be1GO7oPLBD22eT6tGlHGnxHTZ/uIA7TnhMeA/f9IYmq/+oqFVYiGeF8zfCT83SsQGsDzK+uJRlDi7qDfAtskkaNgxt5ib+UYzxFX4sdPtB2QDlnnjekw+a2MN+YwuUdnTgwB7SpxdlX60wv5tt3gDUMz5IB3ljmr4/xgJzIxy2cfonYgZHAGt6mkgQ7B2KLD0AnnvTaNb/aswj1udkSkp1tkMhkhxC7NTfQTmcTNeMemqBNhcKqxEJ/FM1XGF+M4O0hosnFxVx508GM5uWeUpJrYT/Q==;25:UFSsF5jHrFRUQoNtRlKlfxAh4EyrvwaDTeQX6KlSCqkrrpsTBfRxEGPT5YfVDSax1gVTice5YRuau5vzEf5WPySKazR2qxliSCFWa0hfeBnqMNV0v1Y8z0alvOTzH4nXbQaJvO0HrD6SlvnX2rRRBmJQ5Npi3fm5nYzNTaELtRUyFHNNBgkoaBu/k+gJshkdio5x4+8mDZ/4QIs6884vydRA0Cibxe6o5dbI9kWP1vDtDlvo1GSYZTKWzK1RVskdnfDbqHItSbSPz/oYGAlNQK909JvvuaqNwjT59tUUVLnT1fzI4bHGUH9o/9E6t+N2VXM7/ockzja+ToSXig4vGc/2ilxFCWikAgXhKT4tp6cEFKAOkvHuzLzXVpilnRrMyosZelZoD2zoJyQbaAJMZEtdyLGT3oyEyQIb8yNvhDEcZQPAfqMCHJGHGKs1p4LAoQ/dJpZUPXa+0Hj/pUP+1Q== X-Microsoft-Exchange-Diagnostics: 1;DM5PR15MB1194;31:GjE9Htv6JsXJN9NX+u6L/UZOBJ7g7FN1IAVT7XtBfdeqZx21KGY5CvEs2SSyjqIF28jZK8MJqM/gEhFNufZ7ER8C3a9UhEBCY4LtAEdQ05z87pFmSH+ljSzOF7f+kkRFTFz12Cgz72afcRpSvScuG6nJdZ5hcRwSVnohmLH+0+AnIxMuEUvdj9P8HFESjz0cRniEO+GeNvg8Pn/rExr3ZhC5ElgjgNw1akpoyS+wrsfeNNQGZs87uwI0/Xe4a/Cm89Xd2l85HzGWRp2uRcbUzw==;20:zbD5KLs3PZIjMx/3po11a7ue1xQ85HoOLcPZB0WLLvEA8Re70T9T0XksFOiU1mjDM1Bps6ffM6gz8c7cnaM+beejQW2WD+2Sa58WCILgcrtBojcnhGWSkKPN0lThhFMpj0230SuCPgU52zzSVVzd7IpTr7/jo74ZamQHLCblwS9h0jMlhlhfuK7XvEkkwT55NOfkuXl+GWjg4aUWlU3GYq/MZomsDi4ax+Le72Gsk9wbgq1puJOzvYXQNWaMyl0aBxqfZGTnpAcnbYTotmIuPPjPsdDVSyth39v8/Ad+QcNEAHWRYWesBIaOIuLvOZRZ3QplbK/1s+2YiTa/Op5JZh8gOPDs8Wg642l787ykKdYe/KTG4OajQ9MSsnOChmAhTL5goI75FyFrrTRo6K2vqd5tk4qZgQZWQfencrdk7dF59wt6xPC2tSzogkyqlmtY+Jo7L8slMdwh64ZP6D4ts8cjo/UGTMvAbMQkd65RATnRw6qSUZ/9xdDHjhNwOmXq X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040450)(601004)(2401047)(5005006)(8121501046)(93006095)(93001095)(3002001)(10201501046)(6041248)(201703131423075)(201702281528075)(201703061421075)(20161123555025)(20161123562025)(20161123564025)(20161123560025)(6072148);SRVR:DM5PR15MB1194;BCL:0;PCL:0;RULEID:;SRVR:DM5PR15MB1194; X-Microsoft-Exchange-Diagnostics: 1;DM5PR15MB1194;4:sJ5FIJyuKKUJ/3MoWW9MWvUXFXyuPV4Y8keB8Cq20Cb4bTcWJ0gdmF0zoZifVHkBrdUcIovOGktmsKSPjev0R51d6wjG1udHxgQGz18STfN+4j0J5JEDD+q4Xj7ENnHqNg0UAMyUwZ08utEhYuL19nq7Qs2OAFM8K1I+advXECCUBkcKLyhYqqU9Buv1+ZgJTfEafdpTJcFAfRh3KAb52bBe4h4gyNgYOevJ3WegrsxZBFqQy1okj2zP4NTDTh3KT4Ej4so3oZMLtgYNi7yy67SaPKU7/kWC8ivEXKI7KoubuxRNRILRSqzIxn9YQljsEoaVN7bQNpA+XEWe5sj5HuvOxa+GhMOjpwKaIKMxRvgxUQEyui1mZKPwplyUJHi72hbl+LkLr6FyhR1IfCwKC0IrCRyrZWfIk1xEimtqH3i0EDRY2JvWXGtFaCyT02XvU169G/HudupWJZ9mUnAePiYJrVmSHf+aqjWEpczSHALaQgZB+poX2FV+7WNTceEdXnf8HKSNu6qq7YdbgkshDQFcxkYZGk8Vt5H3M86sAQ5hpWEgWua4bb2iY0MAhmw8WWfRvYBC0cLokZqrsM6Jpg/9j7GWUz9o1p8milQC9IEumauyAFGMbv/IlVBjsaSkrb6Vnf+UOvWMRrpUEj4mCa+x1/qdMDb0k7aDyrKH3ECvmO4EpiqBKrbRvJsQBcUnkZcpe3k01cxRHJ18o+Yi7Q== X-Forefront-PRVS: 028256169F X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(6049001)(39450400003)(39840400002)(39410400002)(39400400002)(39850400002)(24454002)(377454003)(50466002)(2950100002)(6666003)(117156002)(33646002)(53546009)(8676002)(65826007)(36756003)(25786009)(81166006)(76176999)(50986999)(189998001)(54356999)(3846002)(6116002)(42186005)(31686004)(38730400002)(4001350100001)(47776003)(65806001)(65956001)(66066001)(229853002)(6246003)(5660300001)(86362001)(90366009)(31696002)(4326008)(54906002)(2906002)(2870700001)(305945005)(83506001)(53936002)(77096006)(6486002);DIR:OUT;SFP:1102;SCL:1;SRVR:DM5PR15MB1194;H:[192.168.1.154];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;DM5PR15MB1194;23:nhNBjaIqhzXA+5E4Gb7lQgn9Bk2dMUp+dFTVC?= =?Windows-1252?Q?e8kRv9GgPFA3x2h0ohvDbx8OUQKzYO34KBRpwdHvY6AlwpWpKj3rntU6?= =?Windows-1252?Q?MukkH0uLwNkWNp1lFBktZlsvVMrQTDx8dFCPfXjr/hiejWEIFtrXgmr5?= =?Windows-1252?Q?wdSGZG2gif8qhmaJPnQOjKExbKQNZeXOQve1z+quBJh19WjloO6tphdd?= =?Windows-1252?Q?1nQUbcu0lpOwzG40+WdbTZW0olYZiCJf4HCOsH82LOZLgvVarliNmjRJ?= =?Windows-1252?Q?CzmAaQZFfFe8gHKEUvHo7u8OXyHawBZCFFuwruXOCvMJWrikRlDBGyub?= =?Windows-1252?Q?D7XEu10sPeowUvWZMyWb700wnZFzd1nLeVnf5/KPOUE4LyrlB1cgx56Z?= =?Windows-1252?Q?z68upS1l8eAxlCQWQXR6UH4yJRSYPMlluBHp3zRr0VzmzvokBGFUn2Vs?= =?Windows-1252?Q?E+0eb6dvtdCS26t7TZSzRlQ7jxnuHf65/cckYtfFkmjHyuhx/aDxWHnz?= =?Windows-1252?Q?kpYQMUZHkcHTv4RG4dD74GYIBcIyGpRB0pIezCr5CYhE9oFWzv787Bbr?= =?Windows-1252?Q?uPWCi9ceRlZ1cdeXA9rL0ajv7aRelIPj6ma+Tyf7OWgmQIOcMfsa/7hL?= =?Windows-1252?Q?P4m04p1D6gTdvQ+uYDw3IQPj0eQiWxf6Y8Bu1cap5ceWPIqN5orog9KB?= =?Windows-1252?Q?k3qrBSCVlw/3D4dbb+0wTIY/gTF+f65Q9SINsmWshARXwdwZ2Yf7D107?= =?Windows-1252?Q?s6YLQ358BHzTaLm9nXbJnJWCbwBp1DtuF4Yf8N/qFIan3KhV2PIrsmJA?= =?Windows-1252?Q?OjIUWrjpXFw0WTSMmGbBsN8rVo9w00RRh2vHiLXW8V3Tgw0IndVvTdA+?= =?Windows-1252?Q?SNsQNeuO4uOekNJ9ktX5qTaN+9JqDyga7BMe2j2mzoH7P1A1gYC9PFCI?= =?Windows-1252?Q?2hkjNsP4BsYrCHM5NhHl4384OCxyDkWeqwOP6wVIdNPexp5aptZ21i6I?= =?Windows-1252?Q?PGTt10SQQRpGUIw513Guj+ovEPhiTlRVnLOuuORAJO85OY+44uDt8it/?= =?Windows-1252?Q?Z4LX4ssuYOAoX6i+iNEeAXTioG3fKeE2Ewzd94dtvJCAJUqpwLbWMj/v?= =?Windows-1252?Q?2u0xvymEOVGG0mIZ6jBa6FoF536shZLDJO49cGx56OAv1pO0z9j3QTI1?= =?Windows-1252?Q?6f5mRpmiJsO1RzhaFOQYB5tmjKqeP1dP1KG9U2s5JfTwf7qLgl5rFCAN?= =?Windows-1252?Q?wrjG1H/vttJqnJTMGzKDMKRrrHMaSvzcCg3bUxUdv6umJAZaGmOirwQi?= =?Windows-1252?Q?krJ5aGfIip6R6owCacIztxLMEcfi8JOEdoYQ47MLRcnf2A=3D?= X-Microsoft-Exchange-Diagnostics: 1;DM5PR15MB1194;6:BcYZnz8u3dvNM+0dQZ5/Lh7DddtVqgAe/5XoYW81wWBJmGI7BObUWkemJ6XssLjF5doqUZE7GkMeyb18qg+gck2zqO6wzFeBQjpnVwm0WqIw4/WSkCXKU+HGxutilOL0RmRv+/2CC4tFxys+rgdopU1S/ffHwmu+3Z7VXuIy5s/bWTNg4F0SYFLKfZTDeMGQz+vbBAgPzkR7X/DzOTYkWkAZpt0GGaUvk5JwP01yqgUgtVSJR1Ey7/R1fngmeE+7UNWilTv5HYgCMbs30iv8ouBcVnwpDVRpqPKC9gYS0IVfbeIr7OSMQT5DRg6PybPwRFShj7mD8KWBd7xaxW16qXxwo8tjkV7ORZM0z6gUrSUc3lWNc9TqFkjx2gk4vukXSxXY+QNaytSzbv/4cOElYfmV/6TehAaRMvCvuZ2MALWHKaR6VCPtrCFjsJO5uLtpKinvMZnGToxF4htr6nQzsVuoEDH1XJIlm7Su4XAi332EhKm0ZGXRZ8fggkJVCaJkIrVPM401DJ40bmJHI9RgaQ==;5:pzutDC+InSqKnnEw7KC0cKv5o9x9v+SvXQNVOCQUVS5PBtyre7FpAKL3LN3aT9Vz4u1antzny3oSqD0LtMuNJxA2fIJU5FouxYdy171kCIX9jSYP/6ls3Os1EX+3IisXaoF/eOm+wzQQd4zJImh8XA==;24:q0TWh4do6M7CveuesFj37wqK+O/kte2NJsLEKU2YFuJXjGtS1qoRdj6/iQmyu+Zi1HeMJtgzhqanawTNVZbQ2WQxUUAz7TPFEGI/qKQFLjU= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;DM5PR15MB1194;7:l+LG2cyPcmb3wypaJjsaDIv5aMnb4414Y0Xfsho+Owf9zAU97qyni/6aa8CRJi01gQzW5myOI0hc9eY66FkJoIkxN5IkyffFObZ0jMRRrCUCjxcSEI7z3gcpS/s8yyEZH7/803tHETEB+kWLdkiA1yg12KmX0qcnfOGHkHz/jP4VgDDfVX3Epwv5GwBQ3QY+1IApE+pzG2q0upuY8EwQNrh7krp7nbkCEnfXX4R62OjEgeVEjPOvXLArwqj1YGM65MrP6zSELO+ai995TCbpYwS/ZohtzEoTUY0MywUfN4oRPATTe3v/mPXbH6XDvVC8DTeAK1pfbq7N+V+bpG3m2g==;20:XsKgnCLouSf/r9vWNjJbDhwzdsLpZUXs7kb8Exe5UY7q0yo1Be7r3EE3geJm/9SAZZmFqBN0AthDYL51ePhNWGi1dnUsEC55bNM9TcYSAwC7a8Qgk3l2Y2zpo/JYfueGgP+PhfsGmlB9NwtYsps73hkUtNLzK7c99b96L+DluRY= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Apr 2017 18:08:06.9311 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR15MB1194 X-OriginatorOrg: fb.com X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-04-19_15:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/19/2017 12:04 PM, Matias Bjørling wrote: > On 04/19/2017 07:39 PM, Arnd Bergmann wrote: >> The driver uses both u64 and sector_t to refer to offsets, and assigns between the >> two. This causes one harmless warning when sector_t is 32-bit: >> >> drivers/lightnvm/pblk-rb.c: In function 'pblk_rb_write_entry_gc': >> include/linux/lightnvm.h:215:20: error: large integer implicitly truncated to unsigned type [-Werror=overflow] >> drivers/lightnvm/pblk-rb.c:324:22: note: in expansion of macro 'ADDR_EMPTY' >> >> As the driver is already doing this inconsistently, changing the type >> won't make it worse and is an easy way to avoid the warning. >> >> Fixes: a4bd217b4326 ("lightnvm: physical block device (pblk) target") >> Signed-off-by: Arnd Bergmann >> --- >> drivers/lightnvm/pblk.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/lightnvm/pblk.h b/drivers/lightnvm/pblk.h >> index c82120ce3be5..11ed7d83f572 100644 >> --- a/drivers/lightnvm/pblk.h >> +++ b/drivers/lightnvm/pblk.h >> @@ -119,7 +119,7 @@ struct pblk_w_ctx { >> struct bio_list bios; /* Original bios - used for completion >> * in REQ_FUA, REQ_FLUSH case >> */ >> - sector_t lba; /* Logic addr. associated with entry */ >> + u64 lba; /* Logic addr. associated with entry */ >> struct ppa_addr ppa; /* Physic addr. associated with entry */ >> int flags; /* Write context flags */ >> }; >> > > Thanks Arnd. Jens, could you pick this up? Thank you Done, thanks Arnd. -- Jens Axboe