From: Dou Liyang <douliyangs@gmail.com>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Kashyap Desai <kashyap.desai@broadcom.com>,
shivasharan.srikanteshwara@broadcom.com,
Sumit Saxena <sumit.saxena@broadcom.com>,
ming.lei@redhat.com, Christoph Hellwig <hch@lst.de>,
linux-pci@vger.kernel.org
Subject: Re: [RFC PATCH v3] genirq/affinity: Create and transfer more irq desc info by a new structure
Date: Thu, 29 Nov 2018 22:30:22 +0800 [thread overview]
Message-ID: <b6f3cbb6-60b7-1425-9bff-0ac4565f56a7@gmail.com> (raw)
In-Reply-To: <CAErSpo5NCy6C7xqaWUNnC2uY+RRpZnbpOJUQxrz0aER-g6+XqQ@mail.gmail.com>
Hi Bjorn,
on 2018/11/29 4:00, Bjorn Helgaas wrote:
> [+cc linux-pci]
> Since you mention reports, are there URLs to mailing list archives you
> can include?
OK, I will add it:
https://marc.info/?l=linux-kernel&m=153543887027997&w=2
>> - entry = alloc_msi_entry(&dev->dev, nvec, masks);
>> + entry = alloc_msi_entry(&dev->dev, nvec, affi_desc);
>
> Can you split this into two or more patches? Most of these changes
Yes, next non-RFC version will do.
> are trivial and not very interesting, and the fact that they're all in
> one patch makes it hard to find and review the interesting bits. For
> example,
>
> 1) Rename all the local variables while keeping the type the same
> (or just leave the name the same; I think "affinity" would be a fine
> name, and I would be OK if we ended up with "struct irq_affinity_desc
> *masks" or "struct irq_affinity_desc *affinity"). This patch would
> obviously have no functional impact and would remove a lot of the
> trivial changes.
> Oops, how stupid I am !
> 2) Add "struct irq_affinity_desc" containing only "struct cpumask
> masks" and irq_create_affinity_desc() (or leave the name as
> irq_create_affinity_masks() and adjust the signature). This would
> also have no functional impact and would be a fairly trivial patch.
> > 3) Add "flags" to struct irq_affinity_desc and the related code.
> This is the real meat of your patch, and with the above out of the
> way, it will be much smaller and it'll be obvious what the important
> changes are.
>
I see, :)
Thanks,
dou
next prev parent reply other threads:[~2018-11-29 14:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-28 16:45 [RFC PATCH v3] genirq/affinity: Create and transfer more irq desc info by a new structure Dou Liyang
2018-11-28 20:00 ` Bjorn Helgaas
2018-11-28 21:28 ` Thomas Gleixner
2018-11-29 14:30 ` Dou Liyang [this message]
2018-11-28 22:03 ` Thomas Gleixner
2018-11-29 14:49 ` Dou Liyang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b6f3cbb6-60b7-1425-9bff-0ac4565f56a7@gmail.com \
--to=douliyangs@gmail.com \
--cc=bhelgaas@google.com \
--cc=hch@lst.de \
--cc=kashyap.desai@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=shivasharan.srikanteshwara@broadcom.com \
--cc=sumit.saxena@broadcom.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).