From: Richard Weinberger <richard@nod.at>
To: Brian Norris <computersforpeace@gmail.com>,
Zach Brown <zach.brown@ni.com>
Cc: dwmw2@infradead.org, boris.brezillon@free-electrons.com,
dedekind1@gmail.com, linux-mtd@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [RESEND PATCH v5 2/5] mtd: ubi: use 'max_bad_blocks' to compute bad_peb_limit if available
Date: Fri, 25 Nov 2016 14:37:22 +0100 [thread overview]
Message-ID: <b6fe6ae4-7ef2-ed61-3bb4-dd00f92524f8@nod.at> (raw)
In-Reply-To: <20161122184215.GA77253@google.com>
Zach, Brian,
sorry for the late review.
On 22.11.2016 19:42, Brian Norris wrote:
> On Mon, Nov 21, 2016 at 01:51:36PM -0600, Zach Brown wrote:
>> From: Jeff Westfahl <jeff.westfahl@ni.com>
>>
>> Use the MTD function 'max_bad_blocks' to compute the UBI bad_peb_limit,
>> if the function is implemented for an MTD and doesn't return an error.
>
> I'm not exactly a UBI expert here, but it seems reasonable that we
> should adjust the Kconfig documentation for MTD_UBI_BEB_LIMIT to further
> emphasize that it's a default, if the value can't be determined by other
> means.
>
>> Signed-off-by: Jeff Westfahl <jeff.westfahl@ni.com>
>> Signed-off-by: Zach Brown <zach.brown@ni.com>
>> Acked-by: Boris Brezillon <boris.brezillon@free-electron.com>
>> ---
>> drivers/mtd/ubi/build.c | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/drivers/mtd/ubi/build.c b/drivers/mtd/ubi/build.c
>> index 85d54f3..e9940a9 100644
>> --- a/drivers/mtd/ubi/build.c
>> +++ b/drivers/mtd/ubi/build.c
>> @@ -584,6 +584,10 @@ static int get_bad_peb_limit(const struct ubi_device *ubi, int max_beb_per1024)
>> int limit, device_pebs;
>> uint64_t device_size;
>>
>> + limit = mtd_max_bad_blocks(ubi->mtd, 0, ubi->mtd->size);
>> + if (limit > 0)
>> + return limit;
>
> Are you sure you want to even override the user-provided
> max_beb_per1024 value taken from the mtd= line? I'd think if someone
> went as far as to specify this in the kernel command line, they don't
> expect it to get overridden. Just my two cents.
I agree. With this patch applied the limit can be set via Kconfig, cmdline and automatically.
IMHO the automatic value via mtd_max_bad_blocks and over-writeable via cmdline and Kconfig.
...and this needs to be documented. :-)
I'd go so far and suggest dropping the Kconfig option.
Thanks,
//richard
next prev parent reply other threads:[~2016-11-25 13:38 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-21 19:51 [RESEND PATCH v5 0/5] mtd: use ONFI bad blocks per LUN to calculate UBI bad PEB limit Zach Brown
2016-11-21 19:51 ` [RESEND PATCH v5 1/5] mtd: introduce function max_bad_blocks Zach Brown
2016-11-22 18:48 ` Brian Norris
2016-11-21 19:51 ` [RESEND PATCH v5 2/5] mtd: ubi: use 'max_bad_blocks' to compute bad_peb_limit if available Zach Brown
2016-11-22 18:42 ` Brian Norris
2016-11-25 13:37 ` Richard Weinberger [this message]
2016-11-25 14:03 ` Richard Weinberger
2016-11-22 18:50 ` Brian Norris
2016-11-21 19:51 ` [RESEND PATCH v5 3/5] mtd: nand: Add max_bb_per_die and blocks_per_die fields to nand_chip Zach Brown
2016-11-21 19:51 ` [RESEND PATCH v5 4/5] mtd: nand: implement 'max_bad_blocks' mtd function Zach Brown
2016-11-22 18:55 ` Brian Norris
2016-11-21 19:51 ` [RESEND PATCH v5 5/5] mtd: nand: set max_bb_per_die and blocks_per_die for ONFI compliant chips Zach Brown
2016-11-22 9:37 ` [RESEND PATCH v5 0/5] mtd: use ONFI bad blocks per LUN to calculate UBI bad PEB limit Boris Brezillon
2016-11-22 9:53 ` Richard Weinberger
2016-11-22 18:58 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b6fe6ae4-7ef2-ed61-3bb4-dd00f92524f8@nod.at \
--to=richard@nod.at \
--cc=boris.brezillon@free-electrons.com \
--cc=computersforpeace@gmail.com \
--cc=dedekind1@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=zach.brown@ni.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).