From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6001EC33C9E for ; Wed, 8 Jan 2020 11:39:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 36037206DA for ; Wed, 8 Jan 2020 11:39:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=xilinx.onmicrosoft.com header.i=@xilinx.onmicrosoft.com header.b="jgs0fFBD" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727186AbgAHLj0 (ORCPT ); Wed, 8 Jan 2020 06:39:26 -0500 Received: from mail-bn8nam11on2082.outbound.protection.outlook.com ([40.107.236.82]:6215 "EHLO NAM11-BN8-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726098AbgAHLj0 (ORCPT ); Wed, 8 Jan 2020 06:39:26 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MI4AbdstTkDTHuf3eEnp3JJz8fMnTK2FNAfAPtW0bk3D8v55DPou+GkgKlrfNgwntmk8TCMIOKTqJl/CWtCNXCKdAi7mWWsvExw6xPndffX6Yg7Lf7RGAxuqBERJbIa9kDB4vNhp0yq8YOBBVa+pENI+CXXC+9PMiuwYp+VAwK0DgpnGmoA+00GVk34NKoIAadZd8j/ylaxq003d7vrRJk7djZAa5tiVRZp8aw1h7rqhBCR0H9xHpKTrfCxMeKj1/u2p/Ac7RYwToy9r/qMX4DZ9geBiM4GqfG4BxmMxsWentPQgs+7oe8fa0F2mABJ+lEoCmjkHSxyGN+9UWupU0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=86NCv4S5OfzE8NviR3BBfwuys4CPtDUq8+5VecaOG8Y=; b=WdlY1GNX6nqqAGJIQvY2w6rLfnMwjStOttC2p27yUE3imPZcq3DsAhqA2ZJDYdbkuAjEe+SHeRPmxlVbv9OEPKKgEkZgLbwY9/T1QdGM93fBSFlRgwwu/ANpPMPk7TNOsUGYCvi60A/jUFisjunXEigMqm/4FDH+17wyaW6dgaSrkyWgqRGaZSxOYrAmrhECNi/qaexxm3DzgoIp+WqczDLdKMBQHeD8iF5DNPOP7t3Z8v353Cpybhfa0qfRFGTKwg3BNsmYJ7P88pfjT8hxykJvor8QHIi58LLMbCydP/TpxnwN7XPPlwYOl4WiC1hgyvmAOlTgyetlJAv1wrRssw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.60.83) smtp.rcpttodomain=sang-engineering.com smtp.mailfrom=xilinx.com; dmarc=bestguesspass action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=86NCv4S5OfzE8NviR3BBfwuys4CPtDUq8+5VecaOG8Y=; b=jgs0fFBDSdWbtg4IHIL5QlGVgZkD7l5mTUZSCReQW/Xpy/VvnhNDQC5TXesyxWqvX+Tix39I74x0ewsSZ/5WBkfr0XuC6TSRFVMq7pZL/sYH02fJlIbxkYMRsFbWQHsK3QL2eXcYglUd7Flj5vMs0wtHSmBlDf+UBYMOSL1sNIs= Received: from SN4PR0201CA0007.namprd02.prod.outlook.com (2603:10b6:803:2b::17) by BN7PR02MB5122.namprd02.prod.outlook.com (2603:10b6:408:2f::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2602.10; Wed, 8 Jan 2020 11:39:21 +0000 Received: from SN1NAM02FT025.eop-nam02.prod.protection.outlook.com (2a01:111:f400:7e44::201) by SN4PR0201CA0007.outlook.office365.com (2603:10b6:803:2b::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2602.12 via Frontend Transport; Wed, 8 Jan 2020 11:39:21 +0000 Authentication-Results: spf=pass (sender IP is 149.199.60.83) smtp.mailfrom=xilinx.com; sang-engineering.com; dkim=none (message not signed) header.d=none;sang-engineering.com; dmarc=bestguesspass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.60.83 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.60.83; helo=xsj-pvapsmtpgw01; Received: from xsj-pvapsmtpgw01 (149.199.60.83) by SN1NAM02FT025.mail.protection.outlook.com (10.152.72.87) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.2602.11 via Frontend Transport; Wed, 8 Jan 2020 11:39:20 +0000 Received: from unknown-38-66.xilinx.com ([149.199.38.66] helo=xsj-pvapsmtp01) by xsj-pvapsmtpgw01 with esmtp (Exim 4.63) (envelope-from ) id 1ip9gG-0005ma-9b; Wed, 08 Jan 2020 03:39:20 -0800 Received: from [127.0.0.1] (helo=localhost) by xsj-pvapsmtp01 with smtp (Exim 4.63) (envelope-from ) id 1ip9gA-00077k-DL; Wed, 08 Jan 2020 03:39:14 -0800 Received: from xsj-pvapsmtp01 (mailhost.xilinx.com [149.199.38.66]) by xsj-smtp-dlp2.xlnx.xilinx.com (8.13.8/8.13.1) with ESMTP id 008Bd5nF010571; Wed, 8 Jan 2020 03:39:05 -0800 Received: from [172.30.17.107] by xsj-pvapsmtp01 with esmtp (Exim 4.63) (envelope-from ) id 1ip9g0-000737-On; Wed, 08 Jan 2020 03:39:04 -0800 Subject: Re: [PATCH 07/12] i2c: xiic: convert to use i2c_new_client_device() To: Wolfram Sang , linux-i2c@vger.kernel.org, Shubhrajyoti Datta Cc: Michal Simek , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, "git@Xilinx.com" References: <20200107174748.9616-1-wsa+renesas@sang-engineering.com> <20200107174748.9616-8-wsa+renesas@sang-engineering.com> From: Michal Simek Message-ID: Date: Wed, 8 Jan 2020 12:39:03 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <20200107174748.9616-8-wsa+renesas@sang-engineering.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.2.0.1013-23620.005 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:149.199.60.83;IPV:;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(4636009)(396003)(39860400002)(376002)(346002)(136003)(199004)(189003)(478600001)(54906003)(316002)(107886003)(8676002)(186003)(4326008)(426003)(356004)(9786002)(44832011)(81166006)(81156014)(336012)(2616005)(8936002)(2906002)(110136005)(70586007)(4744005)(31696002)(6636002)(26005)(5660300002)(36756003)(31686004)(70206006);DIR:OUT;SFP:1101;SCL:1;SRVR:BN7PR02MB5122;H:xsj-pvapsmtpgw01;FPR:;SPF:Pass;LANG:en;PTR:unknown-60-83.xilinx.com;A:1;MX:1; X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 26675e66-34c0-4f71-73a6-08d7942f66ee X-MS-TrafficTypeDiagnostic: BN7PR02MB5122: X-Microsoft-Antispam-PRVS: X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-Oob-TLC-OOBClassifiers: OLM:6790; X-Forefront-PRVS: 02760F0D1C X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7TywrqFAIPgSeGQPgaVPNIn8/sJ6cah7ft+HA0zKprdLwKSbD+qNfdQp6HfCrv/1DHHuX3tpfk9DFCmAyx1dSvAD6X8b7E8UcsjyYo76wW+Sw0OCEI/aH+KaJqSx45TLaLfEfZhf8Py+Fbd7V0X1BYhPTGdNQQNs2LohXouddB3ocRMpLRjpVtoxpqYblP1FjBDdtxechzsyMo+SqHznNYCePybys/5urpgo1mnG8RxUX8JUqrAhhN2YjrwjXjSvUfN+Ar2p1i2GIUA4Luj+RUYeMICYCh1ZglZKQatPfZmaGrYIutlsRU3rQRVgx/1NLiOz9Xno2OWYId6YxnTLqPKZkFibS3nK+xcdkPMcxrq7gd5Om+A4dievh+m9NzFKgbHzufB9tzyARKUD7sWtLHYQn4rX3RoGy9gueCY3ZHs4dsM0BP17ohnRJ7htDFdl X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jan 2020 11:39:20.6380 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 26675e66-34c0-4f71-73a6-08d7942f66ee X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.60.83];Helo=[xsj-pvapsmtpgw01] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR02MB5122 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07. 01. 20 18:47, Wolfram Sang wrote: > Move away from the deprecated API and return the shiny new ERRPTR where > useful. > > Signed-off-by: Wolfram Sang > --- > Build tested only. > > drivers/i2c/busses/i2c-xiic.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/i2c/busses/i2c-xiic.c b/drivers/i2c/busses/i2c-xiic.c > index d8d49f1814c7..61e081b186cc 100644 > --- a/drivers/i2c/busses/i2c-xiic.c > +++ b/drivers/i2c/busses/i2c-xiic.c > @@ -806,7 +806,7 @@ static int xiic_i2c_probe(struct platform_device *pdev) > if (pdata) { > /* add in known devices to the bus */ > for (i = 0; i < pdata->num_devices; i++) > - i2c_new_device(&i2c->adap, pdata->devices + i); > + i2c_new_client_device(&i2c->adap, pdata->devices + i); > } > > return 0; > Acked-by: Michal Simek Shubhrajyoti: Can you please retest? Thanks, Michal