From: Aswath Govindraju <a-govindraju@ti.com>
To: Lokesh Vutla <lokeshvutla@ti.com>
Cc: Vignesh Raghavendra <vigneshr@ti.com>, Suman Anna <s-anna@ti.com>,
Kishon Vijay Abraham I <kishon@ti.com>,
Nishanth Menon <nm@ti.com>, Tero Kristo <kristo@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] arm64: dts: ti: k3-am64-main: Update the location of ATF in SRAM and increase its max size
Date: Wed, 9 Jun 2021 20:52:07 +0530 [thread overview]
Message-ID: <b709d5a8-17dd-37e7-405a-35f39f84878b@ti.com> (raw)
In-Reply-To: <e53458a9-e5f6-6507-f95c-2406b47b5576@ti.com>
Hi Lokesh,
On 09/06/21 7:59 pm, Lokesh Vutla wrote:
>
>
> On 07/06/21 7:08 pm, Aswath Govindraju wrote:
>> Due to a limitation for USB DFU boot mode, SPL load address has to be less
>> than or equal to 0x70001000. So, load address of SPL and ATF have been
>> moved to 0x70000000 and 0x701a0000 respectively.
>>
>> Also, the maximum size of ATF has been increased to 0x1c000 [1].
>>
>> Therefore, update ATF's location and maximum size accordingly in the device
>> tree file.
>>
>> [1] - https://git.trustedfirmware.org/TF-A/trusted-firmware-a.git/commit/?id=2fb5312f61a7de8b7a70e1639199c4f14a10b6f9
>>
>> Signed-off-by: Aswath Govindraju <a-govindraju@ti.com>
>> ---
>> arch/arm64/boot/dts/ti/k3-am64-main.dtsi | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/ti/k3-am64-main.dtsi b/arch/arm64/boot/dts/ti/k3-am64-main.dtsi
>> index ca59d1f711f8..fcd12b6f10f6 100644
>> --- a/arch/arm64/boot/dts/ti/k3-am64-main.dtsi
>> +++ b/arch/arm64/boot/dts/ti/k3-am64-main.dtsi
>> @@ -13,8 +13,8 @@
>> #size-cells = <1>;
>> ranges = <0x0 0x00 0x70000000 0x200000>;
>>
>> - atf-sram@0 {
>> - reg = <0x0 0x1a000>;
>> + atf-sram@1a0000 {
>> + reg = <0x1a0000 0x1c000>;
>
> After thinking a bot more, isn't size be 0x20000?
> ATF is allocated with 125KB no? no point keeping the ~3 as hole IMO.
>
The max size of ATF as defined above in [1] is 0x1c000 and as the
argument has to reflect it I have modified it to the same.
Thanks,
Aswath
> Thanks and regards,
> Lokesh
>
>> };
>> };
>>
>>
next prev parent reply other threads:[~2021-06-09 15:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-07 13:38 [PATCH v2] arm64: dts: ti: k3-am64-main: Update the location of ATF in SRAM and increase its max size Aswath Govindraju
2021-06-09 14:09 ` Lokesh Vutla
2021-06-09 14:29 ` Lokesh Vutla
2021-06-09 15:22 ` Aswath Govindraju [this message]
2021-06-09 15:24 ` Lokesh Vutla
2021-06-14 18:16 ` Suman Anna
2021-06-11 19:00 ` Nishanth Menon
2021-06-14 14:32 ` Nishanth Menon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b709d5a8-17dd-37e7-405a-35f39f84878b@ti.com \
--to=a-govindraju@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=kishon@ti.com \
--cc=kristo@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lokeshvutla@ti.com \
--cc=nm@ti.com \
--cc=robh+dt@kernel.org \
--cc=s-anna@ti.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).