From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5AD3C28CC6 for ; Wed, 5 Jun 2019 05:22:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C9B162086A for ; Wed, 5 Jun 2019 05:22:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726502AbfFEFWK (ORCPT ); Wed, 5 Jun 2019 01:22:10 -0400 Received: from smtprelay0133.hostedemail.com ([216.40.44.133]:36724 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725268AbfFEFWK (ORCPT ); Wed, 5 Jun 2019 01:22:10 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay03.hostedemail.com (Postfix) with ESMTP id 48FDC837F27D; Wed, 5 Jun 2019 05:22:08 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: quiet08_1276c8ca9e514 X-Filterd-Recvd-Size: 2325 Received: from XPS-9350 (cpe-23-242-196-136.socal.res.rr.com [23.242.196.136]) (Authenticated sender: joe@perches.com) by omf08.hostedemail.com (Postfix) with ESMTPA; Wed, 5 Jun 2019 05:22:06 +0000 (UTC) Message-ID: Subject: Re: [PATCH] media: do not use C++ style comments in uapi headers From: Joe Perches To: Greg KH , Masahiro Yamada Cc: Arnd Bergmann , Linux Media Mailing List , Mauro Carvalho Chehab , Thomas Gleixner , Randy Dunlap , Linux Kernel Mailing List Date: Tue, 04 Jun 2019 22:22:05 -0700 In-Reply-To: <20190605051040.GA22760@kroah.com> References: <20190604111334.22182-1-yamada.masahiro@socionext.com> <8cf48e20064eabdfe150795365e6ca6f36032e9f.camel@perches.com> <20190604134213.GA26263@kroah.com> <20190605051040.GA22760@kroah.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.30.5-0ubuntu0.18.10.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2019-06-05 at 07:10 +0200, Greg KH wrote: > On Wed, Jun 05, 2019 at 01:10:41PM +0900, Masahiro Yamada wrote: > > On Wed, Jun 5, 2019 at 3:21 AM Arnd Bergmann wrote: [] > > This means we cannot reliably use uint{8,16,32,64}_t in UAPI headers. > > We should not be doing that as they are in the userspace "namespace" of > variables, not in the kernel namespace. We've been over this many times > in the past :( Just not very successfully... $ git grep -w -P 'u?_?int(?:8|16|32|64)_t' include/uapi | wc -l 342 $ git grep -w -P --name-only 'u?_?int(?:8|16|32|64)_t' include/uapi | wc -l 13 Documentation helps a bit, checkpatch helps as well. Maintainer knowledge and vigilance probably helps the most.