From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752398AbcISPyC (ORCPT ); Mon, 19 Sep 2016 11:54:02 -0400 Received: from mout.web.de ([212.227.15.14]:60400 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752145AbcISPx7 (ORCPT ); Mon, 19 Sep 2016 11:53:59 -0400 Subject: [PATCH 1/5] GPU-DRM: Use kmalloc_array() in drm_legacy_addbufs_pci() To: dri-devel@lists.freedesktop.org, Daniel Vetter , David Airlie References: <566ABCD9.1060404@users.sourceforge.net> <2fd2da19-d57e-5017-0594-fd52e78493fa@users.sourceforge.net> Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall From: SF Markus Elfring Message-ID: Date: Mon, 19 Sep 2016 17:53:49 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <2fd2da19-d57e-5017-0594-fd52e78493fa@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:6L5yZXfoeEhxwrdBTPXFRhjU1l/OULRUe6OQw6iSa9T0neyg0+I DaR4HUtrL0i3Vnt/ucDjXakVQwu6hHT7r+FCKer/YO7STkHtZ59Q9cYBfMKsQnw27/bTQMM g04oiIl8YEBeLiuFrjVtgyIvbh1WEdCGXtmvXWf1Txyt6etLms4WxhqpesllJNZveKIbB6u t3z/cNJOF9S9cl5+9JQhg== X-UI-Out-Filterresults: notjunk:1;V01:K0:ApVTL/idtkQ=:Jrio7hFZ08X7blDQw11+cc plfvbl+SAT1bn+OAFA2dfQ82ra+vYyiaR7on/VPcs4lvV21HtCCLEz3Vb1UsR9cQJx1bkd8dJ eRc5oFwHvUclM/FjHSHWwschsnRw7lHTODRxCMOFwlJoLATYy7OkY3zaJ/U7Kg2g73e5/eJEx zOc7FM1RzD3tOEGnRtOcpqjqdKTVYiIZB9uaR9MTgfTzt/bvNXPi5SPybO5t2UyFEo/yQoz0+ fdE6MwBNcMQHNztaWirkGxxGc8+cpZnlo8u/IjlSJHgptJDii5OB51O1/Y5T2GWjqTEkIf3f0 jhtjVkwIwal8kTDnRPvRN9iYBbJQyYAFnSHPTr6aDEZc0oZ9yP6c3WKioHx2aBzLb9eXYXNc6 gghdhyRZ7khLkldAzOTunRmJN6rz3MCqJSaIqGiv8kW8pxBGDXgmCrg62o7WNJmtN6/wzMPdH 9ZAYRDAbEqZXQIWW14Yny+7r5nqS79Sa23LgRhsYuOI36bxICiNQCSU46d+xX1HIB6OK2A6DJ FEoH1rH1b/rEf3gvPZS9fgrj7R+oXe60zCkRsd8F4jRg2I+mMlUWzFSnXLubOAoPoIiwKKmzo T6k0jRWNv1h4Ih9LHngfLhJ16Qb6UP3ksX8wznbsfWLE4WoJmTD6fDlUjU4bAbIYtMC321HyV qh9m4NdDMSsjDTxYgjFk9xGYW6aCIuPbQbV8j3MaTIJGnIDdcefNGslhDkn8a2w1ScFRyKMq3 h8/1zqSpk2QbSjwXbrKdsPpXJ/voX90mGSutgJx6dHmNRYzGGP67FIfpGKICeli+ath5nzNqf J06lgh0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Mon, 19 Sep 2016 17:07:06 +0200 A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus use the corresponding function "kmalloc_array". This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/gpu/drm/drm_bufs.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_bufs.c b/drivers/gpu/drm/drm_bufs.c index 3219151..ed33f43 100644 --- a/drivers/gpu/drm/drm_bufs.c +++ b/drivers/gpu/drm/drm_bufs.c @@ -923,8 +923,9 @@ int drm_legacy_addbufs_pci(struct drm_device *dev, /* Keep the original pagelist until we know all the allocations * have succeeded */ - temp_pagelist = kmalloc((dma->page_count + (count << page_order)) * - sizeof(*dma->pagelist), GFP_KERNEL); + temp_pagelist = kmalloc_array(dma->page_count + (count << page_order), + sizeof(*dma->pagelist), + GFP_KERNEL); if (!temp_pagelist) { kfree(entry->buflist); kfree(entry->seglist); -- 2.10.0