linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Tianjia Zhang" <tianjia.zhang@linux.alibaba.com>
To: "smueller" <smueller@chronox.de>
Cc: "herbert" <herbert@gondor.apana.org.au>,
	"davem" <davem@davemloft.net>,
	"linux-crypto" <linux-crypto@vger.kernel.org>,
	"linux-kernel" <linux-kernel@vger.kernel.org>
Subject: 回复：[PATCH 2/6] lib/mpi: Introduce ec implementation to MPI library
Date: Mon, 27 Jan 2020 11:15:29 +0800	[thread overview]
Message-ID: <b71ed6fc-0c71-4eef-9023-064538e4011b.tianjia.zhang@linux.alibaba.com> (raw)
In-Reply-To: <659d400e-d107-4050-84fc-bd8d39409aa3.tianjia.zhang@linux.alibaba.com>

Hello Stephan,

> Why do we need a second implementation of ECC? Why can't we reuse the existing 
> ECC implementation in crypto/ecc.c? Or are there limitations in the existing 
> ECC implementation that cannot be fixed?



The implementation of crypto/ecc.c is still relatively crude at present, and the implementation of a complete elliptic curve is still incomplete.


In the beginning I did develop based on crypto/ecc.c, but then I couldn't go on.


mpi/ec.c is based on the more mature mpi library, and mpi has been well implemented in the kernel. The interface definition and operations have a more mature interface, and this interface is compatible with the kernel. It's also very good, openssl also has a corresponding BIGNUM structure, a complete elliptic curve such as sm2, both encryption and decryption and signature algorithms, and there are many inconveniences based on crypto/ecc.c development. A more powerful The underlying algorithm library to support, mpi from libgcrypt is a good choice.

I think that if possible, you can also consider migrating crypto/ecc.c based algorithms to mpi/ec.c in the future, so that mpi/ec.c becomes a basic elliptic curve algorithm.

Here are some of my personal views, welcome everyone to discuss, and hope that the maintainers can think about it.

Thanks.
Tianjia

  parent reply	other threads:[~2020-01-27  3:15 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-21  9:57 [PATCH] Introduce OSCCA SM2 asymmetric cipher algorithm Tianjia Zhang
2020-01-21  9:57 ` [PATCH 1/6] lib/mpi: Extend the MPI library Tianjia Zhang
2020-01-21  9:57 ` [PATCH 2/6] lib/mpi: Introduce ec implementation to " Tianjia Zhang
2020-01-21 11:40   ` Stephan Mueller
     [not found]     ` <4de1c585-c4b1-4847-8327-55bb7fec1f3b.tianjia.zhang@linux.alibaba.com>
     [not found]       ` <f4b4442e-e2fd-44e6-9e0a-59187780b4d0.tianjia.zhang@linux.alibaba.com>
     [not found]         ` <3092f996-ce62-42e6-ab42-a56254f567b3.tianjia.zhang@linux.alibaba.com>
     [not found]           ` <4c8c9974-b777-48ba-ace3-d052932dbaa1.tianjia.zhang@linux.alibaba.com>
     [not found]             ` <b3ed010c-f3d9-46d2-97bb-c80f012f687f.tianjia.zhang@linux.alibaba.com>
     [not found]               ` <659d400e-d107-4050-84fc-bd8d39409aa3.tianjia.zhang@linux.alibaba.com>
2020-01-27  3:15                 ` Tianjia Zhang [this message]
2020-01-21  9:57 ` [PATCH 3/6] crypto: sm2 - introduce OSCCA SM2 asymmetric cipher algorithm Tianjia Zhang
2020-01-22  5:57   ` Herbert Xu
     [not found]     ` <b481c227-22f7-40d7-bbc5-a581cf87e1a5.tianjia.zhang@linux.alibaba.com>
     [not found]       ` <20ef340c-18ba-4746-b26e-5911d3f77bdd.tianjia.zhang@linux.alibaba.com>
2020-01-27  3:16         ` 回复：[PATCH " Tianjia Zhang
2020-01-21  9:57 ` [PATCH 4/6] crypto: testmgr - support test with different ciphertext per encryption Tianjia Zhang
2020-01-21  9:57 ` [PATCH 5/6] crypto: testmgr - Add SM2 test vectors Tianjia Zhang
2020-01-21  9:57 ` [PATCH 6/6] crypto: proc - simplify the c_show function Tianjia Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b71ed6fc-0c71-4eef-9023-064538e4011b.tianjia.zhang@linux.alibaba.com \
    --to=tianjia.zhang@linux.alibaba.com \
    --cc=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=smueller@chronox.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).