From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F361C433E1 for ; Thu, 28 May 2020 13:22:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 80D4721534 for ; Thu, 28 May 2020 13:22:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390247AbgE1NWh (ORCPT ); Thu, 28 May 2020 09:22:37 -0400 Received: from foss.arm.com ([217.140.110.172]:52508 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390102AbgE1NWg (ORCPT ); Thu, 28 May 2020 09:22:36 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5E0A5D6E; Thu, 28 May 2020 06:22:35 -0700 (PDT) Received: from [192.168.1.84] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id EF2473F52E; Thu, 28 May 2020 06:22:33 -0700 (PDT) Subject: Re: [PATCH 01/15] drm/panfrost: avoid static declaration To: =?UTF-8?B?Q2zDqW1lbnQgUMOpcm9u?= , Rob Herring , Tomeu Vizoso , Alyssa Rosenzweig , Viresh Kumar , Nishanth Menon , Stephen Boyd , Maxime Ripard , Chen-Yu Tsai Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20200510165538.19720-1-peron.clem@gmail.com> <20200510165538.19720-2-peron.clem@gmail.com> From: Steven Price Message-ID: Date: Thu, 28 May 2020 14:22:31 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200510165538.19720-2-peron.clem@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/05/2020 17:55, Clément Péron wrote: > This declaration can be avoided so change it. > > Signed-off-by: Clément Péron Reviewed-by: Steven Price > --- > drivers/gpu/drm/panfrost/panfrost_devfreq.c | 38 ++++++++++----------- > 1 file changed, 18 insertions(+), 20 deletions(-) > > diff --git a/drivers/gpu/drm/panfrost/panfrost_devfreq.c b/drivers/gpu/drm/panfrost/panfrost_devfreq.c > index 413987038fbf..1b560b903ea6 100644 > --- a/drivers/gpu/drm/panfrost/panfrost_devfreq.c > +++ b/drivers/gpu/drm/panfrost/panfrost_devfreq.c > @@ -14,7 +14,24 @@ > #include "panfrost_gpu.h" > #include "panfrost_regs.h" > > -static void panfrost_devfreq_update_utilization(struct panfrost_device *pfdev); > +static void panfrost_devfreq_update_utilization(struct panfrost_device *pfdev) > +{ > + ktime_t now; > + ktime_t last; > + > + if (!pfdev->devfreq.devfreq) > + return; > + > + now = ktime_get(); > + last = pfdev->devfreq.time_last_update; > + > + if (atomic_read(&pfdev->devfreq.busy_count) > 0) > + pfdev->devfreq.busy_time += ktime_sub(now, last); > + else > + pfdev->devfreq.idle_time += ktime_sub(now, last); > + > + pfdev->devfreq.time_last_update = now; > +} > > static int panfrost_devfreq_target(struct device *dev, unsigned long *freq, > u32 flags) > @@ -139,25 +156,6 @@ void panfrost_devfreq_suspend(struct panfrost_device *pfdev) > devfreq_suspend_device(pfdev->devfreq.devfreq); > } > > -static void panfrost_devfreq_update_utilization(struct panfrost_device *pfdev) > -{ > - ktime_t now; > - ktime_t last; > - > - if (!pfdev->devfreq.devfreq) > - return; > - > - now = ktime_get(); > - last = pfdev->devfreq.time_last_update; > - > - if (atomic_read(&pfdev->devfreq.busy_count) > 0) > - pfdev->devfreq.busy_time += ktime_sub(now, last); > - else > - pfdev->devfreq.idle_time += ktime_sub(now, last); > - > - pfdev->devfreq.time_last_update = now; > -} > - > void panfrost_devfreq_record_busy(struct panfrost_device *pfdev) > { > panfrost_devfreq_update_utilization(pfdev); >