From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753498AbdAZKRr (ORCPT ); Thu, 26 Jan 2017 05:17:47 -0500 Received: from mout.web.de ([212.227.15.4]:63888 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751899AbdAZKRn (ORCPT ); Thu, 26 Jan 2017 05:17:43 -0500 Subject: [PATCH 1/5] gtp: Use kmalloc_array() in gtp_hashtable_new() To: netdev@vger.kernel.org, Alexey Dobriyan , "David S. Miller" , Harald Welte , Johannes Berg , Pablo Neira References: <698070a4-e08e-78e5-0214-df69783cce22@users.sourceforge.net> Cc: LKML , kernel-janitors@vger.kernel.org From: SF Markus Elfring Message-ID: Date: Thu, 26 Jan 2017 11:17:05 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <698070a4-e08e-78e5-0214-df69783cce22@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:yZVkdz61jTekLQMzK6hyWgaD17np89+2kvBnzbM8Wfzttut8KRd gmw2NF5rrTe3MAP2dDjI+YzJnxN1NAvcjTitDMO8qmRBzSyMHTM3ySfx/6+nCDWDK9nDCAH Tg5gqiWlPZU684G8CBhxNOz/YEiNwuJAwmurp7kYGaaZJMCX4zyz4BzC1PQlHHizFoocmVM I0oNqf2CD6utoavNTuk6Q== X-UI-Out-Filterresults: notjunk:1;V01:K0:2LE8FDEIf30=:Ks2G3NY1ISjKZb8SU1fdCt 2lzE3yTBxrbmJJTsYHqtF4XfmglsVaDjns494UrL4DZfqz+mYJVLpfMludCTnfpzxpG6u96SR MSXNDx/plWqMmv7lmVc9VEu1n8/gzRtkiPDrc1tXM+YkEceMSIDv3sE14yVWBo+XmG5MO72IC x1Cihuqfq1D/n6ly7fKakjuNjS1xW92hT2p7gO6lHCByZs/CSclmfuIhv8AUO23VibpTjT21q blcJBwPGwW2ogITLJYlLKy4yvapmYGAY4cffMPAIn0IBg3LqorkRRWQcuty3cNk8gCO58vnwa kZznNyiBV6HSLGmipagn5P3g5wLnOj32Ig/4EzBhkIOdDDrpzZt6hqtDRovILcm60r1MDvfXs GsHLi99BKf5pA/PKZr+3+qI/WCdamvzRCi6lwRcUUzZ9ytzRoenZM7bscfwCxc4IwfqE11QBP t1CISv1vzc+hW8xU3tRlPbXHZBm1EJadDkZDY2q4WVGf46sWD9VfGR7NLOwzir+V9QCjopsT4 sLDrE19X0xkxxWvY+D39nnufuHtWpaeJQIadk+F1ixV003AaJTW/uvSoVuqXZ3Yp7Ze5JcjQR 7hH1wCWqB/OXUDIpiofoZIB3nkFWaq5jE5kbRvbPa5LYdoBYlqlxXcvS4No+mv0Yr1fT5OcK7 A2Id/Z0AbK58CzAXKf0MkfXpsN3FFx/niTOc9+tOcjktkPN9LWIZdlKsOreM6+nRyRj7mNO2t 6d6ESkSPsonyFDejXtJiGuXBnmrjqVpSQVBtJ9okyBaQKT2/Sx2fyBNbRPSk9S5qwH59wVen4 FVSRfRi Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Wed, 25 Jan 2017 22:01:00 +0100 * Multiplications for the size determination of memory allocations indicated that array data structures should be processed. Thus use the corresponding function "kmalloc_array". This issue was detected by using the Coccinelle software. * Replace the specification of data structures by pointer dereferences to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring --- drivers/net/gtp.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/gtp.c b/drivers/net/gtp.c index 8b6810bad54b..5d0d520ae40f 100644 --- a/drivers/net/gtp.c +++ b/drivers/net/gtp.c @@ -783,11 +783,13 @@ static int gtp_hashtable_new(struct gtp_dev *gtp, int hsize) { int i; - gtp->addr_hash = kmalloc(sizeof(struct hlist_head) * hsize, GFP_KERNEL); + gtp->addr_hash = kmalloc_array(hsize, sizeof(*gtp->addr_hash), + GFP_KERNEL); if (gtp->addr_hash == NULL) return -ENOMEM; - gtp->tid_hash = kmalloc(sizeof(struct hlist_head) * hsize, GFP_KERNEL); + gtp->tid_hash = kmalloc_array(hsize, sizeof(*gtp->tid_hash), + GFP_KERNEL); if (gtp->tid_hash == NULL) goto err1; -- 2.11.0