From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB76BC433EF for ; Mon, 13 Jun 2022 18:21:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244865AbiFMSVM (ORCPT ); Mon, 13 Jun 2022 14:21:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33076 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240480AbiFMSUu (ORCPT ); Mon, 13 Jun 2022 14:20:50 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 598C82625; Mon, 13 Jun 2022 07:24:57 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id B3FAEB81057; Mon, 13 Jun 2022 14:24:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 62760C34114; Mon, 13 Jun 2022 14:24:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1655130294; bh=dPms+2tRdPeMRCtz5LXIpvIE+GN1BU34aLWsVdJu1Vk=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=JBTCOzqCdMJBT8yKGC8YXsLHu1BdhDo6koMJFVf/GILP1HthKupIsCQfoXloEIOq0 F6GdbxuDQNRYechTnfhIp2MM0jx5V6TMKzgg3fb8KwTSWejdVE37h6TkVq7WpN18+H 95+3/bl/hWhZpgFGGyAAW2yTcqohBauj82LkNOWCGDw3vcD9rl1chwSZVH0oXYgcxD Deg6iXRDclnXIRKwFI5Ch9/KdgT2nO9DDax0hjPbo1AooM4w6UINUUOL7D9dNq3s/T 4T7c698TqI1jgFynuLEc0c73ZdufT5PxMds8+ccCUfugLdi5EyadZUAg+JW6zHz35T QKSOQ5/GIrF6A== Message-ID: Date: Mon, 13 Jun 2022 09:24:52 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH] firmware: stratix10-svc: remove extraneous asterisk from #define comments Content-Language: en-US To: Randy Dunlap , Bagas Sanjaya , linux-doc@vger.kernel.org Cc: kernel test robot , Ang Tien Sung , Richard Gong , linux-kernel@vger.kernel.org References: <202206120445.FeU5wA93-lkp@intel.com> <20220612012253.16583-1-bagasdotme@gmail.com> <967fa124-5ebc-6b0d-fa1a-27619eb01b8c@infradead.org> From: Dinh Nguyen In-Reply-To: <967fa124-5ebc-6b0d-fa1a-27619eb01b8c@infradead.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/11/22 20:31, Randy Dunlap wrote: > Hi, > > On 6/11/22 18:22, Bagas Sanjaya wrote: >> kernel test robot reported kernel-doc warning: >> >>>> include/linux/firmware/intel/stratix10-svc-client.h:19: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst >> >> The warning above is because comments above #define statements are prefixed >> with double asterisk, which kernel-doc script mistook these as actual >> kernel-doc comment. >> >> Remove extraneouse asterisk from these comments. > > extraneous > >> >> Link: https://lore.kernel.org/lkml/202206120445.FeU5wA93-lkp@intel.com/ >> Fixes: 88f42ac48b8968 ("firmware: stratix10-svc: Add support for FCS") >> Reported-by: kernel test robot >> Cc: Ang Tien Sung >> Cc: Richard Gong >> Cc: Dinh Nguyen >> Cc: linux-kernel@vger.kernel.org >> Signed-off-by: Bagas Sanjaya > > Acked-by: Randy Dunlap > > Thanks. > >> --- >> include/linux/firmware/intel/stratix10-svc-client.h | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/include/linux/firmware/intel/stratix10-svc-client.h b/include/linux/firmware/intel/stratix10-svc-client.h >> index 5098dbba138d0f..63927aba0b5699 100644 >> --- a/include/linux/firmware/intel/stratix10-svc-client.h >> +++ b/include/linux/firmware/intel/stratix10-svc-client.h >> @@ -15,7 +15,7 @@ >> #define SVC_CLIENT_FPGA "fpga" >> #define SVC_CLIENT_RSU "rsu" >> #define SVC_CLIENT_FCS "fcs" >> -/** >> +/* >> * Status of the sent command, in bit number >> * >> * SVC_STATUS_OK: >> @@ -50,7 +50,7 @@ >> #define SVC_STATUS_ERROR 5 >> #define SVC_STATUS_NO_SUPPORT 6 >> #define SVC_STATUS_INVALID_PARAM 7 >> -/** >> +/* >> * Flag bit for COMMAND_RECONFIG >> * >> * COMMAND_RECONFIG_FLAG_PARTIAL: >> >> base-commit: 107da326a0a3e7b6e81557c4225548db670a2647 > Applied! Thanks, Dinh