From: John Hubbard <jhubbard@nvidia.com>
To: Leonardo Bras <leonardo@linux.ibm.com>,
<linuxppc-dev@lists.ozlabs.org>, <linux-kernel@vger.kernel.org>,
Linux-MM <linux-mm@kvack.org>
Cc: Dan Williams <dan.j.williams@intel.com>,
Arnd Bergmann <arnd@arndb.de>, Jason Gunthorpe <jgg@ziepe.ca>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Mahesh Salgaonkar <mahesh@linux.vnet.ibm.com>,
YueHaibing <yuehaibing@huawei.com>,
Nicholas Piggin <npiggin@gmail.com>,
"Mike Rapoport" <rppt@linux.ibm.com>,
Keith Busch <keith.busch@intel.com>,
"Richard Fontana" <rfontana@redhat.com>,
Paul Mackerras <paulus@samba.org>,
"Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>,
Ganesh Goudar <ganeshgr@linux.ibm.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ira Weiny <ira.weiny@intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
"Allison Randal" <allison@lohutok.net>
Subject: Re: [PATCH v2 11/11] powerpc/mm/book3s64/pgtable: Uses counting method to skip serializing
Date: Mon, 23 Sep 2019 13:26:48 -0700 [thread overview]
Message-ID: <b72cb1db-c341-4963-1a8b-ae71fe936458@nvidia.com> (raw)
In-Reply-To: <c64d34118542d5c2d31b8f6b7802d2a29dac71ef.camel@linux.ibm.com>
On 9/23/19 1:23 PM, Leonardo Bras wrote:
> On Mon, 2019-09-23 at 12:58 -0700, John Hubbard wrote:
>>
>> CPU 0 CPU 1
>> ------ --------------
>> READ(pte) (re-ordered at run time)
>> atomic_inc(val) (no run-time memory barrier!)
>>
>> pmd_clear(pte)
>> if (val)
>> run_on_all_cpus(): IPI
>> local_irq_disable() (also not a mem barrier)
>>
>> if(pte)
>> walk page tables
>
> Let me see if I can understand,
> On most patches, it would be:
>
> CPU 0 CPU 1
> ------ --------------
> ptep = __find_linux_pte
> (re-ordered at run time)
> atomic_inc(val)
> pmd_clear(pte)
> smp_mb()
> if (val)
> run_on_all_cpus(): IPI
> local_irq_disable()
>
> if(ptep)
> pte = *ptep;
>
> Is that what you meant?
>
>
Yes.
thanks,
--
John Hubbard
NVIDIA
next prev parent reply other threads:[~2019-09-23 20:26 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-20 19:50 [PATCH v2 00/11] Introduces new count-based method for monitoring lockless pagetable wakls Leonardo Bras
2019-09-20 19:50 ` [PATCH v2 01/11] powerpc/mm: Adds counting method to monitor lockless pgtable walks Leonardo Bras
[not found] ` <90ceb0ca-9f04-65a5-586c-e37c2ecc6e4e@nvidia.com>
2019-09-23 20:50 ` Leonardo Bras
2019-09-20 19:50 ` [PATCH v2 02/11] asm-generic/pgtable: Adds dummy functions " Leonardo Bras
[not found] ` <cb7d4196-c646-82c7-d61f-b28ee9ab47b9@nvidia.com>
2019-09-23 20:48 ` Leonardo Bras
2019-09-20 19:50 ` [PATCH v2 03/11] mm/gup: Applies counting method to monitor gup_pgd_range Leonardo Bras
[not found] ` <2e060677-eadf-c32e-d8c5-8e22c8ca118e@nvidia.com>
2019-09-23 21:01 ` Leonardo Bras
2019-09-20 19:50 ` [PATCH v2 04/11] powerpc/mce_power: Applies counting method to monitor lockless pgtbl walks Leonardo Bras
2019-09-20 19:50 ` [PATCH v2 05/11] powerpc/perf: " Leonardo Bras
2019-09-20 19:50 ` [PATCH v2 06/11] powerpc/mm/book3s64/hash: " Leonardo Bras
2019-09-20 19:50 ` [PATCH v2 07/11] powerpc/kvm/e500: " Leonardo Bras
2019-09-20 19:50 ` [PATCH v2 08/11] powerpc/kvm/book3s_hv: " Leonardo Bras
2019-09-20 19:50 ` [PATCH v2 09/11] powerpc/kvm/book3s_64: " Leonardo Bras
2019-09-20 19:50 ` [PATCH v2 10/11] powerpc/book3s_64: Enables counting method to monitor lockless pgtbl walk Leonardo Bras
2019-09-20 19:50 ` [PATCH v2 11/11] powerpc/mm/book3s64/pgtable: Uses counting method to skip serializing Leonardo Bras
[not found] ` <1b39eaa7-751d-40bc-d3d7-41aaa15be42a@nvidia.com>
2019-09-20 20:28 ` Leonardo Bras
[not found] ` <4ea26ffb-ad03-bdff-7893-95332b22a5fd@nvidia.com>
2019-09-23 17:25 ` Leonardo Bras
[not found] ` <8706a1f1-0c5e-d152-938b-f355b9a5aaa8@nvidia.com>
2019-09-23 19:40 ` Leonardo Bras
[not found] ` <1568b3ef-cec9-bf47-edaa-c775c2f544fb@nvidia.com>
2019-09-23 20:23 ` Leonardo Bras
2019-09-23 20:26 ` John Hubbard [this message]
2019-09-20 19:56 ` [PATCH v2 00/11] Introduces new count-based method for monitoring lockless pagetable wakls Leonardo Bras
2019-09-20 20:12 ` Leonardo Bras
[not found] ` <b2d47f4b-2bf2-20a8-2438-4fd3f9b08a63@nvidia.com>
2019-09-23 20:58 ` Leonardo Bras
2019-09-24 21:23 [PATCH v2 11/11] powerpc/mm/book3s64/pgtable: Uses counting method to skip serializing Leonardo Bras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b72cb1db-c341-4963-1a8b-ae71fe936458@nvidia.com \
--to=jhubbard@nvidia.com \
--cc=akpm@linux-foundation.org \
--cc=allison@lohutok.net \
--cc=aneesh.kumar@linux.ibm.com \
--cc=arnd@arndb.de \
--cc=dan.j.williams@intel.com \
--cc=ganeshgr@linux.ibm.com \
--cc=gregkh@linuxfoundation.org \
--cc=ira.weiny@intel.com \
--cc=jgg@ziepe.ca \
--cc=keith.busch@intel.com \
--cc=leonardo@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mahesh@linux.vnet.ibm.com \
--cc=npiggin@gmail.com \
--cc=paulus@samba.org \
--cc=rfontana@redhat.com \
--cc=rppt@linux.ibm.com \
--cc=tglx@linutronix.de \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).