From: Michael Straube <straube.linux@gmail.com>
To: Joe Perches <joe@perches.com>, gregkh@linuxfoundation.org
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/6] staging: rtl8723bs: fix indentation
Date: Sun, 8 Jul 2018 19:36:13 +0200 [thread overview]
Message-ID: <b7468cdd-1555-ef61-b475-3d4677aa423a@gmail.com> (raw)
In-Reply-To: <194c5239a1ef9a1f472bad7c5bcc6e3b7675b0ec.camel@perches.com>
On 07/08/18 18:46, Joe Perches wrote:
> On Sun, 2018-07-08 at 12:38 +0200, Michael Straube wrote:
>> Remove unrequired extra indentations.
> []
>> diff --git a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c b/drivers/staging/rtl8723bs/core/rtw_ieee80211.c
> []
>> @@ -69,16 +69,16 @@ int rtw_get_bit_value_from_ieee_value(u8 val)
>>
>> uint rtw_is_cckrates_included(u8 *rate)
>> {
>> - u32 i = 0;
>> + u32 i = 0;
>>
>> - while (rate[i] != 0) {
>> - if ((((rate[i]) & 0x7f) == 2) || (((rate[i]) & 0x7f) == 4) ||
>> - (((rate[i]) & 0x7f) == 11) || (((rate[i]) & 0x7f) == 22))
>> - return true;
>> - i++;
>> - }
>> + while (rate[i] != 0) {
>> + if ((((rate[i]) & 0x7f) == 2) || (((rate[i]) & 0x7f) == 4) ||
>> + (((rate[i]) & 0x7f) == 11) || (((rate[i]) & 0x7f) == 22))
>> + return true;
>> + i++;
>> + }
>>
>> - return false;
>> + return false;
>> }
>
> Hi Michael.
>
> Please try to improve the code for human readers and/or
> reduce overall object size over merely shutting up checkpatch
> style warnings.
>
Hi Joe,
I agree that it's better to improve the code than just silence
warnings.
Thanks for your advice.
> For instance:
>
> You could reduce object size a little by eliminating the
> multiple use of 0x7f and index and dereferencing the
> pointer instead.
>
> $ size drivers/staging/rtl8723bs/core/rtw_ieee80211.o*
> text data bss dec hex filename
> 10085 76 0 10161 27b1 drivers/staging/rtl8723bs/core/rtw_ieee80211.o.new
> 10149 76 0 10225 27f1 drivers/staging/rtl8723bs/core/rtw_ieee80211.o.old
>
> Something like:
>
> uint rtw_is_cckrates_included(u8 *rate)
> {
> while (*rate) {
> u8 r = *rate & 0x7f;
>
> if (r == 2 || r == 4 || r == 11 || r == 22)
> return true;
> rate++;
> }
>
> return false;
> }
>
> uint rtw_is_cckratesonly_included(u8 *rate)
> {
> while (*rate) {
> u8 r = *rate & 0x7f;
>
> if (r != 2 && r != 4 && r != 11 && r != 22)
> return false;
> rate++;
> }
>
> return true;
> }
>
The patch has been added to staging-testing already.
I will send patches with your suggestions the next days.
Thanks again.
Michael
next prev parent reply other threads:[~2018-07-08 17:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-08 10:38 [PATCH 1/6] staging: rtl8723bs: replace while with shorter for loop Michael Straube
2018-07-08 10:38 ` [PATCH 2/6] staging: rtl8723bs: replace tab with space Michael Straube
2018-07-08 10:38 ` [PATCH 3/6] staging: rtl8723bs: fix indentation Michael Straube
2018-07-08 16:46 ` Joe Perches
2018-07-08 17:36 ` Michael Straube [this message]
2018-07-11 13:57 ` Michael Straube
2018-07-11 16:03 ` Joe Perches
2018-07-11 19:17 ` Michael Straube
2018-07-08 10:38 ` [PATCH 4/6] staging: rtl8723bs: remove blank lines Michael Straube
2018-07-08 10:38 ` [PATCH 5/6] staging: rtl8723bs: add missing " Michael Straube
2018-07-08 10:38 ` [PATCH 6/6] staging: rtl8723bs: remove braces from single if statement Michael Straube
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b7468cdd-1555-ef61-b475-3d4677aa423a@gmail.com \
--to=straube.linux@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).