From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-24.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8951C43216 for ; Fri, 6 Aug 2021 12:32:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 99B3760F25 for ; Fri, 6 Aug 2021 12:32:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343696AbhHFMcW (ORCPT ); Fri, 6 Aug 2021 08:32:22 -0400 Received: from smtp-relay-canonical-1.canonical.com ([185.125.188.121]:50200 "EHLO smtp-relay-canonical-1.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343689AbhHFMcU (ORCPT ); Fri, 6 Aug 2021 08:32:20 -0400 Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-canonical-1.canonical.com (Postfix) with ESMTPS id EAD8A40655 for ; Fri, 6 Aug 2021 12:32:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1628253123; bh=YQe/91rqxclnbWHtwO35T2bNBoJfLztQell5eud2D5g=; h=To:Cc:References:From:Subject:Message-ID:Date:MIME-Version: In-Reply-To:Content-Type; b=iXplBf/1xTcON7DZyHUzcCaV6e1iXE6fp9kEU8i6kBVqmb8qnQ4Hzn0RjGXHTZzQS J9ki6Dbspfy6U/nxEQE01qn6RgA22H0Jy9GYNSFeoNdaeEppBiQ7bI8coG5m/3sKEm jw2rDqsyTKOsVPIQeXwBseIXWi3PmdDDYWwmPh221rd9f9oOkYs20cc0r+100VNyr0 wVU6T0Bucr2FjFTZBMlO161A6eT9qXmpfpSloNSqd82gXh1G2ExLI5jFWX5Q1pHJVa y0yqZo6RipHuKHeax60RTkkMRdq7qzQnGXpegXH+JKZAxjpRPuiD+R0dpsuR+ypFKI MJFCLTI4GSEZQ== Received: by mail-ej1-f71.google.com with SMTP id gg35-20020a17090689a3b0290580ff45a075so3050455ejc.20 for ; Fri, 06 Aug 2021 05:32:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:cc:references:from:subject:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=YQe/91rqxclnbWHtwO35T2bNBoJfLztQell5eud2D5g=; b=knYzzvgAaL4Yh03UODFkWmdDUXT/HKgkfhsyk7WCR33S7QM/E6FiFOZukAFswSuF8P 1ZbqjXEt4bXDbqnEpndYza3+xZz7knxoVYaAvnPfW16zuzhvsb1wk21NeazQiazRlp7m gzJnOo85+E1Rxo640F4x+WicV6CZs79DhmRDNy9p1mPtkhhq/aNtdFH8i5gDVdQuBCbq C5Sz8CPhZObaX0LJVCjR4NcSCqL5heTFz4dsfy2X5a8bOrgqUP4YOyKF4kEJAL+GIKuU HPoQvA5lFCpGWnFlLeXm5QVNwSXVdx1SK/QUj1kzbmuxs3Cz107PaoaNzarZQgQ94fsN jByw== X-Gm-Message-State: AOAM5306/waw0c11x8dbugulQzL6uFmPCMAXnJJD0uL5kny5qaX7Vrpx gixxtWQSgY9Igh5haM7nb+lsyq11ImdqI2qI+FkvBaymyAzgSeNNRiWauwz1SQ39AbIbKQ5WbBh wgNs2BYzasEpc33rtDPNBh7PgL/w8+ca8ac8kzZa6+g== X-Received: by 2002:a05:6402:4245:: with SMTP id g5mr1726668edb.222.1628253123619; Fri, 06 Aug 2021 05:32:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzPTsSpDhFkB5QZHp+lNdByTmL0W66nvl/IYvdDKIE3av+cgSJZOTy0u6WCyCiMVy5KpW0G1A== X-Received: by 2002:a05:6402:4245:: with SMTP id g5mr1726635edb.222.1628253123479; Fri, 06 Aug 2021 05:32:03 -0700 (PDT) Received: from [192.168.8.102] ([86.32.42.198]) by smtp.gmail.com with ESMTPSA id h19sm3870934edt.87.2021.08.06.05.32.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 06 Aug 2021 05:32:03 -0700 (PDT) To: Sam Protsenko , =?UTF-8?Q?Pawe=c5=82_Chmiel?= Cc: Sylwester Nawrocki , Chanwoo Choi , Linus Walleij , Tomasz Figa , Rob Herring , Stephen Boyd , Michael Turquette , Jiri Slaby , Greg Kroah-Hartman , Charles Keepax , Ryu Euiyoul , Tom Gall , Sumit Semwal , John Stultz , Amit Pundir , devicetree , linux-arm Mailing List , linux-clk , "open list:GPIO SUBSYSTEM" , Linux Kernel Mailing List , Linux Samsung SOC , "open list:SERIAL DRIVERS" References: <20210730144922.29111-1-semen.protsenko@linaro.org> <20210730144922.29111-13-semen.protsenko@linaro.org> <455cfb5e-dff7-a5c0-3875-49abe3e900f3@canonical.com> <68734f6c-fc76-595c-8d34-8924dbbbb845@canonical.com> From: Krzysztof Kozlowski Subject: Re: [PATCH 12/12] arm64: dts: exynos: Add Exynos850 SoC support Message-ID: Date: Fri, 6 Aug 2021 14:32:00 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/08/2021 14:07, Sam Protsenko wrote: > On Fri, 6 Aug 2021 at 10:49, Krzysztof Kozlowski > wrote: >> >> On 06/08/2021 01:06, Sam Protsenko wrote: >>> On Sat, 31 Jul 2021 at 12:03, Krzysztof Kozlowski >>> wrote: >>> >>>>> >>>>> This patch adds minimal SoC support. Particular board device tree files >>>>> can include exynos850.dtsi file to get SoC related nodes, and then >>>>> reference those nodes further as needed. >>>>> >>>>> Signed-off-by: Sam Protsenko >>>>> --- >>>>> .../boot/dts/exynos/exynos850-pinctrl.dtsi | 782 ++++++++++++++++++ >>>>> arch/arm64/boot/dts/exynos/exynos850-usi.dtsi | 30 + >>>>> arch/arm64/boot/dts/exynos/exynos850.dtsi | 245 ++++++ >>>> >>>> Not buildable. Missing Makefile, missing DTS. Please submit with initial >>>> DTS, otherwise no one is able to verify it even compiles. >>>> >>> >>> This device is not available for purchase yet. I'll send the patch for >>> board dts once it's announced. I can do all the testing for now, if >>> you have any specific requests. Would it be possible for us to review >>> and apply only SoC support for now? Will send v2 soon... >> >> What you propose is equal to adding a driver (C source code) without >> ability to compile it. What's the point of having it in the kernel? It's >> unverifiable, unbuildable and unusable. >> > > Yes, I understand. That's adding code with no users, and it's not a > good practice. > >> We can review the DTSI however merging has to be with a DTS. Usually the >> SoC vendor adds first an evalkit (e.g. SMDK board). Maybe you have one >> for Exynos850? Otherwise if you cannot disclose the actual board, the >> DTSI will have to wait. You can submit drivers, though. >> > > Sure, let's go this way. I'll send v2 soon. Improving patches and > having Reviewed-by tag for those would good enough for me at this > point. I'll continue to prepare another Exynos850 related patches > until the actual board is announced, like proper clock driver, reset, > MMC, etc. Is it ok if I send those for a review too (so I can fix all > issues ahead)? Sure, prepare all necessary drivers earlier. I suspect clocks will be a real pain because of significant changes modeled in vendor kernel. I remember Paweł Chmiel (+Cc) was doing something for these: https://github.com/PabloPL/linux/tree/exynos7420 I mentioned before - you should also modify the chipid driver. Check also other drivers in drivers/soc/samsung, although some are needed only for suspend&resume. BTW, Paweł, How is your Exynos7420 progress? :) > And should I maybe add RFC tag for those? No need. Drivers can be merged before DTS users. Best regards, Krzysztof