linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v3] pwm: add depends, COMPILE_TEST and default y for brcm-iproc-pwm
@ 2016-10-08 20:54 Scott Branden
  2016-10-08 21:02 ` Ray Jui
  2017-01-18 10:45 ` Thierry Reding
  0 siblings, 2 replies; 4+ messages in thread
From: Scott Branden @ 2016-10-08 20:54 UTC (permalink / raw)
  To: Thierry Reding
  Cc: linux-pwm, linux-kernel, BCM Kernel Feedback, Scott Branden

- Add depends on COMMON_CLK for PWM_BCM_IPROC
- Enable COMPILE_TEST for broader compile coverage.
- Default y for IPROC PWM driver for IPROC SoCs.
This allows you to turn it on simply by selecting CONFIG_PWM.

Signed-off-by: Scott Branden <scott.branden@broadcom.com>
---
 drivers/pwm/Kconfig | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/pwm/Kconfig b/drivers/pwm/Kconfig
index 80a566a..3eb1b6b 100644
--- a/drivers/pwm/Kconfig
+++ b/drivers/pwm/Kconfig
@@ -76,7 +76,9 @@ config PWM_ATMEL_TCB
 
 config PWM_BCM_IPROC
 	tristate "iProc PWM support"
-	depends on ARCH_BCM_IPROC
+	depends on ARCH_BCM_IPROC || COMPILE_TEST
+	depends on COMMON_CLK
+	default ARCH_BCM_IPROC
 	help
 	  Generic PWM framework driver for Broadcom iProc PWM block. This
 	  block is used in Broadcom iProc SoC's.
-- 
2.5.0

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH v3] pwm: add depends, COMPILE_TEST and default y for brcm-iproc-pwm
  2016-10-08 20:54 [PATCH v3] pwm: add depends, COMPILE_TEST and default y for brcm-iproc-pwm Scott Branden
@ 2016-10-08 21:02 ` Ray Jui
  2016-12-20 19:32   ` Scott Branden
  2017-01-18 10:45 ` Thierry Reding
  1 sibling, 1 reply; 4+ messages in thread
From: Ray Jui @ 2016-10-08 21:02 UTC (permalink / raw)
  To: Scott Branden, Thierry Reding
  Cc: linux-pwm, linux-kernel, BCM Kernel Feedback



On 10/8/2016 1:54 PM, Scott Branden wrote:
> - Add depends on COMMON_CLK for PWM_BCM_IPROC
> - Enable COMPILE_TEST for broader compile coverage.
> - Default y for IPROC PWM driver for IPROC SoCs.
> This allows you to turn it on simply by selecting CONFIG_PWM.
>
> Signed-off-by: Scott Branden <scott.branden@broadcom.com>
> ---
>  drivers/pwm/Kconfig | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/pwm/Kconfig b/drivers/pwm/Kconfig
> index 80a566a..3eb1b6b 100644
> --- a/drivers/pwm/Kconfig
> +++ b/drivers/pwm/Kconfig
> @@ -76,7 +76,9 @@ config PWM_ATMEL_TCB
>
>  config PWM_BCM_IPROC
>  	tristate "iProc PWM support"
> -	depends on ARCH_BCM_IPROC
> +	depends on ARCH_BCM_IPROC || COMPILE_TEST
> +	depends on COMMON_CLK
> +	default ARCH_BCM_IPROC
>  	help
>  	  Generic PWM framework driver for Broadcom iProc PWM block. This
>  	  block is used in Broadcom iProc SoC's.
>

Looks good to me!

Reviewed-by: Ray Jui <ray.jui@broadcom.com>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v3] pwm: add depends, COMPILE_TEST and default y for brcm-iproc-pwm
  2016-10-08 21:02 ` Ray Jui
@ 2016-12-20 19:32   ` Scott Branden
  0 siblings, 0 replies; 4+ messages in thread
From: Scott Branden @ 2016-12-20 19:32 UTC (permalink / raw)
  To: Ray Jui, Thierry Reding; +Cc: linux-pwm, linux-kernel, BCM Kernel Feedback

Hi Thierry,

Could you pick up this patch?

On 16-10-08 02:02 PM, Ray Jui wrote:
>
>
> On 10/8/2016 1:54 PM, Scott Branden wrote:
>> - Add depends on COMMON_CLK for PWM_BCM_IPROC
>> - Enable COMPILE_TEST for broader compile coverage.
>> - Default y for IPROC PWM driver for IPROC SoCs.
>> This allows you to turn it on simply by selecting CONFIG_PWM.
>>
>> Signed-off-by: Scott Branden <scott.branden@broadcom.com>
>> ---
>>  drivers/pwm/Kconfig | 4 +++-
>>  1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/pwm/Kconfig b/drivers/pwm/Kconfig
>> index 80a566a..3eb1b6b 100644
>> --- a/drivers/pwm/Kconfig
>> +++ b/drivers/pwm/Kconfig
>> @@ -76,7 +76,9 @@ config PWM_ATMEL_TCB
>>
>>  config PWM_BCM_IPROC
>>      tristate "iProc PWM support"
>> -    depends on ARCH_BCM_IPROC
>> +    depends on ARCH_BCM_IPROC || COMPILE_TEST
>> +    depends on COMMON_CLK
>> +    default ARCH_BCM_IPROC
>>      help
>>        Generic PWM framework driver for Broadcom iProc PWM block. This
>>        block is used in Broadcom iProc SoC's.
>>
>
> Looks good to me!
>
> Reviewed-by: Ray Jui <ray.jui@broadcom.com>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v3] pwm: add depends, COMPILE_TEST and default y for brcm-iproc-pwm
  2016-10-08 20:54 [PATCH v3] pwm: add depends, COMPILE_TEST and default y for brcm-iproc-pwm Scott Branden
  2016-10-08 21:02 ` Ray Jui
@ 2017-01-18 10:45 ` Thierry Reding
  1 sibling, 0 replies; 4+ messages in thread
From: Thierry Reding @ 2017-01-18 10:45 UTC (permalink / raw)
  To: Scott Branden; +Cc: linux-pwm, linux-kernel, BCM Kernel Feedback

[-- Attachment #1: Type: text/plain, Size: 513 bytes --]

On Sat, Oct 08, 2016 at 01:54:05PM -0700, Scott Branden wrote:
> - Add depends on COMMON_CLK for PWM_BCM_IPROC
> - Enable COMPILE_TEST for broader compile coverage.
> - Default y for IPROC PWM driver for IPROC SoCs.
> This allows you to turn it on simply by selecting CONFIG_PWM.
> 
> Signed-off-by: Scott Branden <scott.branden@broadcom.com>
> ---
>  drivers/pwm/Kconfig | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)

Applied with a slightly modified commit message.

Thanks,
Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2017-01-18 10:45 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-08 20:54 [PATCH v3] pwm: add depends, COMPILE_TEST and default y for brcm-iproc-pwm Scott Branden
2016-10-08 21:02 ` Ray Jui
2016-12-20 19:32   ` Scott Branden
2017-01-18 10:45 ` Thierry Reding

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).