From: "Reddy, MallikarjunaX" <mallikarjunax.reddy@linux.intel.com>
To: Rob Herring <robh+dt@kernel.org>
Cc: "open list:DMA GENERIC OFFLOAD ENGINE SUBSYSTEM"
<dmaengine@vger.kernel.org>, Vinod <vkoul@kernel.org>,
devicetree@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Andy Shevchenko <andriy.shevchenko@intel.com>,
chuanhua.lei@linux.intel.com, "Kim,
Cheol Yong" <cheol.yong.kim@intel.com>,
"Wu, Qiming" <qi-ming.wu@intel.com>,
malliamireddy009@gmail.com,
Peter Ujfalusi <peter.ujfalusi@ti.com>
Subject: Re: [RESEND PATCH v10 1/2] dt-bindings: dma: Add bindings for Intel LGM SoC
Date: Fri, 15 Jan 2021 16:14:13 +0800 [thread overview]
Message-ID: <b78a503b-2dca-3f5c-050e-b7c92a215842@linux.intel.com> (raw)
In-Reply-To: <CAL_JsqJE59nA_Bvt1rL95WfeXjQkOSPiTZk8zAbdHSkujmS3gQ@mail.gmail.com>
Sure Rob.
Thanks,
Mallikarjuna reddy A
On 1/15/2021 4:25 AM, Rob Herring wrote:
> On Tue, Dec 15, 2020 at 10:08 PM Amireddy Mallikarjuna reddy
> <mallikarjunax.reddy@linux.intel.com> wrote:
>> Add DT bindings YAML schema for DMA controller driver
>> of Lightning Mountain (LGM) SoC.
>>
>> Signed-off-by: Amireddy Mallikarjuna reddy <mallikarjunax.reddy@linux.intel.com>
>> Reviewed-by: Rob Herring <robh@kernel.org>
>> ---
>> v1:
>> - Initial version.
>>
>> v2:
>> - Fix bot errors.
>>
>> v3:
>> - No change.
>>
>> v4:
>> - Address Thomas langer comments
>> - use node name pattern as dma-controller as in common binding.
>> - Remove "_" (underscore) in instance name.
>> - Remove "port-" and "chan-" in attribute name for both 'dma-ports' & 'dma-channels' child nodes.
>>
>> v5:
>> - Moved some of the attributes in 'dma-ports' & 'dma-channels' child nodes to dma client/consumer side as cells in 'dmas' properties.
>>
>> v6:
>> - Add additionalProperties: false
>> - completely removed 'dma-ports' and 'dma-channels' child nodes.
>> - Moved channel dt properties to client side dmas.
>> - Use standard dma-channels and dma-channel-mask properties.
>> - Documented reset-names
>> - Add description for dma-cells
>>
>> v7:
>> - modified compatible to oneof
>> - Reduced number of dma-cells to 3
>> - Fine tune the description of some properties.
>>
>> v7-resend:
>> - rebase to 5.10-rc1
>> - No change.
>>
>> v8:
>> - rebased to 5.10-rc3
>> - Fixing the bot issues (wrong indentation)
>>
>> v9:
>> - Use 'enum' instead of oneOf+const
>> - Drop '#dma-cells' in required:, already covered in dma-common.yaml
>> - Drop nodename Already covered by dma-controller.yaml
>>
>> v10:
>> - rebased to 5.10-rc6
>> - Add Reviewed-by: Rob Herring <robh@kernel.org>
>> - Fixed typo.
>> - moved property dma-desc-in-sram to driver side.
>> - Moved property dma-orrc to driver side.
>>
>> v10-resend:
>> - rebased to 5.10
>> - No change
>> ---
>> .../devicetree/bindings/dma/intel,ldma.yaml | 116 ++++++++++++++++++
>> 1 file changed, 116 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/dma/intel,ldma.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/dma/intel,ldma.yaml b/Documentation/devicetree/bindings/dma/intel,ldma.yaml
>> new file mode 100644
>> index 000000000000..866d4c758a7a
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/dma/intel,ldma.yaml
>> @@ -0,0 +1,116 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/dma/intel,ldma.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Lightning Mountain centralized DMA controllers.
>> +
>> +maintainers:
>> + - chuanhua.lei@intel.com
>> + - mallikarjunax.reddy@intel.com
>> +
>> +allOf:
>> + - $ref: "dma-controller.yaml#"
>> +
>> +properties:
>> + compatible:
>> + enum:
>> + - intel,lgm-cdma
>> + - intel,lgm-dma2tx
>> + - intel,lgm-dma1rx
>> + - intel,lgm-dma1tx
>> + - intel,lgm-dma0tx
>> + - intel,lgm-dma3
>> + - intel,lgm-toe-dma30
>> + - intel,lgm-toe-dma31
>> +
>> + reg:
>> + maxItems: 1
>> +
>> + "#dma-cells":
>> + const: 3
>> + description:
>> + The first cell is the peripheral's DMA request line.
>> + The second cell is the peripheral's (port) number corresponding to the channel.
>> + The third cell is the burst length of the channel.
>> +
>> + dma-channels:
>> + minimum: 1
>> + maximum: 16
>> +
>> + dma-channel-mask:
>> + maxItems: 1
>> +
>> + clocks:
>> + maxItems: 1
>> +
>> + resets:
>> + maxItems: 1
>> +
>> + reset-names:
>> + items:
>> + - const: ctrl
>> +
>> + interrupts:
>> + maxItems: 1
>> +
>> + intel,dma-poll-cnt:
>> + $ref: /schemas/types.yaml#definitions/uint32
> Since this was sent, there have been some fixes for JSON pointers and
> this is missing a '/'. The tools now check:
>
> /builds/robherring/linux-dt-bindings/Documentation/devicetree/bindings/dma/intel,ldma.yaml:
> properties:intel,dma-poll-cnt: 'oneOf' conditional failed, one must be
> fixed:
> 'enum' is a required property
> 'const' is a required property
> '/schemas/types.yaml#definitions/uint32' does not match
> 'types.yaml#/definitions/'
>
> Please send a fix for this.
>
> Thanks,
> Rob
next prev parent reply other threads:[~2021-01-15 8:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-16 4:08 [RESEND PATCH v10 0/2] Add Intel LGM SoC DMA support Amireddy Mallikarjuna reddy
2020-12-16 4:08 ` [RESEND PATCH v10 1/2] dt-bindings: dma: Add bindings for Intel LGM SoC Amireddy Mallikarjuna reddy
2021-01-14 20:25 ` Rob Herring
2021-01-15 8:14 ` Reddy, MallikarjunaX [this message]
2020-12-16 4:08 ` [RESEND PATCH v10 2/2] Add Intel LGM SoC DMA support Amireddy Mallikarjuna reddy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b78a503b-2dca-3f5c-050e-b7c92a215842@linux.intel.com \
--to=mallikarjunax.reddy@linux.intel.com \
--cc=andriy.shevchenko@intel.com \
--cc=cheol.yong.kim@intel.com \
--cc=chuanhua.lei@linux.intel.com \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=malliamireddy009@gmail.com \
--cc=peter.ujfalusi@ti.com \
--cc=qi-ming.wu@intel.com \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).