From: Jiri Slaby <jirislaby@kernel.org>
To: Gabriel C <nix.or.die@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
stable <stable@vger.kernel.org>,
lwn@lwn.net, angrypenguinpoland@gmail.com,
Qiujun Huang <hqjagain@gmail.com>,
ath9k-devel@qca.qualcomm.com,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: ath9k broken [was: Linux 5.7.3]
Date: Thu, 25 Jun 2020 06:57:13 +0200 [thread overview]
Message-ID: <b7993e83-1df7-0c93-f6dd-dba9dc10e27a@kernel.org> (raw)
In-Reply-To: <CAEJqkgjV8p6LtBV8YUGbNb0vYzKOQt4-AMAvYw5mzFr3eicyTg@mail.gmail.com>
On 25. 06. 20, 0:05, Gabriel C wrote:
> Am Mi., 17. Juni 2020 um 18:13 Uhr schrieb Greg Kroah-Hartman
> <gregkh@linuxfoundation.org>:
>>
>> I'm announcing the release of the 5.7.3 kernel.
>>
>
> Hello Greg,
>
>> Qiujun Huang (5):
>> ath9k: Fix use-after-free Read in htc_connect_service
>> ath9k: Fix use-after-free Read in ath9k_wmi_ctrl_rx
>> ath9k: Fix use-after-free Write in ath9k_htc_rx_msg
>> ath9x: Fix stack-out-of-bounds Write in ath9k_hif_usb_rx_cb
>> ath9k: Fix general protection fault in ath9k_hif_usb_rx_cb
>>
>
> We got a report on IRC about 5.7.3+ breaking a USB ath9k Wifi Dongle,
> while working fine on <5.7.3.
>
> I don't have myself such HW, and the reported doesn't have any experience
> in bisecting the kernel, so we build kernels, each with one of the
> above commits reverted,
> to find the bad commit.
>
> The winner is:
>
> commit 6602f080cb28745259e2fab1a4cf55eeb5894f93
> Author: Qiujun Huang <hqjagain@gmail.com>
> Date: Sat Apr 4 12:18:38 2020 +0800
>
> ath9k: Fix general protection fault in ath9k_hif_usb_rx_cb
>
> commit 2bbcaaee1fcbd83272e29f31e2bb7e70d8c49e05 upstream.
> ...
>
> Reverting this one fixed his problem.
Obvious question: is 5.8-rc1 (containing the commit) broken too?
I fail to see how the commit could cause an issue like this. Is this
really reproducibly broken with the commit and irreproducible without
it? As it looks like a USB/wiring problem:
usb 1-2: USB disconnect, device number 2
ath: phy0: Reading Magic # failed
ath: phy0: Unable to initialize hardware; initialization status: -5
...
usb 1-2: device descriptor read/64, error -110
usb 1-2: device descriptor read/64, error -71
Ccing ath9k maintainers too.
> I don't have so much info about the HW, besides a dmesg showing the
> phy breaking.
> I also added the reporter to CC too.
>
> https://gist.github.com/AngryPenguinPL/1e545f0da3c2339e443b9e5044fcccea
>
> If you need more info, please let me know and I'll try my best to get
> it as fast as possible for you.
thanks,
--
js
next prev parent reply other threads:[~2020-06-25 4:57 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-17 16:12 Linux 5.7.3 Greg Kroah-Hartman
2020-06-17 16:12 ` Greg Kroah-Hartman
2020-06-24 22:05 ` Gabriel C
2020-06-25 4:57 ` Jiri Slaby [this message]
2020-06-25 10:48 ` ath9k broken [was: Linux 5.7.3] Gabriel C
2020-06-25 10:52 ` Gabriel C
2020-06-26 11:48 ` Gabriel C
2020-06-26 13:39 ` Greg Kroah-Hartman
2020-06-26 13:51 ` Gabriel C
2020-06-26 14:40 ` Gabriel C
2020-07-07 14:11 ` Greg Kroah-Hartman
2020-07-07 20:20 ` Viktor Jägersküpper
2020-07-15 15:13 ` Kalle Valo
2020-07-16 8:15 ` Viktor Jägersküpper
2020-07-16 9:02 ` Kalle Valo
2020-06-27 10:13 ` Roman Mamedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b7993e83-1df7-0c93-f6dd-dba9dc10e27a@kernel.org \
--to=jirislaby@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=angrypenguinpoland@gmail.com \
--cc=ath9k-devel@qca.qualcomm.com \
--cc=gregkh@linuxfoundation.org \
--cc=hqjagain@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lwn@lwn.net \
--cc=nix.or.die@googlemail.com \
--cc=stable@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).