From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F26BC433FE for ; Thu, 17 Nov 2022 13:54:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240251AbiKQNx6 (ORCPT ); Thu, 17 Nov 2022 08:53:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32840 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240223AbiKQNxv (ORCPT ); Thu, 17 Nov 2022 08:53:51 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 487F812AD7 for ; Thu, 17 Nov 2022 05:52:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1668693172; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=O3NFJ14cOnexLb0XvshSqblKsvxT0T4qoUE9znoObQ4=; b=ffLA9WnjBTEN+ETNAAJ5d/niuDgFd/5R+tqcfsW1x3JBk7oWS+9dlMeWArZx7nDOX/RkMg MBVFwA0orHHEA87U6KRZm9yWkZJX6+AAI+hTfz3DSq+Su60kEX0JvAC/iF/tMxHQunXPdH VmWwRqtsEtoCPmk/KTJTfodW586GiFs= Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-547-ExtCr_EmPqql9nggdevoPQ-1; Thu, 17 Nov 2022 08:52:51 -0500 X-MC-Unique: ExtCr_EmPqql9nggdevoPQ-1 Received: by mail-ej1-f71.google.com with SMTP id hb35-20020a170907162300b007ae6746f240so1130865ejc.12 for ; Thu, 17 Nov 2022 05:52:51 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=O3NFJ14cOnexLb0XvshSqblKsvxT0T4qoUE9znoObQ4=; b=WJlkd403tQRStZERAQBqNcuxL6/0iNGCDhijPqVgnjz+j5XSdzaOB0mu67j+snFnFp SW7o6Y7jRFnx1mceI37Fu6j5mnImkv64rMBscqbsqLcwdFAc6rjIdFwMhEV3ZadmkkBt +6yv+ewCD+K5iCtZEXCa5HK7EIUEH0GLS7N0vRtNI46n7aRXfV3ciUe6+BK0AyGB7KfP YD76NyDQ2Xu8xArYXiiuUCPng8T2nwTaYN9bjEkV3h+wkJBQ6AU2PHinrqy3DToEraPM Z0wjfXmH1ZnSNuuzbx+GaLgUurNUUQ0ZGS4HxvFD73P/WOFMtpuQfg4pcVAWjvJZW3WY clPA== X-Gm-Message-State: ANoB5pkjc2UAPMElVhnMIor3Z1V8+dnMIGzQ7+kkUa5bna8eo+bVYn8/ jzUvspd8/kiNwuqooCFZUQc1GwkMSz4tK4K5MlS9bzNwjFkzMaJbofqFD+/FE+Fx/zAUzBOkMuz NKk4EUUBF1rkcxoDjbAtxOyFy X-Received: by 2002:a05:6402:150:b0:468:fdc3:6b44 with SMTP id s16-20020a056402015000b00468fdc36b44mr51407edu.388.1668693170177; Thu, 17 Nov 2022 05:52:50 -0800 (PST) X-Google-Smtp-Source: AA0mqf5Voom2AzZyJRs13uuMx9ot0J31BZ/uqFUlQIAA3yL3In4EkbbyX26sFHXltVhDIB9CMBn2eA== X-Received: by 2002:a05:6402:150:b0:468:fdc3:6b44 with SMTP id s16-20020a056402015000b00468fdc36b44mr51397edu.388.1668693170012; Thu, 17 Nov 2022 05:52:50 -0800 (PST) Received: from ?IPV6:2001:1c00:c1e:bf00:d69d:5353:dba5:ee81? (2001-1c00-0c1e-bf00-d69d-5353-dba5-ee81.cable.dynamic.v6.ziggo.nl. [2001:1c00:c1e:bf00:d69d:5353:dba5:ee81]) by smtp.gmail.com with ESMTPSA id k9-20020a17090632c900b0079e11b8e891sm392717ejk.125.2022.11.17.05.52.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 17 Nov 2022 05:52:49 -0800 (PST) Message-ID: Date: Thu, 17 Nov 2022 14:52:48 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH 7/9] tools/arch/x86: intel_sdsi: Read more On Demand registers Content-Language: en-US, nl To: "David E. Box" , markgross@kernel.org, andriy.shevchenko@linux.intel.com, srinivas.pandruvada@intel.com Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org References: <20221101191023.4150315-1-david.e.box@linux.intel.com> <20221101191023.4150315-8-david.e.box@linux.intel.com> From: Hans de Goede In-Reply-To: <20221101191023.4150315-8-david.e.box@linux.intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 11/1/22 20:10, David E. Box wrote: > Add decoding of the following On Demand register fields: > > 1. NVRAM content authorization error status > 2. Enabled features: telemetry and attestation > 3. Key provisioning status > 4. NVRAM update limit > 5. PCU_CR3_CAPID_CFG > > Link: https://github.com/intel/intel-sdsi/blob/master/state-certificate-encoding.rst > > Signed-off-by: David E. Box Thanks, patch looks good to me: Reviewed-by: Hans de Goede Regards, Hans > --- > tools/arch/x86/intel_sdsi/intel_sdsi.c | 50 +++++++++++++++++++++++--- > 1 file changed, 45 insertions(+), 5 deletions(-) > > diff --git a/tools/arch/x86/intel_sdsi/intel_sdsi.c b/tools/arch/x86/intel_sdsi/intel_sdsi.c > index 3718bd0c05cb..01b5f9994e11 100644 > --- a/tools/arch/x86/intel_sdsi/intel_sdsi.c > +++ b/tools/arch/x86/intel_sdsi/intel_sdsi.c > @@ -44,10 +44,28 @@ > #define __round_mask(x, y) ((__typeof__(x))((y) - 1)) > #define round_up(x, y) ((((x) - 1) | __round_mask(x, y)) + 1) > > +struct nvram_content_auth_err_sts { > + uint64_t reserved:3; > + uint64_t sdsi_content_auth_err:1; > + uint64_t reserved1:1; > + uint64_t sdsi_metering_auth_err:1; > + uint64_t reserved2:58; > +}; > + > struct enabled_features { > uint64_t reserved:3; > uint64_t sdsi:1; > - uint64_t reserved1:60; > + uint64_t reserved1:8; > + uint64_t attestation:1; > + uint64_t reserved2:13; > + uint64_t metering:1; > + uint64_t reserved3:37; > +}; > + > +struct key_provision_status { > + uint64_t reserved:1; > + uint64_t license_key_provisioned:1; > + uint64_t reserved2:62; > }; > > struct auth_fail_count { > @@ -65,15 +83,23 @@ struct availability { > uint64_t reserved2:10; > }; > > +struct nvram_update_limit { > + uint64_t reserved:12; > + uint64_t sdsi_50_pct:1; > + uint64_t sdsi_75_pct:1; > + uint64_t sdsi_90_pct:1; > + uint64_t reserved2:49; > +}; > + > struct sdsi_regs { > uint64_t ppin; > - uint64_t reserved; > + struct nvram_content_auth_err_sts auth_err_sts; > struct enabled_features en_features; > - uint64_t reserved1; > + struct key_provision_status key_prov_sts; > struct auth_fail_count auth_fail_count; > struct availability prov_avail; > - uint64_t reserved2; > - uint64_t reserved3; > + struct nvram_update_limit limits; > + uint64_t pcu_cr3_capid_cfg; > uint64_t socket_id; > }; > > @@ -205,8 +231,18 @@ static int sdsi_read_reg(struct sdsi_dev *s) > printf("Socket information for device %s\n", s->dev_name); > printf("\n"); > printf("PPIN: 0x%lx\n", s->regs.ppin); > + printf("NVRAM Content Authorization Error Status\n"); > + printf(" SDSi Auth Err Sts: %s\n", !!s->regs.auth_err_sts.sdsi_content_auth_err ? "Error" : "Okay"); > + > + if (!!s->regs.en_features.metering) > + printf(" Metering Auth Err Sts: %s\n", !!s->regs.auth_err_sts.sdsi_metering_auth_err ? "Error" : "Okay"); > + > printf("Enabled Features\n"); > printf(" On Demand: %s\n", !!s->regs.en_features.sdsi ? "Enabled" : "Disabled"); > + printf(" Attestation: %s\n", !!s->regs.en_features.attestation ? "Enabled" : "Disabled"); > + printf(" On Demand: %s\n", !!s->regs.en_features.sdsi ? "Enabled" : "Disabled"); > + printf(" Metering: %s\n", !!s->regs.en_features.metering ? "Enabled" : "Disabled"); > + printf("License Key (AKC) Provisioned: %s\n", !!s->regs.key_prov_sts.license_key_provisioned ? "Yes" : "No"); > printf("Authorization Failure Count\n"); > printf(" AKC Failure Count: %d\n", s->regs.auth_fail_count.key_failure_count); > printf(" AKC Failure Threshold: %d\n", s->regs.auth_fail_count.key_failure_threshold); > @@ -215,6 +251,10 @@ static int sdsi_read_reg(struct sdsi_dev *s) > printf("Provisioning Availability\n"); > printf(" Updates Available: %d\n", s->regs.prov_avail.available); > printf(" Updates Threshold: %d\n", s->regs.prov_avail.threshold); > + printf("NVRAM Udate Limit\n"); > + printf(" 50%% Limit Reached: %s\n", !!s->regs.limits.sdsi_50_pct ? "Yes" : "No"); > + printf(" 75%% Limit Reached: %s\n", !!s->regs.limits.sdsi_75_pct ? "Yes" : "No"); > + printf(" 90%% Limit Reached: %s\n", !!s->regs.limits.sdsi_90_pct ? "Yes" : "No"); > printf("Socket ID: %ld\n", s->regs.socket_id & 0xF); > > return 0;