From: Robin Murphy <robin.murphy@arm.com>
To: Jeffy Chen <jeffy.chen@rock-chips.com>, linux-kernel@vger.kernel.org
Cc: jcliang@chromium.org, xxm@rock-chips.com, tfiga@chromium.org,
devicetree@vger.kernel.org, Heiko Stuebner <heiko@sntech.de>,
linux-rockchip@lists.infradead.org,
iommu@lists.linux-foundation.org,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Joerg Roedel <joro@8bytes.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v7 09/14] dt-bindings: iommu/rockchip: Add clock property
Date: Wed, 7 Mar 2018 13:01:37 +0000 [thread overview]
Message-ID: <b7b58e44-82d5-4f7d-5f49-69f8d1a93279@arm.com> (raw)
In-Reply-To: <20180306032113.22247-6-jeffy.chen@rock-chips.com>
On 06/03/18 03:21, Jeffy Chen wrote:
> Add clock property, since we are going to control clocks in rockchip
> iommu driver.
Reviewed-by: Robin Murphy <robin.murphy@arm.com>
> Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
> Reviewed-by: Rob Herring <robh@kernel.org>
> ---
>
> Changes in v7: None
> Changes in v6:
> Fix dt-binding as Robin suggested.
> Use aclk and iface clk as Rob and Robin suggested, and split binding
> patch.
>
> Changes in v5: None
> Changes in v4: None
> Changes in v3: None
> Changes in v2: None
>
> Documentation/devicetree/bindings/iommu/rockchip,iommu.txt | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/iommu/rockchip,iommu.txt b/Documentation/devicetree/bindings/iommu/rockchip,iommu.txt
> index 2098f7732264..6ecefea1c6f9 100644
> --- a/Documentation/devicetree/bindings/iommu/rockchip,iommu.txt
> +++ b/Documentation/devicetree/bindings/iommu/rockchip,iommu.txt
> @@ -14,6 +14,11 @@ Required properties:
> "single-master" device, and needs no additional information
> to associate with its master device. See:
> Documentation/devicetree/bindings/iommu/iommu.txt
> +- clocks : A list of clocks required for the IOMMU to be accessible by
> + the host CPU.
> +- clock-names : Should contain the following:
> + "iface" - Main peripheral bus clock (PCLK/HCL) (required)
> + "aclk" - AXI bus clock (required)
>
> Optional properties:
> - rockchip,disable-mmu-reset : Don't use the mmu reset operation.
> @@ -27,5 +32,7 @@ Example:
> reg = <0xff940300 0x100>;
> interrupts = <GIC_SPI 16 IRQ_TYPE_LEVEL_HIGH>;
> interrupt-names = "vopl_mmu";
> + clocks = <&cru ACLK_VOP1>, <&cru HCLK_VOP1>;
> + clock-names = "aclk", "iface";
> #iommu-cells = <0>;
> };
>
next prev parent reply other threads:[~2018-03-07 13:01 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-06 3:02 [PATCH v7 00/14] iommu/rockchip: Use OF_IOMMU Jeffy Chen
2018-03-06 3:02 ` [PATCH v7 01/14] iommu/rockchip: Prohibit unbind and remove Jeffy Chen
2018-03-07 12:55 ` Robin Murphy
2018-03-06 3:02 ` [PATCH v7 02/14] iommu/rockchip: Fix error handling in probe Jeffy Chen
2018-03-07 12:59 ` Robin Murphy
2018-03-06 3:02 ` [PATCH v7 03/14] iommu/rockchip: Request irqs in rk_iommu_probe() Jeffy Chen
2018-03-07 13:00 ` Robin Murphy
2018-03-06 3:21 ` [PATCH v7 04/14] iommu/rockchip: Fix error handling in attach Jeffy Chen
2018-03-06 3:21 ` [PATCH v7 05/14] iommu/rockchip: Use iopoll helpers to wait for hardware Jeffy Chen
2018-03-06 3:21 ` [PATCH v7 06/14] iommu/rockchip: Fix TLB flush of secondary IOMMUs Jeffy Chen
2018-03-06 3:21 ` [PATCH v7 07/14] ARM: dts: rockchip: add clocks in iommu nodes Jeffy Chen
2018-03-06 3:21 ` [PATCH v7 08/14] iommu/rockchip: Control clocks needed to access the IOMMU Jeffy Chen
2018-03-06 3:21 ` [PATCH v7 09/14] dt-bindings: iommu/rockchip: Add clock property Jeffy Chen
2018-03-07 13:01 ` Robin Murphy [this message]
2018-03-06 3:27 ` [PATCH v7 10/14] iommu/rockchip: Use IOMMU device for dma mapping operations Jeffy Chen
2018-03-06 3:27 ` [PATCH v7 11/14] iommu/rockchip: Use OF_IOMMU to attach devices automatically Jeffy Chen
2018-03-06 3:27 ` [PATCH v7 12/14] iommu/rockchip: Fix error handling in init Jeffy Chen
2018-03-06 3:27 ` [PATCH v7 13/14] iommu/rockchip: Add runtime PM support Jeffy Chen
2018-03-06 10:07 ` Tomasz Figa
2018-03-07 3:24 ` Tomasz Figa
[not found] ` <5A9F598E.4020704@rock-chips.com>
2018-03-07 3:26 ` Tomasz Figa
2018-03-06 3:27 ` [PATCH v7 14/14] iommu/rockchip: Support sharing IOMMU between masters Jeffy Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b7b58e44-82d5-4f7d-5f49-69f8d1a93279@arm.com \
--to=robin.murphy@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=iommu@lists.linux-foundation.org \
--cc=jcliang@chromium.org \
--cc=jeffy.chen@rock-chips.com \
--cc=joro@8bytes.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=tfiga@chromium.org \
--cc=xxm@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).