From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1614BC433E9 for ; Fri, 12 Mar 2021 20:56:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D4EE564FA9 for ; Fri, 12 Mar 2021 20:56:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235085AbhCLUz6 (ORCPT ); Fri, 12 Mar 2021 15:55:58 -0500 Received: from ale.deltatee.com ([204.191.154.188]:46738 "EHLO ale.deltatee.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235009AbhCLUzg (ORCPT ); Fri, 12 Mar 2021 15:55:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=deltatee.com; s=20200525; h=Subject:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:content-disposition; bh=CGrXx6tnunS4rU4vJV260ajUW0JSem+Dld3wlshcr6w=; b=BDbN0bC7mvuP4MZ4/ukk0LJPNY DPviP0ZYyTMeFAwbu8j5dMB7b2KzG2FZ7qIkKt0NUgGiAf1lt0M1PYF+gfW9IiRlBWt46STFG4T8J cZYMNg2vCeXa+Q8UWw2v2fJVgGu+2rbQWfbc9Xj5/D0yUfdNA2Z63WK6JaJHzMzVN8MTGlNX/GGyd Q6TBybdzp+x5Va6pP4OJcp8RqQl1vJGjI19FBAYa1GlCi7QLe7TtG8cifa5LNRoBCRtHYgdC61UIV 8pOHhROLuEdapKBxAr35W/geKRPGeu8OGDWP2al0JqcX1wjdqdeNjhR6T4IFhrJ7RbKjOU1kMSY/G DjXl5YXA==; Received: from s01060023bee90a7d.cg.shawcable.net ([24.64.145.4] helo=[192.168.0.10]) by ale.deltatee.com with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lKon3-0002ZN-Ku; Fri, 12 Mar 2021 13:53:46 -0700 To: Bjorn Helgaas Cc: linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, linux-block@vger.kernel.org, linux-pci@vger.kernel.org, linux-mm@kvack.org, iommu@lists.linux-foundation.org, Stephen Bates , Christoph Hellwig , Dan Williams , Jason Gunthorpe , =?UTF-8?Q?Christian_K=c3=b6nig?= , Ira Weiny , John Hubbard , Don Dutile , Matthew Wilcox , Daniel Vetter , Jakowski Andrzej , Minturn Dave B , Jason Ekstrand , Dave Hansen , Xiong Jianxin References: <20210312203936.GA2286981@bjorn-Precision-5520> From: Logan Gunthorpe Message-ID: Date: Fri, 12 Mar 2021 13:53:42 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210312203936.GA2286981@bjorn-Precision-5520> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 24.64.145.4 X-SA-Exim-Rcpt-To: jianxin.xiong@intel.com, dave.hansen@linux.intel.com, jason@jlekstrand.net, dave.b.minturn@intel.com, andrzej.jakowski@intel.com, daniel.vetter@ffwll.ch, willy@infradead.org, ddutile@redhat.com, jhubbard@nvidia.com, iweiny@intel.com, christian.koenig@amd.com, jgg@ziepe.ca, dan.j.williams@intel.com, hch@lst.de, sbates@raithlin.com, iommu@lists.linux-foundation.org, linux-mm@kvack.org, linux-pci@vger.kernel.org, linux-block@vger.kernel.org, linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, helgaas@kernel.org X-SA-Exim-Mail-From: logang@deltatee.com Subject: Re: [RFC PATCH v2 01/11] PCI/P2PDMA: Pass gfp_mask flags to upstream_bridge_distance_warn() X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on ale.deltatee.com) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021-03-12 1:39 p.m., Bjorn Helgaas wrote: > On Thu, Mar 11, 2021 at 04:31:31PM -0700, Logan Gunthorpe wrote: >> In order to call this function from a dma_map function, it must not sleep. >> The only reason it does sleep so to allocate the seqbuf to print >> which devices are within the ACS path. > > s/this function/upstream_bridge_distance_warn()/ ? > s/so to/is to/ > > Maybe the subject could say something about the purpose, e.g., allow > calling from atomic context or something? "Pass gfp_mask flags" sort > of restates what we can read from the patch, but without the > motivation of why this is useful. > >> Switch the kmalloc call to use a passed in gfp_mask and don't print that >> message if the buffer fails to be allocated. >> >> Signed-off-by: Logan Gunthorpe > > Acked-by: Bjorn Helgaas Thanks! I'll apply these changes for any future postings. Logan