From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6A3DC352A4 for ; Mon, 10 Feb 2020 07:30:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9FBE5214DB for ; Mon, 10 Feb 2020 07:30:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727079AbgBJHaH (ORCPT ); Mon, 10 Feb 2020 02:30:07 -0500 Received: from kernel.crashing.org ([76.164.61.194]:54246 "EHLO kernel.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726061AbgBJHaH (ORCPT ); Mon, 10 Feb 2020 02:30:07 -0500 Received: from localhost (gate.crashing.org [63.228.1.57]) (authenticated bits=0) by kernel.crashing.org (8.14.7/8.14.7) with ESMTP id 01A7TN4p010982 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Mon, 10 Feb 2020 01:29:29 -0600 Message-ID: Subject: Re: [PATCH 2/3] usb: gadget: aspeed: add ast2600 vhub support From: Benjamin Herrenschmidt To: Joel Stanley , Tao Ren Cc: Felipe Balbi , Greg Kroah-Hartman , Andrew Jeffery , Chunfeng Yun , Colin Ian King , Stephen Boyd , Rob Herring , Mark Rutland , linux-usb@vger.kernel.org, Linux ARM , linux-aspeed , devicetree , Linux Kernel Mailing List , OpenBMC Maillist Date: Mon, 10 Feb 2020 08:29:22 +0100 In-Reply-To: References: <20200131222157.20849-1-rentao.bupt@gmail.com> <20200131222157.20849-3-rentao.bupt@gmail.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2020-02-10 at 02:48 +0000, Joel Stanley wrote: > On Fri, 31 Jan 2020 at 22:22, wrote: > > > > From: Tao Ren > > > > Add AST2600 support in aspeed-vhub driver. There are 3 major differences > > between AST2500 and AST2600 vhub: > > - AST2600 supports 7 downstream ports while AST2500 supports 5. > > - AST2600 supports 21 generic endpoints while AST2500 supports 15. > > - EP0 data buffer's 8-byte DMA alignment restriction is removed from > > AST2600. > > > > Signed-off-by: Tao Ren > > Reviewed-by: Andrew Jeffery Travelling at the moment so my review might be a bit delayed. Also for some reason I missed your original submission, sorry about that, please poke me next time if I don't reply within a couple of days ! One thing to look into as well is the 2600 has revived the "device controller" which looks like a cut down version of a vhub device, so we should break a bit more the linkage between vhub and the underlying devices so the latter can be instanciated standalone... (Foor for thought, I'm not asking you to do that right now) Cheers, Ben. > Reviewed-by: Joel Stanley > > > --- > > drivers/usb/gadget/udc/aspeed-vhub/Kconfig | 4 ++-- > > drivers/usb/gadget/udc/aspeed-vhub/core.c | 9 +++++++++ > > 2 files changed, 11 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/usb/gadget/udc/aspeed-vhub/Kconfig b/drivers/usb/gadget/udc/aspeed-vhub/Kconfig > > index 83ba8a2eb6af..605500b19cf3 100644 > > --- a/drivers/usb/gadget/udc/aspeed-vhub/Kconfig > > +++ b/drivers/usb/gadget/udc/aspeed-vhub/Kconfig > > @@ -4,5 +4,5 @@ config USB_ASPEED_VHUB > > depends on ARCH_ASPEED || COMPILE_TEST > > depends on USB_LIBCOMPOSITE > > help > > - USB peripheral controller for the Aspeed AST2500 family > > - SoCs supporting the "vHub" functionality and USB2.0 > > + USB peripheral controller for the Aspeed AST2400, AST2500 and > > + AST2600 family SoCs supporting the "vHub" functionality and USB2.0 > > diff --git a/drivers/usb/gadget/udc/aspeed-vhub/core.c b/drivers/usb/gadget/udc/aspeed-vhub/core.c > > index 94081cc04113..c827bf420278 100644 > > --- a/drivers/usb/gadget/udc/aspeed-vhub/core.c > > +++ b/drivers/usb/gadget/udc/aspeed-vhub/core.c > > @@ -42,6 +42,11 @@ static const struct ast_vhub_config ast2400_config = { > > .max_epns = 15, > > }; > > > > +static const struct ast_vhub_config ast2600_config = { > > + .max_ports = 7, > > + .max_epns = 21, > > +}; > > + > > static const struct of_device_id ast_vhub_dt_ids[] = { > > { > > .compatible = "aspeed,ast2400-usb-vhub", > > @@ -51,6 +56,10 @@ static const struct of_device_id ast_vhub_dt_ids[] = { > > .compatible = "aspeed,ast2500-usb-vhub", > > .data = &ast2400_config, > > }, > > + { > > + .compatible = "aspeed,ast2600-usb-vhub", > > + .data = &ast2600_config, > > + }, > > { } > > }; > > MODULE_DEVICE_TABLE(of, ast_vhub_dt_ids); > > -- > > 2.17.1 > >