From: Robin Murphy <robin.murphy@arm.com>
To: Masahiro Yamada <yamada.masahiro@socionext.com>,
dmaengine@vger.kernel.org,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Cc: Russell King - ARM Linux <linux@arm.linux.org.uk>,
Arnd Bergmann <arnd@arndb.de>,
masahiroy@kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
Tejun Heo <tj@kernel.org>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [Question] devm_kmalloc() for DMA ?
Date: Wed, 8 Mar 2017 11:15:39 +0000 [thread overview]
Message-ID: <b7dd01e6-ddcd-a34a-c26c-05ce6ae4015a@arm.com> (raw)
In-Reply-To: <CAK7LNARbD262isY7yOgQKAcbWQHV+3dsoRjtu6S+qUpPr98qSQ@mail.gmail.com>
On 08/03/17 10:59, Masahiro Yamada wrote:
> Hi experts,
>
> I have a question about
> how to allocate DMA-safe buffer.
>
>
> In my understanding, kmalloc() returns
> memory with DMA safe alignment
> in order to avoid cache-sharing problem when used for DMA.
>
> The alignment is decided by ARCH_DMA_MINALIGN.
> For example, on modern ARM 32bit boards, this value is typically 64.
> So, memory returned by kmalloc() has
> at least 64 byte alignment.
>
>
> On the other hand, devm_kmalloc() does not return
> enough-aligned memory.
How so? If anything returned by kmalloc() is guaranteed to occupy some
multiple of ARCH_DMA_MINALIGN bytes in order to avoid two allocations
falling into the same cache line, I don't see how stealing the first 16
bytes *of a single allocation* could make it start sharing cache lines
with another? :/
If a particular device has a problem with:
p = kmalloc(...);
d = dma_map_single(p + 0x10, ...);
do_something_with(d);
that's a separate issue altogether.
Robin.
> On my board (ARM 32bit), devm_kmalloc() returns
> (ARCH_DMA_MINALIGN aligned address) + 0x10.
>
>
>
> The reason of the offset 0x10 is obvious.
>
> struct devres {
> struct devres_node node;
> /* -- 3 pointers */
> unsigned long long data[]; /* guarantee ull alignment */
> };
>
>
> Management data is located at the top of struct devres.
> Then, devm_kmalloc() returns dr->data.
>
> The "unsigned long long" guarantees
> the returned memory has 0x10 alignment,
> but I think this may not be enough for DMA.
>
> I noticed this when I was seeing drivers/mtd/nand/denali.c
>
> The code looks as follows:
>
>
> denali->buf.buf = devm_kzalloc(denali->dev,
> mtd->writesize + mtd->oobsize,
> GFP_KERNEL);
> if (!denali->buf.buf) {
> ret = -ENOMEM;
> goto failed_req_irq;
> }
>
> /* Is 32-bit DMA supported? */
> ret = dma_set_mask(denali->dev, DMA_BIT_MASK(32));
> if (ret) {
> dev_err(denali->dev, "No usable DMA configuration\n");
> goto failed_req_irq;
> }
>
> denali->buf.dma_buf = dma_map_single(denali->dev, denali->buf.buf,
> mtd->writesize + mtd->oobsize,
> DMA_BIDIRECTIONAL);
>
>
>
>
> Memory buffer is allocated by devm_kzalloc(), then
> passed to dma_map_single().
>
>
>
> Could this be a potential problem in general?
>
> Is devm_kmalloc() not recommended
> for buffer that can be DMA-mapped?
>
>
> Any advice is appreciated.
>
>
next prev parent reply other threads:[~2017-03-08 11:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-08 10:59 [Question] devm_kmalloc() for DMA ? Masahiro Yamada
2017-03-08 11:15 ` Robin Murphy [this message]
2017-03-08 18:06 ` Masahiro Yamada
2017-03-08 19:48 ` Lars-Peter Clausen
2017-03-08 19:59 ` Russell King - ARM Linux
2017-03-08 20:44 ` Lars-Peter Clausen
2017-03-08 21:19 ` Russell King - ARM Linux
2017-03-08 21:33 ` Lars-Peter Clausen
2017-03-09 3:25 ` Masahiro Yamada
2017-03-09 9:20 ` Russell King - ARM Linux
2017-03-09 11:19 ` Robin Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b7dd01e6-ddcd-a34a-c26c-05ce6ae4015a@arm.com \
--to=robin.murphy@arm.com \
--cc=James.Bottomley@hansenpartnership.com \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=dmaengine@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=masahiroy@kernel.org \
--cc=tj@kernel.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).