From: Vignesh R <vigneshr@ti.com>
To: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc: Tony Lindgren <tony@atomide.com>,
Rob Herring <robh+dt@kernel.org>,
KISHON VIJAY ABRAHAM <kishon@ti.com>,
Bjorn Helgaas <bhelgaas@google.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>
Subject: Re: [PATCH v2 2/4] pci: dwc: pci-dra7xx: Enable errata i870 for both EP and RC mode
Date: Thu, 19 Jul 2018 16:04:34 +0530 [thread overview]
Message-ID: <b7f1cef7-b0d8-733a-c450-163299d281d0@ti.com> (raw)
In-Reply-To: <20180718110250.GA21589@red-moon>
Hi Lorenzo,
On Wednesday 18 July 2018 04:32 PM, Lorenzo Pieralisi wrote:
> On Wed, Jun 27, 2018 at 05:59:17PM +0530, Vignesh R wrote:
>> Errata i870 is applicable in both EP and RC mode. Therefore rename
>> function dra7xx_pcie_ep_unaligned_memaccess(), that implements errata
>> workaround, to dra7xx_pcie_unaligned_memaccess() and call it from a
>> common place. So, that errata workaround is applied for both modes of
>> operation.
>>
>> Reported-by: Chris Welch <Chris.Welch@viavisolutions.com>
>> Signed-off-by: Vignesh R <vigneshr@ti.com>
>> ---
>> drivers/pci/controller/dwc/pci-dra7xx.c | 12 ++++++------
>> 1 file changed, 6 insertions(+), 6 deletions(-)
>>
>> diff --git a/drivers/pci/controller/dwc/pci-dra7xx.c b/drivers/pci/controller/dwc/pci-dra7xx.c
>> index 345aab56ce8b..95d9076e3fde 100644
>> --- a/drivers/pci/controller/dwc/pci-dra7xx.c
>> +++ b/drivers/pci/controller/dwc/pci-dra7xx.c
>> @@ -542,7 +542,7 @@ static const struct of_device_id of_dra7xx_pcie_match[] = {
>> };
>>
>> /*
>> - * dra7xx_pcie_ep_unaligned_memaccess: workaround for AM572x/AM571x Errata i870
>> + * dra7xx_pcie_unaligned_memaccess: workaround for AM572x/AM571x Errata i870
>> * @dra7xx: the dra7xx device where the workaround should be applied
>> *
>> * Access to the PCIe slave port that are not 32-bit aligned will result
>> @@ -552,7 +552,7 @@ static const struct of_device_id of_dra7xx_pcie_match[] = {
>> *
>> * To avoid this issue set PCIE_SS1_AXI2OCP_LEGACY_MODE_ENABLE to 1.
>> */
>> -static int dra7xx_pcie_ep_unaligned_memaccess(struct device *dev)
>> +static int dra7xx_pcie_unaligned_memaccess(struct device *dev)
>> {
>> int ret;
>> struct device_node *np = dev->of_node;
>> @@ -695,6 +695,10 @@ static int __init dra7xx_pcie_probe(struct platform_device *pdev)
>> if (dra7xx->link_gen < 0 || dra7xx->link_gen > 2)
>> dra7xx->link_gen = 2;
>>
>> + ret = dra7xx_pcie_unaligned_memaccess(dev);
>> + if (ret)
>> + dev_err(dev, "WA for Errata i870 not appplied. Update DT\n");
>
> Hi Vignesh,
>
> Nit: s/appplied/applied
>
Oops, let me know if you want me to resend with this fixed.
> Two questions:
>
> - Current code applies the unaligned_memaccess() workaround for all
> compatible variants. This is fine for current controllers (since
> they are all affected), the code path above will have to be
> reworked if there is any other compatible IP re-using the driver
> that does not require the workaround.
There are no compatible IPs that don't require this workaround. Also, I
don't see this IP being re-used in future. If you insist, I can add a
errata flag
> - How do you want this series to go upstream ? If it goes via arm-soc,
> which I think it should, here is my ACK on this patch:
>
Patch 1 and 2(dt bindings update and driver patch) can go in via PCI
tree. And DT changes(patch 3 and 4) can be picked up by Tony via
omap/arm-soc tree. They are mostly independent and should not cause any
problems. Does that sound good?
> Acked-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
>
Thanks!
> Please let me know if I can drop this series from the PCI patchwork.
>
> Thanks,
> Lorenzo
>
>> +
>> switch (mode) {
>> case DW_PCIE_RC_TYPE:
>> if (!IS_ENABLED(CONFIG_PCI_DRA7XX_HOST)) {
>> @@ -717,10 +721,6 @@ static int __init dra7xx_pcie_probe(struct platform_device *pdev)
>> dra7xx_pcie_writel(dra7xx, PCIECTRL_TI_CONF_DEVICE_TYPE,
>> DEVICE_TYPE_EP);
>>
>> - ret = dra7xx_pcie_ep_unaligned_memaccess(dev);
>> - if (ret)
>> - goto err_gpio;
>> -
>> ret = dra7xx_add_pcie_ep(dra7xx, pdev);
>> if (ret < 0)
>> goto err_gpio;
>> --
>> 2.18.0
>>
--
Regards
Vignesh
next prev parent reply other threads:[~2018-07-19 10:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-27 12:29 [PATCH v2 0/4] pci-dra7xx: Enable errata i870 workaround for RC mode Vignesh R
2018-06-27 12:29 ` [PATCH v2 1/4] dt-bindings: PCI: dra7xx: Add bindings for unaligned access in host mode Vignesh R
2018-06-27 12:29 ` [PATCH v2 2/4] pci: dwc: pci-dra7xx: Enable errata i870 for both EP and RC mode Vignesh R
2018-07-17 9:54 ` Kishon Vijay Abraham I
2018-07-18 11:02 ` Lorenzo Pieralisi
2018-07-19 10:34 ` Vignesh R [this message]
2018-07-19 11:15 ` Lorenzo Pieralisi
2018-07-19 15:59 ` Vignesh R
2018-06-27 12:29 ` [PATCH v2 3/4] ARM: dts: dra7: Enable workaround for errata i870 in PCIe host mode Vignesh R
2018-06-27 12:29 ` [PATCH v2 4/4] ARM: dts: dra7: Fix up unaligned access setting for PCIe EP Vignesh R
2018-07-17 9:55 ` Kishon Vijay Abraham I
2018-07-19 10:54 ` Vignesh R
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b7f1cef7-b0d8-733a-c450-163299d281d0@ti.com \
--to=vigneshr@ti.com \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=robh+dt@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).