From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1826C433EF for ; Sat, 25 Jun 2022 16:59:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233152AbiFYQ7e (ORCPT ); Sat, 25 Jun 2022 12:59:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38488 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229906AbiFYQ7d (ORCPT ); Sat, 25 Jun 2022 12:59:33 -0400 Received: from mail-pf1-x431.google.com (mail-pf1-x431.google.com [IPv6:2607:f8b0:4864:20::431]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 112DD1581E for ; Sat, 25 Jun 2022 09:59:32 -0700 (PDT) Received: by mail-pf1-x431.google.com with SMTP id x4so5250846pfq.2 for ; Sat, 25 Jun 2022 09:59:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=5n9b9moDbqljRj9kvQX7qhYgh+0pii4Py2IK3zMO58Q=; b=XzvRzakJXRYQZX8QkrA/Kx1xy/ONHkwgjIDx+O97k9TCTw5f/MOi0SXpPjcuyE+kxy 5hb86vs53b8scNOxGfcI7pI3IF0/LkYuST7RE8t5lBJKROuzRpYQMLotGwr2V6fdEbyA jIq8stNOA1QFaXrFSF3s8ZH6Oy62qavozYlLG/AWa9eC7tXL+JLyniRrLyeNDaCtR4bS zG4g2pt8irHqzlshE6jnj+Y0tnySEGeInGoB1Q5JiUBB0z7PEvhPzYsUoEfj0d7gFiBZ blZLwcbZqQdjSp11YdOv9fsXX4+9EWg87qn5ihiY4L+teS/INZnVhP9gou5ApPzQxR0j i7Gw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=5n9b9moDbqljRj9kvQX7qhYgh+0pii4Py2IK3zMO58Q=; b=hZ5lUOw3hZ+1X4QRXKB/GlYO/MN1YXVE0yneR9zWXKN6/2hZaZIreKGAY7oGWRP6G8 gWgFKQsf6ugvQE7x1hDHrwXwmPzb0KHVfIqmqS8O1tH557W9T/WuIY9EZZcZiv0ymSY/ D8Iecl8C3RlgJT+Kj4Mm6omgTBFTsxFXhzfdPoBAXw6HpYk+gATS/eRVKC7+xMhu4UIo b1A1LRMt/8xWLkEi+aPMfT4ut91NNCJ2Ba1ZqEZokzpuHMMOtSVXrOBW03s+VKcgtfd7 /fzdmg+TtdcJ3yTqRA/b7xiKCAvHSbA40GksXndm9EACeW0M1f6VjpjAUWA6NNb0/ict AJVw== X-Gm-Message-State: AJIora/WuHvEmJVAzccu+ayPSyKWKpdAqShJx/ysik3ERE/6VE4LSfO4 0+nBQRcE9fxQg4EtbQXktbjIqw== X-Google-Smtp-Source: AGRyM1vJ4KevW8A3IUQjaIW2xTcG2zotUtlZLa90K5/1vUOKScWXZ9L2XVgPTwxHhN+H2sw1h5dwgQ== X-Received: by 2002:a63:6b08:0:b0:3fd:1b8e:3932 with SMTP id g8-20020a636b08000000b003fd1b8e3932mr4345566pgc.552.1656176371452; Sat, 25 Jun 2022 09:59:31 -0700 (PDT) Received: from [192.168.1.100] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id bu5-20020a056a00410500b0052521fd6caesm3835774pfb.111.2022.06.25.09.59.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 25 Jun 2022 09:59:30 -0700 (PDT) Message-ID: Date: Sat, 25 Jun 2022 10:59:29 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH] lib/sbitmap: Fix invalid loop in __sbitmap_queue_get_batch() Content-Language: en-US To: wuchi , mwilck@suse.com, andriy.shevchenko@linux.intel.com Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220605145835.26916-1-wuchi.zero@gmail.com> From: Jens Axboe In-Reply-To: <20220605145835.26916-1-wuchi.zero@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/5/22 8:58 AM, wuchi wrote: > 1. Getting next index before continue branch. > 2. Checking free bits when setting the target bits. Otherwise, > it may reuse the busying bits. Applied with: Fixes: 9672b0d43782 ("sbitmap: add __sbitmap_queue_get_batch()") added as well. -- Jens Axboe