From: Hans Verkuil <hverkuil@xs4all.nl>
To: Sakari Ailus <sakari.ailus@iki.fi>,
SF Markus Elfring <elfring@users.sourceforge.net>
Cc: linux-media@vger.kernel.org,
Dave Hansen <dave.hansen@linux.intel.com>,
Jan Kara <jack@suse.cz>,
Javier Martinez Canillas <javier@osg.samsung.com>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Lorenzo Stoakes <lstoakes@gmail.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Michal Hocko <mhocko@suse.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 0/8] [media] v4l2-core: Fine-tuning for some function implementations
Date: Mon, 2 Jan 2017 15:54:21 +0100 [thread overview]
Message-ID: <b804f4dd-392e-ae8e-41de-a02260fef550@xs4all.nl> (raw)
In-Reply-To: <20161227115111.GN16630@valkosipuli.retiisi.org.uk>
On 12/27/16 12:51, Sakari Ailus wrote:
> Hi Markus,
>
> On Mon, Dec 26, 2016 at 09:41:19PM +0100, SF Markus Elfring wrote:
>> From: Markus Elfring <elfring@users.sourceforge.net>
>> Date: Mon, 26 Dec 2016 21:30:12 +0100
>>
>> Some update suggestions were taken into account
>> from static source code analysis.
>>
>> Markus Elfring (8):
>> v4l2-async: Use kmalloc_array() in v4l2_async_notifier_unregister()
>> v4l2-async: Delete an error message for a failed memory allocation in v4l2_async_notifier_unregister()
>> videobuf-dma-sg: Use kmalloc_array() in videobuf_dma_init_user_locked()
>> videobuf-dma-sg: Adjust 24 checks for null values
>> videobuf-dma-sg: Move two assignments for error codes in __videobuf_mmap_mapper()
>> videobuf-dma-sg: Improve a size determination in __videobuf_mmap_mapper()
>> videobuf-dma-sg: Delete an unnecessary return statement in videobuf_vm_close()
>> videobuf-dma-sg: Add some spaces for better code readability in videobuf_dma_init_user_locked()
>
> I don't really disagree with the videobuf changes as such --- the original
> code sure seems quite odd, but I wonder whether we want to do this kind of
> cleanups in videobuf. Videobuf will be removed likely in not too distant
> future; when exactly, Hans can guesstimate better than me. Cc him.
>
The videobuf code is frozen as far as I am concerned, and I won't pick up
these cleanup patches. While they look perfectly reasonable, I don't want
to risk any breakage there. The last thing I want to do is to have to debug
in the videobuf code.
Sorry Markus, just stay away from the videobuf-* sources.
Regards,
Hans
next prev parent reply other threads:[~2017-01-02 14:54 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-26 20:41 [PATCH 0/8] [media] v4l2-core: Fine-tuning for some function implementations SF Markus Elfring
2016-12-26 20:43 ` [PATCH 1/8] [media] v4l2-async: Use kmalloc_array() in v4l2_async_notifier_unregister() SF Markus Elfring
2016-12-27 9:52 ` Sakari Ailus
2016-12-26 20:45 ` [PATCH 2/8] [media] v4l2-async: Delete an error message for a failed memory allocation " SF Markus Elfring
2016-12-27 11:47 ` Sakari Ailus
2017-01-31 9:55 ` Mauro Carvalho Chehab
2016-12-26 20:47 ` [PATCH 3/8] [media] videobuf-dma-sg: Use kmalloc_array() in videobuf_dma_init_user_locked() SF Markus Elfring
2016-12-26 20:48 ` [PATCH 4/8] [media] videobuf-dma-sg: Adjust 24 checks for null values SF Markus Elfring
2017-01-09 10:30 ` Dan Carpenter
2016-12-26 20:50 ` [PATCH 5/8] [media] videobuf-dma-sg: Move two assignments for error codes in __videobuf_mmap_mapper() SF Markus Elfring
2016-12-26 20:51 ` [PATCH 6/8] [media] videobuf-dma-sg: Improve a size determination " SF Markus Elfring
2016-12-26 20:52 ` [PATCH 7/8] [media] videobuf-dma-sg: Delete an unnecessary return statement in videobuf_vm_close() SF Markus Elfring
2016-12-26 20:53 ` [PATCH 8/8] [media] videobuf-dma-sg: Add some spaces for better code readability in videobuf_dma_init_user_locked() SF Markus Elfring
2016-12-27 11:51 ` [PATCH 0/8] [media] v4l2-core: Fine-tuning for some function implementations Sakari Ailus
2017-01-02 14:54 ` Hans Verkuil [this message]
2017-09-22 20:08 ` SF Markus Elfring
2017-09-23 7:35 ` Hans Verkuil
2017-09-23 15:27 ` SF Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b804f4dd-392e-ae8e-41de-a02260fef550@xs4all.nl \
--to=hverkuil@xs4all.nl \
--cc=dave.hansen@linux.intel.com \
--cc=elfring@users.sourceforge.net \
--cc=jack@suse.cz \
--cc=javier@osg.samsung.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=lstoakes@gmail.com \
--cc=mchehab@kernel.org \
--cc=mhocko@suse.com \
--cc=sakari.ailus@iki.fi \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).