From: Joe Perches <joe@perches.com>
To: Arnd Bergmann <arnd@arndb.de>,
Russell King <linux@armlinux.org.uk>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Darren Hart <dvhart@infradead.org>
Cc: Nick Desaulniers <ndesaulniers@google.com>,
Davidlohr Bueso <dave@stgolabs.net>,
Elena Reshetova <elena.reshetova@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] futex: mark futex_detect_cmpxchg() as 'noinline'
Date: Thu, 07 Mar 2019 09:19:04 -0800 [thread overview]
Message-ID: <b83ed0ab05b12484a70d5f3db742a7a141718a00.camel@perches.com> (raw)
In-Reply-To: <20190307091514.2489338-1-arnd@arndb.de>
On Thu, 2019-03-07 at 10:14 +0100, Arnd Bergmann wrote:
> On 32-bit ARM, I got a link failure in futex_init() when building
> with clang in some random configurations:
>
> kernel/futex.o:(.text.fixup+0x5c): relocation truncated to fit: R_ARM_JUMP24 against `.init.text'
>
> As far as I can tell, the problem is that a branch is over 16MB
> apart in those configurations, but only if it branches back to
> the init text.
>
> Marking the futex_detect_cmpxchg() function as noinline and
> not __init avoids the problem for me.
Perhaps the __init and __exit #defines should be noinline
to allow discarding of the code.
These defines are already marked with __section so I'd've
expected these to be noinline anyway.
---
include/linux/init.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/linux/init.h b/include/linux/init.h
index 5255069f5a9f..806215a74064 100644
--- a/include/linux/init.h
+++ b/include/linux/init.h
@@ -47,7 +47,7 @@
/* These are for everybody (although not all archs will actually
discard it in modules) */
-#define __init __section(.init.text) __cold __latent_entropy __noinitretpoline
+#define __init __section(.init.text) __cold __latent_entropy __noinitretpoline noinline
#define __initdata __section(.init.data)
#define __initconst __section(.init.rodata)
#define __exitdata __section(.exit.data)
@@ -80,7 +80,7 @@
#define __exitused __used
#endif
-#define __exit __section(.exit.text) __exitused __cold notrace
+#define __exit __section(.exit.text) __exitused __cold notrace noinline
/* Used for MEMORY_HOTPLUG */
#define __meminit __section(.meminit.text) __cold notrace \
next prev parent reply other threads:[~2019-03-07 17:21 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-07 9:14 [PATCH 1/2] futex: mark futex_detect_cmpxchg() as 'noinline' Arnd Bergmann
2019-03-07 9:14 ` [PATCH 2/2] ARM: futex: make futex_detect_cmpxchg more reliable Arnd Bergmann
2019-03-07 19:39 ` Nick Desaulniers
2019-03-07 23:48 ` Russell King - ARM Linux admin
2019-03-08 0:04 ` Nick Desaulniers
2019-03-08 9:54 ` Russell King - ARM Linux admin
2019-03-08 8:57 ` Ard Biesheuvel
2019-03-08 9:53 ` Russell King - ARM Linux admin
2019-03-08 10:08 ` Ard Biesheuvel
2019-03-08 10:16 ` Ard Biesheuvel
2019-03-08 10:56 ` Russell King - ARM Linux admin
2019-03-08 10:34 ` Russell King - ARM Linux admin
2019-03-08 10:45 ` Ard Biesheuvel
2019-03-08 10:58 ` Russell King - ARM Linux admin
2019-03-08 11:55 ` Ard Biesheuvel
2019-03-11 14:34 ` Arnd Bergmann
2019-03-11 14:36 ` Ard Biesheuvel
2019-03-11 16:29 ` Arnd Bergmann
2019-03-11 16:36 ` Ard Biesheuvel
2019-03-11 20:58 ` Arnd Bergmann
2019-03-08 11:55 ` Dave Martin
2019-03-07 17:19 ` Joe Perches [this message]
2019-03-07 17:25 ` [PATCH 1/2] futex: mark futex_detect_cmpxchg() as 'noinline' Russell King - ARM Linux admin
2019-03-07 17:42 ` Joe Perches
2019-03-07 18:07 ` Russell King - ARM Linux admin
2019-03-07 18:12 ` Nick Desaulniers
2019-03-07 18:21 ` Nathan Chancellor
2019-03-07 22:24 ` Arnd Bergmann
2020-12-12 12:26 ` Marco Elver
2020-12-12 20:01 ` Thomas Gleixner
2020-12-14 10:22 ` Marco Elver
2020-12-14 13:15 ` Arnd Bergmann
2020-12-15 6:09 ` Guo Ren
2020-12-15 11:26 ` Arnd Bergmann
2020-12-15 19:38 ` Sam Ravnborg
2020-12-15 23:24 ` Arnd Bergmann
2020-12-17 15:32 ` Andreas Larsson
2020-12-17 16:43 ` Arnd Bergmann
2020-12-18 11:08 ` Andreas Larsson
2020-12-17 20:03 ` Sam Ravnborg
2020-12-16 10:07 ` David Laight
2020-12-16 11:40 ` Peter Zijlstra
2020-12-20 15:44 ` Guo Ren
2020-12-20 17:49 ` Arnd Bergmann
2020-12-21 2:58 ` Guo Ren
2021-07-22 20:05 ` Nathan Chancellor
2021-10-25 13:52 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b83ed0ab05b12484a70d5f3db742a7a141718a00.camel@perches.com \
--to=joe@perches.com \
--cc=arnd@arndb.de \
--cc=dave@stgolabs.net \
--cc=dvhart@infradead.org \
--cc=elena.reshetova@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mingo@redhat.com \
--cc=ndesaulniers@google.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).