From: Florian Fainelli <f.fainelli@gmail.com>
To: Antoine Tenart <antoine.tenart@bootlin.com>,
davem@davemloft.net, andrew@lunn.ch, hkallweit1@gmail.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
thomas.petazzoni@bootlin.com, nicolas.ferre@microchip.com,
ludovic.desroches@microchip.com, alexandre.belloni@bootlin.com
Subject: Re: [PATCH net-next] net: phy: micrel: add Asym Pause workaround
Date: Tue, 16 Apr 2019 16:46:29 -0700 [thread overview]
Message-ID: <b864edfa-9876-4905-1fbb-55c31ad50deb@gmail.com> (raw)
In-Reply-To: <20190416101020.22149-1-antoine.tenart@bootlin.com>
On 16/04/2019 03:10, Antoine Tenart wrote:
> The Micrel KSZ9031 PHY may fail to establish a link when the Asymmetric
> Pause capability is set. This issue is described in a Silicon Errata
> (DS80000691D or DS80000692D), which advises to always disable the
> capability. This patch implements the workaround by defining a KSZ9031
> specific get_feature callback to force the Asymmetric Pause capability
> bit to be cleared.
>
> This fixes issues where the link would not come up at boot time, or when
> the Asym Pause bit was set later on.
>
> Signed-off-by: Antoine Tenart <antoine.tenart@bootlin.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
next prev parent reply other threads:[~2019-04-16 23:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-16 10:10 [PATCH net-next] net: phy: micrel: add Asym Pause workaround Antoine Tenart
2019-04-16 16:39 ` Andrew Lunn
2019-04-16 23:46 ` Florian Fainelli [this message]
2019-04-17 4:36 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b864edfa-9876-4905-1fbb-55c31ad50deb@gmail.com \
--to=f.fainelli@gmail.com \
--cc=alexandre.belloni@bootlin.com \
--cc=andrew@lunn.ch \
--cc=antoine.tenart@bootlin.com \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ludovic.desroches@microchip.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).