From: "Andrew F. Davis" <afd@ti.com>
To: Tony Lindgren <tony@atomide.com>, Mark Rutland <mark.rutland@arm.com>
Cc: <linux-omap@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ARM: OMAP: Use ARM SMC Calling Convention when OP-TEE is available
Date: Mon, 18 Nov 2019 17:13:44 -0500 [thread overview]
Message-ID: <b86e1d66-1566-521c-a445-4f0ae2fd95d6@ti.com> (raw)
In-Reply-To: <20191118215759.GD35479@atomide.com>
On 11/18/19 4:57 PM, Tony Lindgren wrote:
> Hi,
>
> * Andrew F. Davis <afd@ti.com> [191118 08:53]:
>> +#define OMAP_SIP_SMC_STD_CALL_VAL(func_num) \
>> + ARM_SMCCC_CALL_VAL(ARM_SMCCC_STD_CALL, ARM_SMCCC_SMC_32, \
>> + ARM_SMCCC_OWNER_SIP, (func_num))
>> +
>> +void omap_smc1(u32 fn, u32 arg)
>> +{
>> + struct device_node *optee;
>> + struct arm_smccc_res res;
>> +
>> + /*
>> + * If this platform has OP-TEE installed we use ARM SMC calls
>> + * otherwise fall back to the OMAP ROM style calls.
>> + */
>> + optee = of_find_node_by_path("/firmware/optee");
>> + if (optee) {
>> + arm_smccc_smc(OMAP_SIP_SMC_STD_CALL_VAL(fn), arg,
>> + 0, 0, 0, 0, 0, 0, &res);
>> + WARN(res.a0, "Secure function call 0x%08x failed\n", fn);
>> + } else {
>> + _omap_smc1(fn, arg);
>> + }
>> +}
>
> I think we're better off just making arm_smccc_smc() work properly.
> See cat arch/arm*/kernel/smccc-call.S.
>
arm_smccc_smc() does work properly already, I'm using it here.
> If quirk handling is needed, looks like ARM_SMCCC_QUIRK_STATE_OFFS
> can be used.
>
Tried that [0], was NAKd. Making quirk-free SMCCC calls if OP-TEE is
detected seems to be the suggested path forward, QCOM got a pass,
doesn't look like we will get the same.
+Mark, in case you want to comment if this patch matches what you had in
mind.
[0] https://www.spinics.net/lists/arm-kernel/msg607263.html
Andrew
> AFAIK this should work both for optee and the current use cases.
>
> Regards,
>
> Tony
>
next prev parent reply other threads:[~2019-11-18 22:13 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-18 16:52 [PATCH] ARM: OMAP: Use ARM SMC Calling Convention when OP-TEE is available Andrew F. Davis
2019-11-18 21:57 ` Tony Lindgren
2019-11-18 22:13 ` Andrew F. Davis [this message]
2019-11-18 22:31 ` Tony Lindgren
2019-11-19 1:13 ` Andrew F. Davis
2019-11-19 16:21 ` Tony Lindgren
2019-11-19 16:30 ` Tony Lindgren
2019-11-19 16:30 ` Andrew F. Davis
2019-11-19 16:42 ` Tony Lindgren
2019-11-19 18:05 ` Tony Lindgren
2019-11-19 18:20 ` Andrew F. Davis
2019-11-19 18:32 ` Tony Lindgren
2019-11-19 18:50 ` Andrew F. Davis
2019-11-19 19:07 ` Tony Lindgren
2019-11-19 19:12 ` Andrew F. Davis
2019-11-19 19:20 ` Tony Lindgren
2019-11-19 19:35 ` Andrew F. Davis
2019-11-19 19:44 ` Tony Lindgren
2019-11-19 19:59 ` Andrew F. Davis
2019-12-16 20:56 ` Andrew F. Davis
2019-12-16 21:04 ` Tony Lindgren
2019-12-16 22:34 ` Andrew F. Davis
2019-12-16 22:41 ` Tony Lindgren
2019-12-17 13:14 ` Andrew F. Davis
2019-12-17 15:07 ` Tony Lindgren
2019-12-17 17:01 ` Andrew F. Davis
2019-12-17 17:11 ` Tony Lindgren
2019-12-17 17:18 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b86e1d66-1566-521c-a445-4f0ae2fd95d6@ti.com \
--to=afd@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).