From: Guenter Roeck <linux@roeck-us.net>
To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Philipp Zabel <p.zabel@pengutronix.de>,
linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mips@vger.kernel.org, John Crispin <john@phrozen.org>
Cc: Lee Jones <lee.jones@linaro.org>, kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] MIPS: ralink: of: fix build of rt2880_wdt watchdog module
Date: Mon, 5 Jul 2021 09:08:41 -0700 [thread overview]
Message-ID: <b87bbb80-ed02-447d-f778-7997848731cd@roeck-us.net> (raw)
In-Reply-To: <9d98ec40-757d-28c7-1669-a683b2cd3881@canonical.com>
On 7/5/21 8:15 AM, Krzysztof Kozlowski wrote:
> On 14/05/2021 16:04, Krzysztof Kozlowski wrote:
>> On 14/05/2021 09:48, Guenter Roeck wrote:
>>> On 5/14/21 6:17 AM, Krzysztof Kozlowski wrote:
>>>> When rt2880_wdt watchdog driver is built as a module, the
>>>> rt_sysc_membase needs to be exported (it is being used via inlined
>>>> rt_sysc_r32):
>>>>
>>>> ERROR: modpost: "rt_sysc_membase" [drivers/watchdog/rt2880_wdt.ko] undefined!
>>>>
>>>> Reported-by: kernel test robot <lkp@intel.com>
>>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
>>>
>>> Acked-by: Guenter Roeck <linux@roeck-us.net>
>>>
>>> I don't see a recent change in the code. Has that problem been there
>>> all along ?
>>
>> I think the problem was there always but 0-day builder did not hit it
>> until recently:
>> https://lore.kernel.org/lkml/202105082122.yrF7ploN-lkp@intel.com/
>
> Hi Guenter,
>
> It seems that patch was not applied. Anything to fix here?
>
I see commit fef532ea0cd8 ("MIPS: ralink: export rt_sysc_membase for
rt2880_wdt.c"). Does that not solve the problem ?
Guenter
next prev parent reply other threads:[~2021-07-05 16:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-14 13:17 [PATCH] MIPS: ralink: of: fix build of rt2880_wdt watchdog module Krzysztof Kozlowski
2021-05-14 13:48 ` Guenter Roeck
2021-05-14 14:04 ` Krzysztof Kozlowski
2021-07-05 15:15 ` Krzysztof Kozlowski
2021-07-05 16:08 ` Guenter Roeck [this message]
2021-07-05 16:21 ` Krzysztof Kozlowski
2021-07-05 16:32 ` Guenter Roeck
2021-05-14 18:31 ` John Crispin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b87bbb80-ed02-447d-f778-7997848731cd@roeck-us.net \
--to=linux@roeck-us.net \
--cc=john@phrozen.org \
--cc=krzysztof.kozlowski@canonical.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=lkp@intel.com \
--cc=p.zabel@pengutronix.de \
--cc=tsbogend@alpha.franken.de \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).