From: Tom Rix <trix@redhat.com>
To: Xu Yilun <yilun.xu@intel.com>,
lee.jones@linaro.org, linux-kernel@vger.kernel.org
Cc: matthew.gerlach@linux.intel.com, russell.h.weight@intel.com,
lgoncalv@redhat.com, hao.wu@intel.com
Subject: Re: [PATCH 1/2] mfd: intel-m10-bmc: fix the register access range
Date: Wed, 20 Jan 2021 07:42:47 -0800 [thread overview]
Message-ID: <b885ffbf-b8be-5c75-7552-739c405bac80@redhat.com> (raw)
In-Reply-To: <1611110081-10056-1-git-send-email-yilun.xu@intel.com>
A side note..
I think it would be good if the intel-m10-bmc.* files were tracked in the MAINTAINERS files.
I was surprised the Lee was the only reviewer. Maybe Yilun or Matt should also be added.
On 1/19/21 6:34 PM, Xu Yilun wrote:
> This patch fixes the max register address of MAX 10 BMC. The range
> 0x20000000 ~ 0x200000fc are for control registers of the QSPI flash
> controller, which are not accessible to host.
>
> Signed-off-by: Xu Yilun <yilun.xu@intel.com>
> ---
> include/linux/mfd/intel-m10-bmc.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/mfd/intel-m10-bmc.h b/include/linux/mfd/intel-m10-bmc.h
> index c8ef2f1..06da62c 100644
> --- a/include/linux/mfd/intel-m10-bmc.h
> +++ b/include/linux/mfd/intel-m10-bmc.h
> @@ -11,7 +11,7 @@
>
> #define M10BMC_LEGACY_SYS_BASE 0x300400
> #define M10BMC_SYS_BASE 0x300800
> -#define M10BMC_MEM_END 0x200000fc
> +#define M10BMC_MEM_END 0x1fffffff
Reviewed-by: Tom Rix <trix@redhat.com>
>
> /* Register offset of system registers */
> #define NIOS2_FW_VERSION 0x0
prev parent reply other threads:[~2021-01-20 17:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-20 2:34 [PATCH 1/2] mfd: intel-m10-bmc: fix the register access range Xu Yilun
2021-01-20 2:34 ` [PATCH 2/2] mfd: intel-m10-bmc: add access table configuration to the regmap Xu Yilun
2021-01-20 15:32 ` Tom Rix
2021-01-21 8:05 ` Xu Yilun
2021-01-21 13:19 ` Tom Rix
2021-01-22 3:23 ` Xu Yilun
2021-01-20 15:42 ` Tom Rix [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b885ffbf-b8be-5c75-7552-739c405bac80@redhat.com \
--to=trix@redhat.com \
--cc=hao.wu@intel.com \
--cc=lee.jones@linaro.org \
--cc=lgoncalv@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.gerlach@linux.intel.com \
--cc=russell.h.weight@intel.com \
--cc=yilun.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).