From: Paul Menzel <pmenzel@molgen.mpg.de>
To: David Miller <davem@davemloft.net>
Cc: bhe@redhat.com, netdev@vger.kernel.org,
michael.chan@broadcom.com, linux-kernel@vger.kernel.org,
Dept-GELinuxNICDev@cavium.com, rasesh.mody@cavium.com,
harish.patil@cavium.com, frank@undermydesk.org,
jsr@dex.edzone.net, jroedel@suse.de, dyoung@redhat.com
Subject: Re: [PATCH v2 0/2] bnx2: Wait for in-flight DMA to complete at probe stage
Date: Mon, 14 Nov 2016 18:35:17 +0100 [thread overview]
Message-ID: <b8bbc1a5-f00e-c257-9119-f5e91bd68b59@molgen.mpg.de> (raw)
In-Reply-To: <20161114.122838.1039215178593568702.davem@davemloft.net>
On 11/14/16 18:28, David Miller wrote:
> From: Paul Menzel <pmenzel@molgen.mpg.de>
> Date: Mon, 14 Nov 2016 09:25:47 +0100
>> On 11/13/16 06:01, Baoquan He wrote:
>>> This is v2 post.
>>>
>>> In commit 3e1be7a ("bnx2: Reset device during driver initialization"),
>>> firmware requesting code was moved from open stage to probe stage.
>>> The reason is in kdump kernel hardware iommu need device be reset in
>>> driver probe stage, otherwise those in-flight DMA from 1st kernel
>>> will continue going and look up into the newly created io-page tables.
>>> However bnx2 chip resetting involves firmware requesting issue, that
>>> need be done in open stage.
>>>
>>> Michale Chan suggested we can just wait for the old in-flight DMA to
>>> complete at probe stage, then though without device resetting, we
>>> don't need to worry the old in-flight DMA could continue looking up
>>> the newly created io-page tables.
>>>
>>> v1->v2:
>>> Michael suggested to wait for the in-flight DMA to complete at probe
>>> stage. So give up the old method of trying to reset chip at probe
>>> stage, take the new way accordingly.
>>
>> thank you for posting the updated series. Could you please resend a v3
>> with stable@vger.kernel.org added [1]?
>
> This is not the proper procedure for networking patches.
Oh, I didn’t know that. Sorry for spreading false information.
Kind regards,
Paul
next prev parent reply other threads:[~2016-11-14 17:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-13 5:01 [PATCH v2 0/2] bnx2: Wait for in-flight DMA to complete at probe stage Baoquan He
2016-11-13 5:01 ` [PATCH v2 1/2] Revert "bnx2: Reset device during driver initialization" Baoquan He
2016-11-13 5:01 ` [PATCH v2 2/2] bnx2: Wait for in-flight DMA to complete at probe stage Baoquan He
2016-11-13 19:02 ` Michael Chan
2016-11-14 8:25 ` [PATCH v2 0/2] " Paul Menzel
2016-11-14 9:10 ` Baoquan He
2016-11-14 17:28 ` David Miller
2016-11-14 17:35 ` Paul Menzel [this message]
2016-11-14 21:21 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b8bbc1a5-f00e-c257-9119-f5e91bd68b59@molgen.mpg.de \
--to=pmenzel@molgen.mpg.de \
--cc=Dept-GELinuxNICDev@cavium.com \
--cc=bhe@redhat.com \
--cc=davem@davemloft.net \
--cc=dyoung@redhat.com \
--cc=frank@undermydesk.org \
--cc=harish.patil@cavium.com \
--cc=jroedel@suse.de \
--cc=jsr@dex.edzone.net \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=rasesh.mody@cavium.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).